mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Maciej Wieczor-Retman <m.wieczorretman@pm.me>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org
Cc: pawel.chmielewski@linux.intel.com,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] x86/cpu: Required feature bits sanity check
Date: Fri, 13 Feb 2026 12:17:02 -0800	[thread overview]
Message-ID: <5fd597a1-46fe-4f46-98ee-d346260c85b5@zytor.com> (raw)
In-Reply-To: <1bfbcdf7d2d7d5a1180e0de92d14cd6c246d5ea5.1770908783.git.m.wieczorretman@pm.me>

On 2026-02-12 07:35, Maciej Wieczor-Retman wrote:
> From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> 
> After cpu identification concludes, do a sanity check by comparing the
> final x86_capability bitmask with the pre-defined required feature bits.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>

For as much as it matters (since I originally requested Maciej implemented this):

Acked-by: H. Peter Anvin (Intel) <hpa@zytor.com>

We really, really need this. We have this check in the BIOS boot stub, but
none of the modern stubs have included the equivalent code.

	-hpa


  reply	other threads:[~2026-02-13 20:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 15:33 [PATCH v5 0/3] x86: Capability bits fix and required " Maciej Wieczor-Retman
2026-02-12 15:34 ` [PATCH v5 1/3] x86/cpu: Clear feature bits disabled at compile-time Maciej Wieczor-Retman
2026-02-12 15:58   ` Borislav Petkov
2026-02-12 16:23     ` Maciej Wieczor-Retman
2026-02-12 21:34       ` H. Peter Anvin
2026-02-12 21:51         ` Borislav Petkov
2026-02-12 23:04           ` Sohil Mehta
2026-02-12 23:47             ` Borislav Petkov
2026-02-13  0:14               ` Sohil Mehta
2026-02-13  0:36                 ` Sohil Mehta
2026-02-13  0:58                 ` Borislav Petkov
2026-02-13 20:11                   ` H. Peter Anvin
2026-02-12 15:35 ` [PATCH v5 2/3] x86/cpu: Check if feature string is non-zero Maciej Wieczor-Retman
2026-02-13  0:28   ` Sohil Mehta
2026-02-13 10:02     ` Maciej Wieczor-Retman
2026-02-13 18:22       ` Sohil Mehta
2026-02-13 19:10         ` Maciej Wieczor-Retman
2026-02-13 20:00           ` Sohil Mehta
2026-02-13 20:26             ` Maciej Wieczor-Retman
2026-02-13 20:15       ` H. Peter Anvin
2026-02-13 20:24         ` Maciej Wieczor-Retman
2026-02-12 15:35 ` [PATCH v5 3/3] x86/cpu: Required feature bits sanity check Maciej Wieczor-Retman
2026-02-13 20:17   ` H. Peter Anvin [this message]
2026-02-13 20:23 ` [PATCH v5 0/3] x86: Capability bits fix and required " H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fd597a1-46fe-4f46-98ee-d346260c85b5@zytor.com \
    --to=hpa@zytor.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.wieczorretman@pm.me \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mingo@redhat.com \
    --cc=pawel.chmielewski@linux.intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®