From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DE9C4361B for ; Tue, 15 Dec 2020 19:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1793722B43 for ; Tue, 15 Dec 2020 19:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbgLOT4v (ORCPT ); Tue, 15 Dec 2020 14:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgLOT4h (ORCPT ); Tue, 15 Dec 2020 14:56:37 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B05DC06179C; Tue, 15 Dec 2020 11:55:56 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id n26so29458972eju.6; Tue, 15 Dec 2020 11:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hgbpczhIgWcJ9kOmJE2lzKhI3+pU/J6Ah3rCJFwnT/Y=; b=IqwmJpwZ5jYDClMOQqOWIPApxnNEK2fsdac6O5WqsZx8sFJU1gwBYMHKPrzInF7drE jfQPwixTKwA1kyv2nBnj6h9LZ4kEdQlCfw1BEsgMV0pbc1o/DUNbcS0zSk2EdZWLf6Gk NOvu+0/KycCPMjPf4hyZOdKNw7TK3c8HH+HQIIx/IJlXjQerv+3cX9/s7qW/qxxl232b U/encgjr3nvds77wreBOHfdmmHoTMmuUGI1JeliaGzArTloFrp0QMX4YYhtzTSZxnUhA Pv0O4m3DMy7IdQMAUcUwaC8ZEwuLEEZrSHm81yRGN+t6nC/1cBZZXYBUjiWtbEtWoqmD LgQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hgbpczhIgWcJ9kOmJE2lzKhI3+pU/J6Ah3rCJFwnT/Y=; b=Hrmy+C/8h3mOX+hFzdqbn4raWKloITFVckkCd+Kq2/wbByPCBpHYQMeVC1Du1zNTN1 liJ6i8YX3kP8V+GfMDhj0V/A1iOM4to9X8qbEHW5YxQlojhXzBa8sQWV1v+epIZRFI+P pm6fXFl+7eK/XKCDPyRIyAayOrm32LAGbQhj3vy82a1r7Xgg5lzztSz9FhBmWg3XxkTA uLvuSls0AZdCg0keVix0Rrh1X+48OWZKybtHGrZxEZQNjQJ0Zh59800d6jh20yIPflrY E92NGT+vVzt9nGJTCjYa0SpjFk920awxd++jS0lN7rEHgsUp6tFUaKGwr3vxbuhFRXd7 9j3A== X-Gm-Message-State: AOAM5329UAH1FlOzmm/jiqU0xM1bN5UHRy7lOsctg5DTTaKtkRlyolN2 CDj2YkW/GOvC6LAT2jPFUp7SDxlPESkXVw== X-Google-Smtp-Source: ABdhPJxtMaw1aQXNeyC3jAQyljCTgGN2KiTagUSIRKg0rzT0SCXxyJXclp9JCDz8X23CnrmupFScYQ== X-Received: by 2002:a17:906:7b8d:: with SMTP id s13mr28093936ejo.479.1608062154895; Tue, 15 Dec 2020 11:55:54 -0800 (PST) Received: from [192.168.2.202] (pd9e5a7aa.dip0.t-ipconnect.de. [217.229.167.170]) by smtp.gmail.com with ESMTPSA id a6sm19209575edv.74.2020.12.15.11.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 11:55:53 -0800 (PST) Subject: Re: [PATCH v2 -next] platform: surface: fix non-PM_SLEEP build warnings To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Hans de Goede , platform-driver-x86@vger.kernel.org References: <20201214233336.19782-1-rdunlap@infradead.org> From: Maximilian Luz Message-ID: <5fd70f29-2795-5b46-4bc9-e60a26efee88@gmail.com> Date: Tue, 15 Dec 2020 20:55:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201214233336.19782-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/20 12:33 AM, Randy Dunlap wrote: > Fix build warnings when CONFIG_PM_SLEEP is not enabled and these > functions are not used: > > ../drivers/platform/surface/surface_gpe.c:189:12: warning: ‘surface_gpe_resume’ defined but not used [-Wunused-function] > static int surface_gpe_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~ > ../drivers/platform/surface/surface_gpe.c:184:12: warning: ‘surface_gpe_suspend’ defined but not used [-Wunused-function] > static int surface_gpe_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > > Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS Surface device") > Signed-off-by: Randy Dunlap > Cc: Maximilian Luz > Cc: Hans de Goede > Cc: platform-driver-x86@vger.kernel.org > --- > v2: dropped Maximilian's RVB tag since the patch changed > use preferred __maybe_unused instead of ifdeffery: > https://lore.kernel.org/patchwork/patch/732981/ > > drivers/platform/surface/surface_gpe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20201214.orig/drivers/platform/surface/surface_gpe.c > +++ linux-next-20201214/drivers/platform/surface/surface_gpe.c > @@ -181,12 +181,12 @@ static int surface_lid_enable_wakeup(str > return 0; > } > > -static int surface_gpe_suspend(struct device *dev) > +static int __maybe_unused surface_gpe_suspend(struct device *dev) > { > return surface_lid_enable_wakeup(dev, true); > } > > -static int surface_gpe_resume(struct device *dev) > +static int __maybe_unused surface_gpe_resume(struct device *dev) > { > return surface_lid_enable_wakeup(dev, false); > } > Code looks good to me. Reviewed-by: Maximilian Luz As already mentioned before, I'd prefer the subject line to be "platform/surface: gpe: ...", or at least "platform/surface: ..." for consistency with other commits. May just be a personal preference though, so nothing that should prevent it from being applied. Thanks, Max