mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] soc: qcom: ubwc: use no-uwbc config for MSM8917
Date: Thu, 14 Aug 2025 11:23:47 +0200	[thread overview]
Message-ID: <5fd77c1c-ffb3-4413-929a-36437b170591@oss.qualcomm.com> (raw)
In-Reply-To: <20250814-more-ubwc-v1-1-d520f298220d@oss.qualcomm.com>

On 8/14/25 9:22 AM, Dmitry Baryshkov wrote:
> MSM8917 has MDSS 1.15 and Adreno 308, neither of which support UBWC.
> Change UBWC configuration to point out that UBWC is not supported on
> this platform.
> 
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/ubwc_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
> index 1490a7f63767bba176e8e2e76891d7d2c424bb7f..5113c2902bf2ba3711bb14b35bbbb8a2b49b8cfe 100644
> --- a/drivers/soc/qcom/ubwc_config.c
> +++ b/drivers/soc/qcom/ubwc_config.c
> @@ -225,7 +225,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
>  	{ .compatible = "qcom,apq8096", .data = &msm8998_data },
>  	{ .compatible = "qcom,msm8226", .data = &no_ubwc_data },
>  	{ .compatible = "qcom,msm8916", .data = &no_ubwc_data },
> -	{ .compatible = "qcom,msm8917", .data = &msm8937_data },
> +	{ .compatible = "qcom,msm8917", .data = &no_ubwc_data },

https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/arch/arm/boot/dts/qcom/msm8917-mdss.dtsi#93

&mdss_rotator {
	/delete-property/ qcom,mdss-has-ubwc;
};

argh! thanks for catching that

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2025-08-14  9:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14  7:22 [PATCH 0/4] soc: qcom: ubwc: more fixes and missing platforms Dmitry Baryshkov
2025-08-14  7:22 ` [PATCH 1/4] soc: qcom: ubwc: use no-uwbc config for MSM8917 Dmitry Baryshkov
2025-08-14  9:23   ` Konrad Dybcio [this message]
2025-08-14  7:22 ` [PATCH 2/4] soc: qcom: ubwc: add more missing platforms Dmitry Baryshkov
2025-08-14  9:24   ` Konrad Dybcio
2025-08-14  7:22 ` [PATCH 3/4] soc: qcom: add configuration for MSM8929 Dmitry Baryshkov
2025-08-14  9:24   ` Konrad Dybcio
2025-08-14  7:22 ` [PATCH 4/4] soc: qcom: use no-UBWC config for MSM8956/76 Dmitry Baryshkov
2025-08-14  9:25   ` Konrad Dybcio
2025-08-14 11:31     ` Dmitry Baryshkov
2025-08-19 20:53 ` [PATCH 0/4] soc: qcom: ubwc: more fixes and missing platforms Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fd77c1c-ffb3-4413-929a-36437b170591@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®