From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CAAC43381 for ; Fri, 19 Mar 2021 11:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FD7864F7F for ; Fri, 19 Mar 2021 11:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbhCSL2K (ORCPT ); Fri, 19 Mar 2021 07:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbhCSL1r (ORCPT ); Fri, 19 Mar 2021 07:27:47 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4282AC06174A for ; Fri, 19 Mar 2021 04:27:47 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id x13so8738145wrs.9 for ; Fri, 19 Mar 2021 04:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=2VJaPR0cL5VhiRl/G98uxV1YtiqmA8CybmYYke4TwKI=; b=KMjl+VBJcDtflimUBJBK78KSATLmG9uVLVByHXgpxmc6DOcX9hQU34JCY/ldwGshcT YJBpLs8zmTWOM0KVKtpHzdbqO0FkI8qUn8TIsGSN5/ClfRslx2Ic6TGVQOe/0PsmmPsM VjCvD5nXEu6Sn2LrS9gwfr5aeNv9o0m3WHl9xCnSYzZakFOMzpyh3F8V1IyC3/+8KsRt J0A/qQF9Dv1SC1AoTfBA2y2nG779nkBXrz8bYGAdON3kaBZwmE85ezhIO+sm0blEs5HT M8fg90yUHbLVwaEM0CShvJN6qIpYfmAgqeK4eJwZSrLhuo3BLXt0pWSVKxHOCVLpVJ0Q +5jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2VJaPR0cL5VhiRl/G98uxV1YtiqmA8CybmYYke4TwKI=; b=ZxO/45GXxMn+QaLWOhHABtPwYghYIb9XkTHNP/Fz2sGzh6nD2TiR79Q3PjFaAaumWE TP3NptMMc2CltGwH6fWL1OP9d/0vRWPtCDdh/ewtPXhcqlwD9MUU7vKPQlRTlYUReAcD OSKgGVZugGcoOgl0Z7TxZUdnxyNfnPBB9YnrQjmmA6bJkVMmHH0Hvj+PDkSRHYtLnjVD 7lLMOvePO0na27VTbdN+9stCGgYyv9RFWFC7cQo2f55JqQhkNtmS5OM40WvJF0vOmVV3 6ex9VR3lUQ+yplC/9YI0rAVgTru8NEOZm9XqsVWYSL6Gokhc99kdPRhW0Q0N1bowHaMo gmIw== X-Gm-Message-State: AOAM53153gZ+y2VkXjkm0oZw8QkNkXLeet/F1IazNeTVLGOgnUTvON1m Iv9rM96H1LvcdkSr9vVrcLzxSg== X-Google-Smtp-Source: ABdhPJwIXBunKgGFPhv+gFeiV3dd3BaZbnDn4LZu4azzEckiqCYMC/J3ClDH1Q1xkf1o5KRlOVpwBA== X-Received: by 2002:adf:e5cf:: with SMTP id a15mr3961013wrn.226.1616153265918; Fri, 19 Mar 2021 04:27:45 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:60ac:4ae1:fb5b:5813? ([2a01:e34:ed2f:f020:60ac:4ae1:fb5b:5813]) by smtp.googlemail.com with ESMTPSA id a14sm7272722wrn.5.2021.03.19.04.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 04:27:45 -0700 (PDT) Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support To: Robert Foss , amitk@kernel.org, Andy Gross , Bjorn Andersson , rui.zhang@intel.com, Rob Herring , linux-pm@vger.kernel.org, MSM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Vinod Koul References: <20210319104855.85075-1-robert.foss@linaro.org> <20210319104855.85075-2-robert.foss@linaro.org> From: Daniel Lezcano Message-ID: <5fdd232b-6392-8684-2be2-6ff4375b7a8c@linaro.org> Date: Fri, 19 Mar 2021 12:27:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/03/2021 12:24, Robert Foss wrote: > On Fri, 19 Mar 2021 at 11:49, Robert Foss wrote: >> >> sm8350 has 29 thermal sensors split across two tsens controllers. Add >> the thermal zones to expose them and wireup the cpus to throttle their >> frequencies on crossing passive temperature thresholds. >> >> Signed-off-by: Robert Foss >> --- [ ... ] >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 Please trim when replying to a large patch file. [ ... ] >> + trips { >> + nspss1_alert0: trip-point0 { >> + temperature = <90000>; >> + hysteresis = <1000>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 [ ... ] >> + trips { >> + nspss2_alert0: trip-point0 { >> + temperature = <90000>; >> + hysteresis = <1000>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + >> + // TODO: What is the NSP subsystem? > > This comment should not have been included, will remove in v2 > [ ... ] -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog