From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEE8293C42 for ; Sun, 28 Dec 2025 14:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766932961; cv=none; b=iXBKRoHkNw4M8XPN24B3FxZWlnqpSYoNSlxG+ZJwFnrD7Aq8noXe/dp4vSx2u99g8lEJpywcdn8VlonCl24xOlhevSSQEY4VGE8mynybuIiy63xTbAp/Tj6BgHpi4NxmW9SpmIeObVYH6Bjd00W9idWiGIGSRaPp3NDPfhJyR3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766932961; c=relaxed/simple; bh=JPG/RzZhWVCp1ZFmNfPJQRrkOSlkYOST8bscerOo3gU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N1QX6lAokbXbEHb99z0cYKfiMSzW8a569MCKDBQ9/O83chM+qC1xxHm3jkJwc8nVsWOG6KPwEtxTN81CY9yIfU0HzZiH8qAg6j69ayx8FSUDoCsNOKuMc2vCJGFNue2C2n2AHXFE5QppWSJS57Sb0fdpodNHdi6LtLdA+gADIKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hZa3IbZs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VsUrg0mS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hZa3IbZs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VsUrg0mS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766932959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8bryifZcLhB7SqhU4h4jRRAVhy7f0MZZFCKs5cin8c=; b=hZa3IbZs/NuSIUZS6u4lw3kRYsYxLZ8/pn5inlFzhndlL/ZHFPXkOX1OTa9XDIzgcOqR7O L4n1CllOKVTB9Y/LxqAInsVapUHSDtJanT/VlIS23Rv7+JEHLUC+s6Ae8aQo3S9RoCSrIv kUpyOytt7vR315Cri0MW0UVHooGJ6C0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-rwHLdm3YMfaGDVw4gMxm6Q-1; Sun, 28 Dec 2025 09:42:36 -0500 X-MC-Unique: rwHLdm3YMfaGDVw4gMxm6Q-1 X-Mimecast-MFC-AGG-ID: rwHLdm3YMfaGDVw4gMxm6Q_1766932955 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-477a11d9e67so48716895e9.2 for ; Sun, 28 Dec 2025 06:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766932955; x=1767537755; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G8bryifZcLhB7SqhU4h4jRRAVhy7f0MZZFCKs5cin8c=; b=VsUrg0mS1/nBtuc7mdfxmA6O3icrzsH96hQDRuNYdp+aoyUsBFQ7uTfO3Vg5WEQfEx jjdVJLaMc1JUcA4damBBWnnuxst1v2nUtFk1MYnxin2fqleZZFhVyt5fm4MNwQxFgFCt iCueSi9k/K1ow4Bfl2lB4PbxLWk3cEO87yjZ5zU0SscvQREruMeS7zZmdH9kcr79TNZD IPpTm9LRwlopvRw5XLF4A0cwa3yl9gYK9xeORUbWQmX36f+UvTDMQAzrCN0z5qbXmAfP Xpv/HF5cQ1vs2Wnrje6hV18IPI+kTp6iiZP9321Phhu+B3KQMhiXnkBpnZ2HuktfTi/g E+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766932955; x=1767537755; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G8bryifZcLhB7SqhU4h4jRRAVhy7f0MZZFCKs5cin8c=; b=aNOHsZFmoLvfxAygbr7Zjhi7pvseegTpRrPqg9brgJ5GkJ2XXxd7doQeD7jfHnK+Fs pNCghEuIW0VH1U6mzMdOOfKCCqGbqo784XtjXvgYizJEYVxtoPb3b+6Brf2HCncaUJXb 6bddqhdNoI5t47iN+tAJcqrBC+FOGwrZq3tVdnvjS3/A8xb5WjBsLNJqoVH0sLBcnhMJ SFfORyiDYGxNtphKWxxrMESf34c3GWQ9OCjAAcbJ1h94ZrnQwS7UioOmxiwK+/juIdsU 7rNh9R7uot+ZjIgjFcFWpPosVxtJvU12q7dst3MTX7wjScLXC/1hr14yDoA0DEnqyZSo j6sA== X-Forwarded-Encrypted: i=1; AJvYcCWR6TxYIPpd0h363ZC1rTKPTw9vRX9hS4pVWOSdpFzMgXfhPdzqIRW6h9Yz+6kXgXl/j1cxAljR1QcU/zY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7+Q239eOruEoiJCYZPzx5lwqu2CuOMDSlGQDuxzqarfCRkdFP qsGq/Djc2RBEgmssIxG6kz3lQK6cdqScIJOxxgAuJ2loYBhjYq4eCT3uQf/1hcNB+LvS4o9iJvh pevfqgmwYbXqF0aH3U6gd3iABQXuqcTYIInOX2xEnzETmMvKCmGjtlTHsbd4hYkEuMw== X-Gm-Gg: AY/fxX7AQ/YSHZBWlyTUpkvOci8jmg1TMRBjkURmNmEhwk46BOxTpL2Oy8S+tCViYjw 4Bdcl7ZSwQNdnSdsU3F4G7MiKASwI8nOxHqWGLvF5ybXi84YJgOKfARSU4UqJZa0eyG9XHSFNmp N6YpNR/6AicsRkWVvC481z3Ob5chpi+rOpRqApdCozKBEyGPaglZ6dLTDqihSPjE3JRW3EZpjVa kcLDIBRRdS02DRpRsRp0fwCWR3IlcA+ShIBnb9kPVMJnz1YXUdgdOAk/2tQuDCt407v8TuYRZ7g skwrGrrF29frajzCWa9lbg+8sLNqDgUHXgHY9BGXgZTDTWVz1zPrweom6fEPRt36XUPkHeVmXfn 9ohTAJJ2IKdX5vg== X-Received: by 2002:a05:600c:3489:b0:477:7ae0:cd6e with SMTP id 5b1f17b1804b1-47d206a9856mr274621965e9.5.1766932955093; Sun, 28 Dec 2025 06:42:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6f/QOt+EFLwIiOz3zZKaye78peQJoKonMvSd+nAHO48JmNttMUR/PKVg2n8Lh7V90fWHv6w== X-Received: by 2002:a05:600c:3489:b0:477:7ae0:cd6e with SMTP id 5b1f17b1804b1-47d206a9856mr274621615e9.5.1766932954702; Sun, 28 Dec 2025 06:42:34 -0800 (PST) Received: from [192.168.88.32] ([169.155.232.231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324e9ba877sm56566919f8f.0.2025.12.28.06.42.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 06:42:34 -0800 (PST) Message-ID: <5fe241dd-ae17-4cfe-80f7-e7ea80f8b781@redhat.com> Date: Sun, 28 Dec 2025 15:42:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/7] ptp: vmclock: Add VM generation counter and ACPI notification To: "Chalios, Babis" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "richardcochran@gmail.com" , "dwmw2@infradead.org" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" Cc: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Graf (AWS), Alexander" , "mzxreary@0pointer.de" , "Cali, Marco" References: <20251218142408.8395-1-bchalios@amazon.es> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251218142408.8395-1-bchalios@amazon.es> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/18/25 3:24 PM, Chalios, Babis wrote: > Similarly to live migration, starting a VM from some serialized state > (aka snapshot) is an event which calls for adjusting guest clocks, hence > a hypervisor should increase the disruption_marker before resuming the > VM vCPUs, letting the guest know. > > However, loading a snapshot, is slightly different than live migration, > especially since we can start multiple VMs from the same serialized > state. Apart from adjusting clocks, the guest needs to take additional > action during such events, e.g. recreate UUIDs, reset network > adapters/connections, reseed entropy pools, etc. These actions are not > necessary during live migration. This calls for a differentiation > between the two triggering events. > > We differentiate between the two events via an extra field in the > vmclock_abi, called vm_generation_counter. Whereas hypervisors should > increase the disruption marker in both cases, they should only increase > vm_generation_counter when a snapshot is loaded in a VM (not during live > migration). > > Additionally, we attach an ACPI notification to VMClock. Implementing > the notification is optional for the device. VMClock device will declare > that it implements the notification by setting > VMCLOCK_FLAG_NOTIFICATION_PRESENT bit in vmclock_abi flags. Hypervisors > that implement the notification must send an ACPI notification every > time seq_count changes to an even number. The driver will propagate > these notifications to userspace via the poll() interface. There are a few formal things to adjust (reverse christmas tree order in variable declaration, empty changelog in patch 6/7, prefer #if IS_ENABLED() over #ifdef). Moreover: ## Form letter - net-next-closed The net-next tree is closed for new drivers, features, code refactoring and optimizations due to the merge window and the winter break. We are currently accepting bug fixes only. Please repost when net-next reopens after Jan 2nd. RFC patches sent for review only are obviously welcome at any time.