From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751146AbdA1ASn (ORCPT ); Fri, 27 Jan 2017 19:18:43 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55807 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750741AbdA1ASf (ORCPT ); Fri, 27 Jan 2017 19:18:35 -0500 Subject: Re: [PATCH V2 0/1] percpu-refcount: fix reference leak during percpu-atomic transition To: Tejun Heo References: <1485559936-14133-1-git-send-email-dougmill@linux.vnet.ibm.com> <20170128001349.GB2476@mtj.duckdns.org> Cc: linux-kernel@vger.kernel.org, Christoph Lameter , linux-block@vger.kernel.org, Guilherme Piccoli From: Douglas Miller Date: Fri, 27 Jan 2017 18:18:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170128001349.GB2476@mtj.duckdns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17012800-0040-0000-0000-0000027AAF46 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006509; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000201; SDB=6.00813669; UDB=6.00396957; IPR=6.00591084; BA=6.00005093; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014080; XFM=3.00000011; UTC=2017-01-28 00:18:33 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17012800-0041-0000-0000-0000066DB1FE Message-Id: <5fe40284-dd72-7952-47a6-b5ebc375f8a1@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-27_17:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701280002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I will re-test and post the patch using "bool" when finished. On 01/27/2017 06:13 PM, Tejun Heo wrote: > On Fri, Jan 27, 2017 at 05:32:15PM -0600, Douglas Miller wrote: >> Removed extraneous parentheses. Did not switch to "bool" as that would necessitate >> more testing and raises the question whether other platforms might have a different >> definition for "bool" that would not fix this problem. > Please switch to bool. > > Thanks. >