From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5152944D024 for ; Tue, 20 Jan 2026 14:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919991; cv=none; b=nI3aQSXy1f53O8jvo/MHqN9KwpFxByi2EigBiGgXq1rjgnSBwLyr4NwkCROU2R0Fk/wJj9H6ioCqt8emdXJvCSnexOVD54ccbFIQE2O1todu1s/1ajHzti56zAO/PZqzeX8y/JCKOTlTGxPnG9vT6YUsT+CWnKpj4tn5rncbRHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919991; c=relaxed/simple; bh=aHpg6nyTgxgCsK8qde5p2NcP/Qo4o1W6B7uQhcxzfKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=quuWElfQADzlcUXqJm8tpSYlekV6KGkJSO31pEGgK/m6z8KDUY/vhlBG64hj9aM2ZUBuJ6+CU3qpM4xP6erlUN5zq0n0GCHKn4EEJUZxxgj2QlCeq5/+yaf3QC9zDFsMCZUvLKGh18Z7SVrJ5ML7I3FKdw3lTzOGwtGt+pMa714= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dB3Pqwic; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ds+KugBU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dB3Pqwic"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ds+KugBU" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60KDgYoR781988 for ; Tue, 20 Jan 2026 14:39:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /+Ca6EiM2/QcRj/LhjCE8l/Go1/X4qNhdJDPChMt9p0=; b=dB3PqwicSInFkz0q ebBidClCZxU+TeyKKzzVQc+uxWBr8b1PV3j3y1ubiWK8xrMG4R4yKpslWiwXNN4/ 5SzE1NpicojbuQh2WargZOKWSCDDrWEtPNfoLpjnT3vMsQC1vWx9Hb/9n9TvFglZ jilvPQViBmW45Yvo0Ro5eRtD26w8EuWSujQr7zc4F8mOno1ZDRl1xsOcnULjAU8C 7MYyiPvrEKUc4FSSRw9SGqwlea0QVIFCQ5rr479xxLT0BUd90G0HR31bGUKITQq+ eId9+iq566UODM0F+es5sKZZt3tDyEvzpFLvJSPiid6R7pCtepwIUbDIVHFl+EHh CXNk2Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4btatyr5nu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 14:39:49 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c5265d479dso190073985a.2 for ; Tue, 20 Jan 2026 06:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768919988; x=1769524788; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/+Ca6EiM2/QcRj/LhjCE8l/Go1/X4qNhdJDPChMt9p0=; b=ds+KugBUcOKV7bZpt62JglcNye2tYo/Rq8XAmgJAN3IZXDDPXkA83JQPUAXWuDPTHZ bOTHsUGehCogJKeogUncWKyg5Pjk7IxGxld2QKXyQDtJtKoFGCBAykxa77tHINDCb9TG PMVt2I7PkEvhT3H8CvAm07ofFR/3ZL0KE6qyG/5o2eJxOjwJ1lPfn/CRmtbKSJgrmqUc POuhv7d0gy/3i2cKovflywCqNv2nt+70WhBVniCkOrxN0XtULI3TKHGXJzvEwj8kkXGw AAY8aDiXJA9bLcSaGTKkMikFncDphrNEZFD94Sq/kmKGKfWlWjXHJy01GarFK9/tC0gw PzHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768919988; x=1769524788; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/+Ca6EiM2/QcRj/LhjCE8l/Go1/X4qNhdJDPChMt9p0=; b=R9GlJxuaA5r6NdmbiHVfHljlsjRs7UazIjQa2uO6U0PkbhMAgWCjZziminqrAdgmnD xtizJtIr9Ajk3LVMoo+XUZ4swHaD8B84oLbF92a5ZQpCvYFEV4oSSm9sgh0fSxal+trY ekW207t7iXruT4iFYrOH09lBZqJT6+1TyQq9e7+e5R/hm1klQZsfyD6DOK7hWoim1h10 ookgxsLzQO3u7xgklLvPnMmhmSu/Q4oH07vagNFgPaDKq5HSXl319/cxf/JN5JI6WNcP Hiy5H5VmVbHOPgyFVjJbcHBZ+VCL4VeSJV30PNi/uwCP5rapXPezfOjxTy1xMllubFPr LFhA== X-Forwarded-Encrypted: i=1; AJvYcCWOubn7yAvCXoYomzZnc8RFaq1/eqGW0bS5GRCt6DEneF66dKogn9VfoJZsDWWmbmEixcTwGYk4gHh1kiA=@vger.kernel.org X-Gm-Message-State: AOJu0YyBHYWlXM9aTbAthCzGM7BrmFWHW9QvXFkLUtxVNj75QRWg1hHp RxjF2Z7MQ1+DmwrQpUpN512ACAloQ5QFGBmU4Xglevt2rNxg+bbPvbXUJe1/ku8FSm7gSlKsdSb 1O2zdqU1klaE8B4gulNCZDl1uULWY75gQqopyjYzwgoIn05W0FcpeaC2SfQ+DgGkU7wg= X-Gm-Gg: AY/fxX73U0wp6hlYEMxTVzYP1SkNG2YBBHSHh/G2GY2vonYjJ/Pc/LFuYnFoS7LqZ5O aFLv40U8fVReIAwGlSdEw1J+MeveH91PokXRUlveHUb8YxZvmZ9gsAToPpX/jYC3XRJ1Yi1jFIF MdIBBqLfRTJhCv1P37QHUQqT3RQiLVU9NDCwJbxl5yw9yehN+//YxeOwFvj2s2vFMUtKio+SmeL 07M5VVb+aKfuw2jQVRgFtnf8SsibIUCthyRtOjunuIAgvLAbwU8uWeNi0PrDN9OiPoZSvVyPpdv JmMT5vkoiX89UD81RQ6AkEtG8z83x0e008yTNxJNNKVWyIOJWt30Vmp8KwXzjdt3hBbWfBDHL3f bvgwBFLAfe2O4WmSRPa6xMp+vNpa2XchzEydjo5lc5nIlLvi+wuXaFMRIxa8GMrhdCRo= X-Received: by 2002:a05:620a:4687:b0:8b2:df32:b900 with SMTP id af79cd13be357-8c6a671b492mr1521243685a.4.1768919988289; Tue, 20 Jan 2026 06:39:48 -0800 (PST) X-Received: by 2002:a05:620a:4687:b0:8b2:df32:b900 with SMTP id af79cd13be357-8c6a671b492mr1521240185a.4.1768919987684; Tue, 20 Jan 2026 06:39:47 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b87959fb973sm1387385166b.53.2026.01.20.06.39.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 06:39:46 -0800 (PST) Message-ID: <5fe80f4a-ef5c-4008-88e2-60ad1f8c2a18@oss.qualcomm.com> Date: Tue, 20 Jan 2026 15:39:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Koskovich , Jeff Johnson Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260116-milos-fp6-bt-wifi-v1-0-27b4fbb77e9c@fairphone.com> <20260116-milos-fp6-bt-wifi-v1-3-27b4fbb77e9c@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260116-milos-fp6-bt-wifi-v1-3-27b4fbb77e9c@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDEyMSBTYWx0ZWRfX5NmkoxJEfrMK Tlg1gr61qoiaQEN8WjjKfG9UkiqP54OX1wxnDNIBlnYd49TVc/XpYDfeaCdobzLw9ukfPkbRPLw +X38CzEgC6RqPxPr/W6oDAArNZ7zdlA34prDrEG+ZgTE9lDTHud0VuIySBp+DRwZ9PaejmOlg9F o83NwlWWg+rrReCAjVqYxqGSqiuKsNLcEgo7lFMEzYgLt7njWx5MeHsKltXqeuNYBV8a+Nfs17X 2zAd2sE3AKTj5HO3tatVEsgG5nKMD4t+/qOabTDEJjRgOzso46RBiwO/q/lCJDCg/AYqCZaQS0t gA0RC1RilidW20jEycOak546nszRmeyK9VpaADNFYC7h/3gP5TdyS53T0vw3pTEKcOOCpGN2PUu 50v4hPJIqovydN+k9+pt/Z+HAtUC54v5ghLcHaf6SHy9SiMjsEowoZ+fM+xntllxEuCRIbok/3e UeGbP+UCrR0WJWd5C3Q== X-Authority-Analysis: v=2.4 cv=IYeKmGqa c=1 sm=1 tr=0 ts=696f93b5 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=6H0WHjuAAAAA:8 a=COk6AnOGAAAA:8 a=XxyedzFJey02p2Jel3IA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=Soq9LBFxuPC4vsCAQt-j:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: cu4dw501Iir5HjDni9b1q16IUZB115TQ X-Proofpoint-ORIG-GUID: cu4dw501Iir5HjDni9b1q16IUZB115TQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-20_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200121 On 1/16/26 3:50 PM, Luca Weiss wrote: > Add a node for the WCN6750 WiFi found with the Milos SoC. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/milos.dtsi | 46 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi > index 024e1c9992fe..80feb3e9d3e2 100644 > --- a/arch/arm64/boot/dts/qcom/milos.dtsi > +++ b/arch/arm64/boot/dts/qcom/milos.dtsi > @@ -2043,6 +2043,52 @@ gic_its: msi-controller@17140000 { > }; > }; > > + wifi: wifi@17110040 { > + compatible = "qcom,wcn6750-wifi"; > + reg = <0x0 0x17110040 0x0 0x0>; This reg doesn't.. sound.. very.. good.. The size being 0 is of course wrong, but perhaps more interestingly the base address is a register within the GIC.. > + iommus = <&apps_smmu 0x1400 0x1>; And this is a PCIe stream But I see kodiak has the exact same setup.. After digging a little into the driver, that 'reg' is apparently indeed consumed, as a base for PCI MSIs.. I feel like there should be some better way to express this.. non-everyday setup There's this commit message: commit 00fd24089b8154ddf5b3e724e2c4c9974b9ba91e Author: Manikanta Pubbisetty Date: Fri Apr 29 22:34:54 2022 +0530 dt: bindings: net: add bindings of WCN6750 for ath11k WCN6750 is the WLAN chip on Qualcomm Snapdragon SoC SC7280; Though being a PCIe based solution, it is not attached to the APSS processor (Application Processor SubSystem), it is instead attached to another tiny processor called WPSS Q6 processor (Wireless Processor SubSystem) on the SC7280 MSM, where the WLAN firmware runs, and it is the WLAN firmware running on the Q6 processor which enumerates WCN6750, as a result APPS processor would never know such a device being present in the system and would not detect the WCN6750 hardware unless and otherwise WCN6750 is registered as a platform device. This is the reason behind adding WCN6750 WLAN node in the device tree. Add WCN6750 wireless driver support, its based on ath11k driver. Sorry to hijack this patch, but I am not comfortable with this binding as-is.. Adding +Jeff in case he has any thoughts Konrad