From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 158E8246798 for ; Thu, 4 Dec 2025 02:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764814884; cv=none; b=sQ+HecKBGBK56r51yX5v73pzBS9dKfcdbaZbt7GKgCVw2slIxxfPTO8KB/zoTfDMiAEW0P3yGiw0/V7GhiJ/w0KQNHS9JsTJF99l3hnXVzdQ5qjcrnp2pK4GAO4cunzOZHjqIq3CJVk83EK7nOllI0JluCQ8t1fm64IgwcMoGcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764814884; c=relaxed/simple; bh=56HF3voykFa5HepGUA1JjmIGOi3GxhNIlIrojhTiado=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=rwZ1ASjq/DSsp1ULV4K0/T0lN4013Rle9tmHdf89PFO7dCR7krh1eDAvIVta1w7KKEriAqOVl6cXcZFLaWJc2RLwSICCQX6vq5SnMKjoD7W2devXKgQVkdQQWOX2gx9JYxfOtO73It/4lgPAkcD0c2pGZQKTb05OG6JKsY3hy+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p3/vsPGs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P8BOi/mB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p3/vsPGs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P8BOi/mB" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3G7Ctl1970147 for ; Thu, 4 Dec 2025 02:21:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= va0B/24zt2VTpkxr7ujhdnIO5+76ENbSqxQVq/6jEAA=; b=p3/vsPGsdz7IbScG 4kpULUSc+AlfrHo4HZJZzLZhOTgHo8a6YoOKGNERlOQzZ2bmcIEFk+TDXYYeOf+3 Tf5VfFRDsHO5dZDU1L7lJPhBTKSwLvtfSNt/kYubDi3JIVBAUDz3g/acihXYSZGV LB8lyH/lk1EfZKsRlkgrpyBk1XxECC+WbIPkIACk9FvM3SwvnlKkuHhafL4GWOqH wdm2DfM138AxK2+mzxia5f8CmRoTpghIXCUGx1DCfNG/B3p3RL2sft5BKjNG/d6T xGOYnVBbke7409GMV/TlRMRL/K8XgQ7Gl45gv1LGto+FTog6MfodHmJ4A/qkSoFN Yr/wAg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atjjs2ryn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 02:21:21 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-343806688cbso727504a91.3 for ; Wed, 03 Dec 2025 18:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764814881; x=1765419681; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=va0B/24zt2VTpkxr7ujhdnIO5+76ENbSqxQVq/6jEAA=; b=P8BOi/mB7BTNeT1mIZ5YHLMPpgEeT/uL8vprrQVOFm6y0V82oANkre8N6v69z+H79E HcYQPsQGxNBgR51KSxFJzXM57DxVGR/vLj48nv4cglMh/IYr2GEhxVTx0AAh70YVuBwR g9BN6CbkyTQT0yW3KvSRH2ZvnjJghIiXOF94Zm8UMrlgXwvKUe8MFUcdhmeC6n4lSDfv DrscCebHKttdkY2gMMpIac5fZg2PO4qa9B6qkVDXGVRg4Ml4A0EBXcCjvaBsnVZ+kjgt 5CCKDRl+YJ48rM5ksrBUfVqA+VHn/6KbEKTr5INSwF7pFntjD6wYl2JliQsuR263K8z+ 94Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764814881; x=1765419681; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=va0B/24zt2VTpkxr7ujhdnIO5+76ENbSqxQVq/6jEAA=; b=hB69g3RIySHzrb4CiDruF21e9KxiGQEzGt3PKCz6kZeZka0r0c587eFxjTg2mhS9ye qZ8XE6EZ+KmQylcNErLmhb48YqMPsV/BZfIaHLwfWuXYtyhPjTXuzVyPRYJToqgm7uQf JC6FaXD/0E/JAIfyeQmd2SZa8+m/tqnkfAunLCgFllhFPrg4uqJV96t+EQczNusXnOJq 27T8JQcqYdDWIyfLcI60UgFp3Vu2QHBSJmmNTrPX2OqpIBnTrHqDYLZgCwhw+4ea35Cc 11gpxJ+XVL5tUhlUQXWAQQifB9+XoxsobTpk5d+aNg2ZDhTzFY7I4GAlQ5ce+vAPIk2l CwYA== X-Forwarded-Encrypted: i=1; AJvYcCV4ZNtwE6sciubTVLZ1VLrr2IdhF2xja0r0Nn7gZG1rEffg6uMZL/mOMHZmO5HLc/6f5pIx/4JjmPyHh2g=@vger.kernel.org X-Gm-Message-State: AOJu0YyNxwbde389xrxMSE8lUZAMuDq3ttT5qj82hXELJsQ+cOeNn7i/ 6fo7PGclJIKa5JUo8Bal+i/5h4N9s2Jo1hxYQNzaUMgbd3QBtPq2GUk5rDIe6qJ3NrtNeSmLmCN MxxvwcZ9chVSH1P2EulzeJHsz02RkrRIl5b/NPWTvXO97jZCvmbPB3kawSEWJLZuHdlk= X-Gm-Gg: ASbGncss5LtgmqOg3B9pUXkjtbomCyKGWsKRScoMrYjMqEFzR8EI68RkLnJCqLejfcP WQTi1ILPbL1vluJmAlZa4Bf0yh+XiU2kg0StT/84YUIVL1ly7zzSLVr3ZA+5m9YcMkciQBtRj6z MEYA14LC6g1Xg0lwINcrsEH3YeyttjOeAd2jm0vLxK/OXvKyEMWCA/BHgB06cXhoj2j/m+Ic4TF 0QyxYgxUyGugEVOHXctQBlqEBIL9KWasogDSaCB/+IpqgySZ5AD4rBshVHbgahwEN94rkOs1eUN L76ApC4CU73bH19s0Xr7eNTwhnIjlWWStkH8QMrjoUoSz5vqB+ea5Za8AMv2/h1zhRj9Z3pyEan vYzIcIQe7vWKEDKvAP7NycO9u8zV3JTRltVVvuAAEKbesMbq24ysnnejS0ec/V4jmlW+vdV7dX+ yNttU= X-Received: by 2002:a17:90b:4987:b0:343:e461:9022 with SMTP id 98e67ed59e1d1-349126d0d62mr5163169a91.24.1764814880662; Wed, 03 Dec 2025 18:21:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMNoZmTK0wGfsVGyP6QuNy19edOtKoDNuRGBIfu41xy2mxnqUIXA/acAvITRIR1wsDzetNrA== X-Received: by 2002:a17:90b:4987:b0:343:e461:9022 with SMTP id 98e67ed59e1d1-349126d0d62mr5163132a91.24.1764814880221; Wed, 03 Dec 2025 18:21:20 -0800 (PST) Received: from [10.249.18.58] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3494f596810sm141723a91.10.2025.12.03.18.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 18:21:19 -0800 (PST) Message-ID: <5feaebe7-c5da-4f95-931c-edf3f51db584@oss.qualcomm.com> Date: Thu, 4 Dec 2025 10:21:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] media: qcom: iris: Add intra refresh support for gen1 encoder To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab References: <20251127-batch2_iris_encoder_enhancements-v1-0-5ea78e2de2ae@oss.qualcomm.com> <20251127-batch2_iris_encoder_enhancements-v1-1-5ea78e2de2ae@oss.qualcomm.com> <747f661f-1be3-59d3-0cec-71bb6a6e2fa6@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: <747f661f-1be3-59d3-0cec-71bb6a6e2fa6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: OhRtxSS8JCKvLnE2TywI7dEEcq1Fowfw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDAxNyBTYWx0ZWRfX86dVboGtXO54 lgbvVStPNg19+fuBMpscvxVBlai0lsdBvnfBFMiHHOzTdlxSNRWDWIg33sUxR9k79xV1/p3YpqX Q7pG018M5SEisfym1WkpJ41XY0dFvwJiM+kKivOKFi0LbXahroyLT9pW3whcZtCTw37WBvvIL4d BSGKtKcOY7h1wCgZxxD5cFMjs0akXcWu2fKNDIApBDPqd0DpvFk9P97ZtUgAffuWdWb4qnmfeYF RW7H8W2rF3S39Yoy6OoQwvLZb+5a2bqva3AIYEF9/gsqiGYPbntsWwVQEPNPZTYNSMsdAyudHwF OBS+n9SXc4LVcDdiIXO4xHicu4tP3LcUmDuZXnPsoHdtFfXawTrXWyuIcdDkAI9MBzK0UwUCXBc hXxWutbcKrrM8cD2+xIykzp9XGJKfw== X-Proofpoint-GUID: OhRtxSS8JCKvLnE2TywI7dEEcq1Fowfw X-Authority-Analysis: v=2.4 cv=ZqDg6t7G c=1 sm=1 tr=0 ts=6930f021 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RKEO2VjmjER0VAT8CKIA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_01,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040017 On 2025/12/3 12:28, Dikshita Agarwal wrote: >> + >> +#define HFI_INTRA_REFRESH_NONE 0x1 >> +#define HFI_INTRA_REFRESH_CYCLIC 0x2 >> +#define HFI_INTRA_REFRESH_ADAPTIVE 0x3 >> +#define HFI_INTRA_REFRESH_CYCLIC_ADAPTIVE 0x4 > > HFI_INTRA_REFRESH_ADAPTIVE and HFI_INTRA_REFRESH_CYCLIC_ADAPTIVE are not > being used, do we need these macros here? > I referred to the Venus driver, which also defines it but does not use it. >> + { >> + .cap_id = IR_PERIOD, >> + .min = 0, >> + .max = INT_MAX, > > is this value correct? please recheck. > This value is incorrect; I will fix it in v2. -- Best Regards, Wangao