From: <Tharunkumar.Pasumarthi@microchip.com>
To: <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH RFC SPI for-next 1/2] spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX PCIe switch
Date: Fri, 30 Sep 2022 05:51:51 +0000 [thread overview]
Message-ID: <5febd5014483d49b445a16853a2ead3e973265e0.camel@microchip.com> (raw)
In-Reply-To: <YzQvgmE9Hubx9mxN@sirena.org.uk>
On Wed, 2022-09-28 at 12:26 +0100, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> Please make the above a single C++ style comment block so things look more
> intentional.
Okay.
> This does nothing if the chip select is to be disabled, that's clearly not
> going to work.
Okay. I will handle disable case of chip select.
> The driver should set SPI_CONTROLLER_TX since it needs to transmit data inorer
> to receive
Okay.
> Please write normal conditional statements to improve legibility.
Okay.
> Are you sure the device is fully set up and ready for interrupts at this
> point, and that the freeing of the driver will work fine with devm?
Okay, I will move init_completion and interrupt mask management before
devm_request_irq API.
Thanks,
Tharun Kumar P
next prev parent reply other threads:[~2022-09-30 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 3:43 [PATCH RFC SPI for-next 0/2] spi: microchip: pci1xxxx: Load SPI driver for SPI endpoint of PCI1XXXX switch Tharun Kumar P
2022-09-28 3:43 ` [PATCH RFC SPI for-next 1/2] spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX PCIe switch Tharun Kumar P
2022-09-28 11:26 ` Mark Brown
2022-09-30 5:51 ` Tharunkumar.Pasumarthi [this message]
2022-09-28 3:43 ` [PATCH RFC SPI for-next 2/2] spi: microchip: pci1xxxx: Add suspend and resume support for PCI1XXXX SPI driver Tharun Kumar P
2022-09-28 11:30 ` Mark Brown
2022-09-30 5:56 ` Tharunkumar.Pasumarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5febd5014483d49b445a16853a2ead3e973265e0.camel@microchip.com \
--to=tharunkumar.pasumarthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®