From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BDFC2D0DA for ; Mon, 30 Dec 2019 06:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BD54207FF for ; Mon, 30 Dec 2019 06:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbfL3G26 (ORCPT ); Mon, 30 Dec 2019 01:28:58 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:44942 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfL3G25 (ORCPT ); Mon, 30 Dec 2019 01:28:57 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=shile.zhang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0TmFK7y0_1577687333; Received: from ali-6c96cfdd1403.local(mailfrom:shile.zhang@linux.alibaba.com fp:SMTPD_---0TmFK7y0_1577687333) by smtp.aliyun-inc.com(127.0.0.1); Mon, 30 Dec 2019 14:28:53 +0800 Subject: Re: [PATCH] libbpf: Use $(SRCARCH) for include path To: Andrii Nakryiko Cc: Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , bpf , open list References: <20191227024156.150419-1-shile.zhang@linux.alibaba.com> From: Shile Zhang Message-ID: <5fed3c68-b43f-3b27-bf69-322d26d0dd13@linux.alibaba.com> Date: Mon, 30 Dec 2019 14:29:29 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/12/30 13:21, Andrii Nakryiko wrote: > On Thu, Dec 26, 2019 at 6:42 PM Shile Zhang > wrote: >> To include right x86 centric include path for ARCH=x86_64. >> >> Signed-off-by: Shile Zhang >> --- >> tools/lib/bpf/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile >> index defae23a0169..197d96886303 100644 >> --- a/tools/lib/bpf/Makefile >> +++ b/tools/lib/bpf/Makefile >> @@ -59,7 +59,7 @@ FEATURE_USER = .libbpf >> FEATURE_TESTS = libelf libelf-mmap bpf reallocarray >> FEATURE_DISPLAY = libelf bpf >> >> -INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi >> +INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(SRCARCH)/include/uapi -I$(srctree)/tools/include/uapi > Is this breaking anything at all right now? I just tried removing > arch-specific include and everything still compiled successfully. So > maybe instead let's just drop arch-specific include path? > No compile error/warning, but just include wrong (non-existed) include path. I think it's OK to drop it if that path is needless. Thanks! >> FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES) >> >> check_feat := 1 >> -- >> 2.24.0.rc2 >>