From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3144F3EFFB2 for ; Wed, 27 May 2026 15:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779895604; cv=none; b=BpWlBxfL8Nmx4zpR67WOXp673F0KQ9mBLBWBGmMvexZStnKQVHfzid4YcMGemZ5aUuo+iUP9ZBDvu9Gv9lJfIRGfUEm4hcJy9ZyyXGJCM1nMAloFLLQ2ueXtYqGggnit85MeRRS+R3z1A0+5ISVN6CvDOLJiOTysxNfRU5y3m0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779895604; c=relaxed/simple; bh=CcTUPZ6t+mVwYOKt4FJuqUXX/0MqLRI/5XzUOTPLIoE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ij7gLN09ccu7uq1fDBUp6GXZLaIr22nxtkXz22ILZx4VN4dngMqgIaBkzkgsa8InJLUH+DCSPBwE8b2hRgarw9Cw4r3BK9nK2dRoShfAjnMOf0LWYwWpqBHfF/YehK7aUD6ps9PI528avHOkEyVHb090lIvNoOJQIq9d6OBcKSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Moo+u+Ap; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Moo+u+Ap" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-43b6f782cfaso2437428fac.3 for ; Wed, 27 May 2026 08:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1779895602; x=1780500402; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oxx39jkUnqnkX8z8ETOUwIEf1nlUkPLtNKUYJCQs90s=; b=Moo+u+ApJGEZ0jBLxTC5HivqXRLiolSx+4IlPnVs3wvLQrd7Ruh95pCQV5z0TnGkpr YwKufkOv3O08OUDxzRVAZKg8EwWyscgVZvY+YHsiX2SY9tOpx97M80l0E1+CSAbXbY0r fpZCkPR4vSkkOoO/8A5RSq9jYKNLd4fFbi2K4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779895602; x=1780500402; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oxx39jkUnqnkX8z8ETOUwIEf1nlUkPLtNKUYJCQs90s=; b=gPFDHSQljxHQaTM7tzskGCf6HYLkXLTJ0HjoAAq5hbYWGbf1XHEYJ2DkWi5lo/tCgg S9HOpGfHPZ3XaZeMCYmbplGGthhBtsLmRbyVDN94VRahurKiN8lh4bqonsYUYkM5NPBG HfwWeSqwxyYziuU1w95nCUtJg9K7eh/Qu6oFtBZnyDtmKpy6NjlfsOzIgCJ0hwC2ndbf fwW05rScRNHDzjzxeUb0lG7njdeAlR+IVWF9Ht3lIMYGURCMEF/SYlrTLBLFy5AuS3st KUSiSDNXTqBtn+jnxL6P6j74fMOViWBpki6nsO0hNQNJz4OZ01eGuAbEf3RSKxcqdYPc 2bfw== X-Forwarded-Encrypted: i=1; AFNElJ8BQeb4xJ23kNSy2zhGNYyQl/Zb5SgTHj2/+Fzrwi7OKqDnK9Vdb1aAbmk7Wk38ydPECQMG/A4QG4TAL5w=@vger.kernel.org X-Gm-Message-State: AOJu0YyrDBfqLhz6+MVKci1MLvxnYql7RDJyV05DLFlL1X/KtEWOqc+q XikKq7oMhL5pqVPjtCh3cUgj3vcoRvxcItUI59hkQLGS1R76iRpYD1TDfvErWSbkrkY= X-Gm-Gg: Acq92OEmMfwbLkMbOj+I1GBCvKg2UPvGphjpUgTH86yl1juDa9KpgNZpoIKPIMcu0ut wp7OXIOJ183daBQoImbfsh7IMVAthtMqw//J3eoU+OpQOLQF4nhgcroZ4PEqUR558OfvVS+EBo7 ob2K79ocsrNP6W4oI6VILB4oAQSPiEe+V3eKM99633SY0XEW08SZd6zsKqH2/vcDQNTl0ndrDMz Cb/1gUhUP/eqsT8dQ4vY9mL4+FosTQxGXH8DzyYCVW7SSonTPrXbZEzs+M7iAbcAoTDZjrEXG4p ZuWuAZ0h39lrAz7XOZ4MYntTZGbiLCnUzPymcJs1CuTWupAMn8M9w0L6eZOVWD5BpA8/6wYHigB sXAXr/+6DaAUyDdeSpSZoqycLFxJN9zhx+gc8VLbRjcrUFbo7jvPWZ/M5Oa0w2+jHc72qeV84id GGLXkyBb0A/71Jvfe318VZgiVcVOnHqR30v0tr2u/+cA== X-Received: by 2002:a05:6871:3149:b0:417:c2d1:fc37 with SMTP id 586e51a60fabf-43b5aebe229mr14272899fac.30.1779895602088; Wed, 27 May 2026 08:26:42 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b635e4f8bsm16791019fac.7.2026.05.27.08.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 08:26:41 -0700 (PDT) Message-ID: <5ff19049-a83a-4ef9-9cae-b97438fb3e77@linuxfoundation.org> Date: Wed, 27 May 2026 09:26:39 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] cpupower: Implement powercap enabled setters To: =?UTF-8?Q?Mateusz_Ja=C5=9Bkiewicz?= , Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260527081233.4060762-1-jaskiewiczteo@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260527081233.4060762-1-jaskiewiczteo@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/27/26 02:12, Mateusz Jaśkiewicz wrote: > powercap_set_enabled() and powercap_zone_set_enabled() are part of the > public libcpupower API, but both currently return success without > updating sysfs. > > Write the requested value to the matching enabled attribute so callers > can actually enable or disable the powercap control type or zone, and > report write failures back to the caller. > > Signed-off-by: Mateusz Jaśkiewicz > --- > Changes in v3: > - Move the patch changelog below the Signed-off-by trailer so the > sign-off is kept when the patch is applied. > > Changes in v2: > - Check current enabled value before writing. > - Use fd < 0 style for open() failures. > - Print sysfs open/write failures with perror(). > - Drop the sizeof(path) typecast. > > tools/power/cpupower/lib/powercap.c | 58 +++++++++++++++++++++++------ > 1 file changed, 47 insertions(+), 11 deletions(-) > Something to fix here: lib/powercap.c: In function ‘powercap_zone_set_enabled’: lib/powercap.c:217:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare] 217 | if (ret < 0 || ret >= sizeof(path)) | ^~ thanks, -- Shuah