From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>, netdev@vger.kernel.org
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Schmidt <mschmidt@redhat.com>,
Petr Oros <poros@redhat.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: dpll: Add clock ID property
Date: Fri, 18 Jul 2025 08:55:27 +0200 [thread overview]
Message-ID: <5ff2bb3e-789e-4543-a951-e7f2c0cde80d@kernel.org> (raw)
In-Reply-To: <20250717171100.2245998-2-ivecera@redhat.com>
On 17/07/2025 19:10, Ivan Vecera wrote:
> Add property to specify the ID of the clock that the DPLL device
> drives. The ID value represents Unique Clock Identified (EUI-64)
> defined by IEEE 1588 standard.
With the exception of clock-output-names and gpio-hogs, we do not define
how the output looks like in the provider bindings.
I also don't understand how this maps to channels and what "device
drives a clock" means. Plus how this is not deducible from the compatible...
So many questions.
And your driver code confirms that this looks like misrepresenting
consumer properties.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-18 6:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 17:10 [PATCH net-next 0/2] dpll: zl3073x: Read clock ID from device property Ivan Vecera
2025-07-17 17:10 ` [PATCH net-next 1/2] dt-bindings: dpll: Add clock ID property Ivan Vecera
2025-07-18 6:55 ` Krzysztof Kozlowski [this message]
2025-07-18 12:16 ` Ivan Vecera
2025-07-21 9:23 ` Krzysztof Kozlowski
2025-07-21 12:54 ` Ivan Vecera
2025-07-23 6:25 ` Krzysztof Kozlowski
2025-07-23 7:23 ` Ivan Vecera
2025-08-03 11:12 ` Krzysztof Kozlowski
2025-08-04 18:26 ` Ivan Vecera
2025-08-04 18:45 ` Andrew Lunn
2025-08-05 15:26 ` Ivan Vecera
2025-08-05 15:31 ` Andrew Lunn
2025-07-17 17:11 ` [PATCH net-next 2/2] dpll: zl3073x: Initialize clock ID from device property Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff2bb3e-789e-4543-a951-e7f2c0cde80d@kernel.org \
--to=krzk@kernel.org \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
--cc=robh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®