From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA463E63A1 for ; Tue, 24 Mar 2026 10:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349906; cv=none; b=tonugdnOfdGU8Chw64zsP1eeNgcRdM/bbhIaZBuef0wA7INg6MgbBxmoUw0O3KwiVYjDmIDRtsjFz5SkwPeBwBPJdQNF47lcrl2qcc95+a8hGSBuzSaOVT7bTQuzcz2U7a68tzc1mxwFUID93wtQ795Mpd/UJLy7OQ/z7h6jttQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349906; c=relaxed/simple; bh=RvBBHM/r8JqLlusKXxze+0dkWwneeCrBFwruBfiQ4Ck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gZhwBGXkOENhFKmuKcU9qSfVgG9/kaml+HD6ixuLvOBuzaFX5uDA7W/vPNT8KHbh3SEJG0eT2cvzgrqDHLm5ex+5EAfLNTnx5O7I93zz/h9ihCt3vOVU1R91FIDQTJ0oXncNKNecpYS+RDTs0kuMywBCRQErfTgqrmxJ+75FugI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LZ70nu+V; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RpS/O6Dt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LZ70nu+V"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RpS/O6Dt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774349904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7fxYhNz9mypo+6RSdtGXJrr8xN/V7RBlg3/DS40iuY=; b=LZ70nu+V1zp6HUromioL+x7WvdC6uAkmlO6o6d9oM0eNPS70qIk8NHNAJ4ULCRGcIYHnlf cqKzix44njuog4mYSpCno+iqUjxAeJhLSk6EkfvuGYyyB8vmA71iPT+b9Spy+19fwV1hjy Xr6I17CTnjB9quse9cyOgu3EBl5a+mA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-zXIWkByTMC2cWuiv0dsRfw-1; Tue, 24 Mar 2026 06:58:21 -0400 X-MC-Unique: zXIWkByTMC2cWuiv0dsRfw-1 X-Mimecast-MFC-AGG-ID: zXIWkByTMC2cWuiv0dsRfw_1774349900 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-487018c8244so20115625e9.3 for ; Tue, 24 Mar 2026 03:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774349900; x=1774954700; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z7fxYhNz9mypo+6RSdtGXJrr8xN/V7RBlg3/DS40iuY=; b=RpS/O6DtKd3NJ3yjJK5Q1e3JfvUuspcqYRSEhws1bY7KD23jnSV/bUzYKuvVfIogU5 eXQdL+nn/EOITP6IMdHpTnx7eBZrf33lbAnZm0NO4hvkBTH+FBh+i2ROKlPj500SqTqy WIzbWiypUhjNEoV/rjGU7DHrqXrgkHAm7tULRuMznsvUYuKXfD77rBcS4qxTkIG0EAXT SRDSbr9tdKlP026AH9NkY69EpzNiRoNBPjLF4133TiF1bC0Ps+2HK5lKqNS/Ji3BDiWX 19EsqnfK+/p5j65R0/zj2e0y4XP0uiQe+X3wEkOu6Q91gJusL0+V15nm2vjpHmQi78ZS eSQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774349900; x=1774954700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z7fxYhNz9mypo+6RSdtGXJrr8xN/V7RBlg3/DS40iuY=; b=gNK9f9VgFGeWhYzKE3HwJLZ/O2vNiHPIY6+2C4ZNyle1dZE6FkbnyobWbG862Jf+WB ZolR4ko79Ny6R7wAJVt+wjYm+ziZMJHXYZu27t3vt8h/ZdsC0nX5TClKz0BkpZyV0O/s s/tolUrtW910LDbTiZzSIl3Irw4pE5tiZNKtiCEcfyPGTIXRc6NvrmrQiq0ZBdXKUOSl qQtJYV69vIpKEEz8REszDNuOnvwITc/gpKJI0IstAfFCYc11RNQwzgnPIc9MTzPJ/1qm ydUTcCu9DWYY+fj6kcXFpylJhNoMNY0y9oTtus6F8OeTXqMpU2Ovyong1ocRCnklcvVs /spQ== X-Forwarded-Encrypted: i=1; AJvYcCW4pCZRetINZizDsu7Kz93I5rsq7GVsqF19THCw33O7d8ZtAzwQ0fRRvQp20XZqtsBBIvMGEuHCsAWPyLw=@vger.kernel.org X-Gm-Message-State: AOJu0YxuOjxitwsSAwKyaVo8vxGnUUT/cXML/OhWMvVbofcG7PbnpSsC gRE6jqhlHpP50T+juCuL7VKffTVn/kZ+RockDx+iz+1ypv2xkdPiu5rY/INH4MdPs5Tx9S20iJM tGrCndy/n3rjkMGiGaukvjbacmRFVXPj9ZoCC5iWOrLSoqaxhq6egTdvijPrX6QoRtg== X-Gm-Gg: ATEYQzzLS5evvW6+6YUr65v7/Jml4abxerou6OY2oZV8CosqPX2NIM/ekEAz5QkSix7 gYYKf0Rc+wKMeMVLAN+/EHACYtASjXL7coz2GG8yFr//qxsMlgnmP7IdFQ/3ngA46iPLraIlPP9 UJuTPFf4Wy/gcBp7ly/iBrA/HZZgnO5eXqD3FSNGZSseZvBjXfaIjMuQKAYZQBog0WKHfz5gtrw 55qMTR7ApTdung6ql/JJfZMnaWPELX8jIvSSlzND7es7vLHdu9I0rBHU05Ypminy3dz1bwkLPMQ 9EbfLeAGKhdaoCDHyryEdiuwFXhs74fgwy1iyK5SlrWoCxisHgYxZrB51pAdqlERuMhZG308qvv leGR9nF6pMOcfBVSxxba/jWfsQ01ap5LS0oFtMcsDJeGlP1FZHPOTEah1 X-Received: by 2002:a05:600c:45c5:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-486febb5f45mr213729485e9.6.1774349899760; Tue, 24 Mar 2026 03:58:19 -0700 (PDT) X-Received: by 2002:a05:600c:45c5:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-486febb5f45mr213729085e9.6.1774349899327; Tue, 24 Mar 2026 03:58:19 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487116d82e4sm78734655e9.12.2026.03.24.03.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:58:18 -0700 (PDT) Message-ID: <5ff51617-deb6-48b0-b9e2-2d7066fa2562@redhat.com> Date: Tue, 24 Mar 2026 11:58:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware To: Birger Koblitz , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260320-rtl8157_next-v3-0-1aefeca7fda7@birger-koblitz.de> <20260320-rtl8157_next-v3-2-1aefeca7fda7@birger-koblitz.de> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260320-rtl8157_next-v3-2-1aefeca7fda7@birger-koblitz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 12:14 PM, Birger Koblitz wrote: > @@ -2022,14 +2277,14 @@ static void intr_callback(struct urb *urb) > } > } > > -static inline void *rx_agg_align(void *data) > +static inline void *rx_agg_align(struct r8152 *tp, void *data) > { > - return (void *)ALIGN((uintptr_t)data, RX_ALIGN); > + return (void *)ALIGN((uintptr_t)data, tp->rx_desc.align); > } > > -static inline void *tx_agg_align(void *data) > +static inline void *tx_agg_align(struct r8152 *tp, void *data) Since you are touching this functions, in the next revision please additionally drop the 'inline' keyword; the compiler should be good enough to get them inlined anyway. /P