From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89B9F38B12B for ; Fri, 3 Apr 2026 09:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206883; cv=none; b=dFFiXojmlrKzzE4cCvpM9D4AaUWJX3MgVNNC6cv4AoW/GcQNhlZ+o4m61CKLIsMM1mZy4MtBVQSJ34Mkhm6736umAXKDbPKH153PIG/CMjF7gfuhjMOtj6frZJu9lyC81kqCo9/+bUzijOFUEp+3TeXwxwfnB3dfPPl38wb1LFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206883; c=relaxed/simple; bh=cmDriKbCcG9Q8hSVXUoL8k7uqHqqwdQ42AQKkfed4rY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C+4Y6iZuij1rx7nNUNHXKv3NzpYssUnjmS5zTUl3Fjz2xVARI7rOh8HclIqFYnx1uWaem74XJHxIniSqdn7HnkfxcCMxpIPpjMo1NVpEhAq66DjwyaiAbiDKuMkrwRVkWNNTY7tLoXeZlkdcWkv9zmq9yWIPRZF4Uy8k8IPH0zQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MJuVqINB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dI7HsFIB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MJuVqINB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dI7HsFIB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6333Gpwv2922050 for ; Fri, 3 Apr 2026 09:01:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oqFxlfuV8pspBAs2CXOzM9DH0w3Wtyj4158jVPNTSw0=; b=MJuVqINBnD/Yyeyf XO0FEH61k35SZ0MZfCZiIaX8buCquv/HA3O8+WCTM+DE750FkWOBICkUnqJzvRPR A/5AWn4IoLgMYxcfVtzqgJ2w53TVf9VeyE5HsY73x9inaUN3dDrtYgk4/55G/1Bb VXZ7reDiil/wTbsfBOKqJIbEmyqABijJOStLGwj4mNLcKeioOa4leWB1O5CzDLjG RQZUzx6EP17sKEraLd4OdMHkQAAS1e1+z/ZQB8g2kmevszH4iNDuD/Uy0YtHqADs +qFjWo2B8ecRU2HyvtyMPI3Cjaiy6gaKvu7sYYL1A74zGu09lNI5oloaHKOzdoEI pekMYw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9qw0bsmg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Apr 2026 09:01:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b0f4e632caso24988035ad.3 for ; Fri, 03 Apr 2026 02:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775206880; x=1775811680; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oqFxlfuV8pspBAs2CXOzM9DH0w3Wtyj4158jVPNTSw0=; b=dI7HsFIB9hiL++yWOhp1m9/pgm9zzxX5zw04ygGM0P/WTfJ27cT370zgdPrAhyYFyG sssT0aHctBP5xMh9OyS/pun3UcBGjqcdQlCsfpbcac7HGCZG2qm2cl4mlR47VUR7ZI2c khqiAhULeTmWx3nAd6QFPCsDhzHehbJOn2xauxmphKMyeCtnm5HPyiE/ml0GKIaTYJzC 6FCnT+j0EYzoVMBIJfGgdvPjpx61H0bew2Pa9kR9qUvXy6vFQdGvc7P4z0GZ6hqQYg9l QMZGuTnjq6ltnzsPc2UAWOOm2WXurqgdzrPrEs3+Npxi9wnMYDhYA1GF8mJ111oKnHIB L2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775206880; x=1775811680; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oqFxlfuV8pspBAs2CXOzM9DH0w3Wtyj4158jVPNTSw0=; b=rjq4OlbxPNhoqdUNpbvRGCN2UU/adJAtB0SXKfsp63J+ilijgV4jyQxvWZTks4UTd1 H20XE0M6w+bOIVaHJZSuZfwIJ7ZAENx+9NuP/V8rHk32sf4eTC8dBrhvlWE90Kfevhxj ihM0OYHALwUlE60cm8AlWDVUtSXj8JcS++IWXOlFK7sf/JJu/dGxTwlZWck+t/vr4egt yoPxN3bVCWDPfRVrSQkTsnhq2a0jkIu+FTIdkO+MEbAokPQ34VMNgNMXEfCgS2RpPFgH 3vtn6ZEvnMg4YRm9pI2dV5Iexd1qwmqo7VPos32BQF/qfgssYAf/W+N17xQqFNVkXW9q XmGw== X-Forwarded-Encrypted: i=1; AJvYcCUmaQFySks8Lw69gwq11+rjHWJktjuC80N3I7ltdbgb71+62VcjyELYyvwoBcrmmF8rQ9Sd1XAHTBLuDkU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/19wfkgr2HKSHHEvHEE9Ah6qoKnQgn+0pPokMITGBXzvJfY7c tMMD79owkF9y0psSxlZAJZeoKtjmyRNSL00CrBLlpPOqxDI2/ElrNctNOnv8zbmLo0VgbOAtxHZ iVMZiEZYJ6nNwzO3R7Mg3mbbYF6on3FWg8qRfrWLngyxVFMtknBjz3EhzJeB8E2BBi+o= X-Gm-Gg: AeBDies0B8RRhUpRihwGh5k72xPYJawKYWsTe99b75AOj7+TIZQJMgGMJLVaS/uOQAt BpenrRxPLt6YBkRAWtKwfisHgA+iBjsZQU3uEVEQghbY0FTsi9H6a0G4sFx11+42pJvdnQT2vb4 wOrsjJ0Zdq76aJGLnCR+DbhpmbaMp7T37RWAUAiL84pSeiqAgP22/RMY6FjvBIdg55ryLMRErwG XtAZ65CimHs7A7rvEtQFyDFkWCxs5NXwPxEaehEJuEIzyGbMB2rXf0p9xPCNKscmAjSgHBo13HX 7oEluQ8zUlbUjd9x/TNJExmlQpcqUhCXInhD1PH1oUcpeEz4cLErykM8Ad9lehtPbq9U60jCiHC jrBRkKhzXWPCJYrjiLKijf98AtvJRSY8hS09p6RRhPyChSitWHmd1icEXWSk7uk7JXH0XkbvYUh UGIIcGKtQDfNBVvEeptZg= X-Received: by 2002:a17:903:1b4c:b0:2b2:420a:b48a with SMTP id d9443c01a7336-2b28182c458mr24575665ad.32.1775206880363; Fri, 03 Apr 2026 02:01:20 -0700 (PDT) X-Received: by 2002:a17:903:1b4c:b0:2b2:420a:b48a with SMTP id d9443c01a7336-2b28182c458mr24575075ad.32.1775206879727; Fri, 03 Apr 2026 02:01:19 -0700 (PDT) Received: from [10.133.33.111] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27472cdfesm53090625ad.14.2026.04.03.02.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 02:01:19 -0700 (PDT) Message-ID: <5fff7189-fee7-4d73-a9a1-728389900678@oss.qualcomm.com> Date: Fri, 3 Apr 2026 17:01:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next v4 2/6] wifi: ath12k: Add ath12k_hw_params for IPQ5424 To: Raj Kumar Bhagat , Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org, Saravanakumar Duraisamy References: <20260402-ath12k-ipq5424-v4-0-cd1e0f0a6c88@oss.qualcomm.com> <20260402-ath12k-ipq5424-v4-2-cd1e0f0a6c88@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260402-ath12k-ipq5424-v4-2-cd1e0f0a6c88@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAzMDA3OCBTYWx0ZWRfX1QR7k1S6lTSu x7TMaVo/xOfD1KD2MtxapzZ0MKCP2xpomzs/qXV3/NtCCz92vx6D94HTiMNlw3ZGcLEsMxODjnt dXjSx6spjXZTYuzqzcJ5lNEN9ncRPxW29Knkfk4mHaCxGXz28kE68ZXYezaTBp8UeaJR3hsrSqh WWwz2GXav96rq69hKJt38z7ZONI7soL0w5/b8YtIStNl0zesgrPGQSG2UN2S66d7cPwX4Fh3S42 3ZMsjlSvbETOr2J6RA2336dRt4y/aX074a//ZeJAQSktgacsG5CC9ajxsNhLCiH6Mp2fOaCjIRi 0u/yBaJ9qROFvSQ90LSlfn3/BIAEqfJE0aMPw+PHl2bcKXTiMA/RLCXNeUSlI9sg77B7ltqRNBx LLZU+KF3hbby25DcTXma/egyVRHW/eMLN9MXNkHg6jIDFB7V4HBrAbwSDmR+TgANV99sTL8Yq9b qf1SrL+j5kS1d9VHRcg== X-Authority-Analysis: v=2.4 cv=PNICOPqC c=1 sm=1 tr=0 ts=69cf81e1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Z7WYvUlOW1kuK6QZCLMA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: E51CaKw6kp-zXoG52ac2Y0MONaqNH11d X-Proofpoint-ORIG-GUID: E51CaKw6kp-zXoG52ac2Y0MONaqNH11d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-03_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604030078 On 4/2/2026 11:54 AM, Raj Kumar Bhagat wrote: > From: Saravanakumar Duraisamy > > Add ath12k_hw_params for the ath12k AHB-based WiFi 7 device IPQ5424. > The WiFi device IPQ5424 is similar to IPQ5332. Most of the hardware > parameters like hw_ops, wmi_init, ring_mask, etc., are the same between > IPQ5424 and IPQ5332, hence use these same parameters for IPQ5424. > Some parameters are specific to IPQ5424; initially set these to > 0 or NULL, and populate them in subsequent patches. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ5424 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Saravanakumar Duraisamy > Signed-off-by: Raj Kumar Bhagat > --- > drivers/net/wireless/ath/ath12k/core.h | 1 + > drivers/net/wireless/ath/ath12k/wifi7/hw.c | 75 ++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h > index 59c193b24764..68453594eba8 100644 > --- a/drivers/net/wireless/ath/ath12k/core.h > +++ b/drivers/net/wireless/ath/ath12k/core.h > @@ -157,6 +157,7 @@ enum ath12k_hw_rev { > ATH12K_HW_WCN7850_HW20, > ATH12K_HW_IPQ5332_HW10, > ATH12K_HW_QCC2072_HW10, > + ATH12K_HW_IPQ5424_HW10, > }; > > enum ath12k_firmware_mode { > diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hw.c b/drivers/net/wireless/ath/ath12k/wifi7/hw.c > index ec6dba96640b..9b9ca06a9f45 100644 > --- a/drivers/net/wireless/ath/ath12k/wifi7/hw.c > +++ b/drivers/net/wireless/ath/ath12k/wifi7/hw.c > @@ -753,6 +753,81 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = { > > .dp_primary_link_only = false, > }, > + { > + .name = "ipq5424 hw1.0", > + .hw_rev = ATH12K_HW_IPQ5424_HW10, > + .fw = { > + .dir = "IPQ5424/hw1.0", > + .board_size = 256 * 1024, > + .cal_offset = 128 * 1024, > + .m3_loader = ath12k_m3_fw_loader_remoteproc, > + .download_aux_ucode = false, > + }, > + .max_radios = 1, > + .single_pdev_only = false, > + .qmi_service_ins_id = ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_IPQ5332, > + .internal_sleep_clock = false, > + > + .hw_ops = &qcn9274_ops, > + .ring_mask = &ath12k_wifi7_hw_ring_mask_ipq5332, > + > + .host_ce_config = ath12k_wifi7_host_ce_config_ipq5332, > + .ce_count = 12, > + .target_ce_config = ath12k_wifi7_target_ce_config_wlan_ipq5332, > + .target_ce_count = 12, > + .svc_to_ce_map = > + ath12k_wifi7_target_service_to_ce_map_wlan_ipq5332, > + .svc_to_ce_map_len = 18, > + > + .rxdma1_enable = true, > + .num_rxdma_per_pdev = 1, > + .num_rxdma_dst_ring = 0, > + .rx_mac_buf_ring = false, > + .vdev_start_delay = false, > + > + .interface_modes = BIT(NL80211_IFTYPE_STATION) | > + BIT(NL80211_IFTYPE_AP) | > + BIT(NL80211_IFTYPE_MESH_POINT), > + .supports_monitor = true, > + > + .idle_ps = false, > + .download_calib = true, > + .supports_suspend = false, > + .tcl_ring_retry = true, > + .reoq_lut_support = false, > + .supports_shadow_regs = false, > + > + .num_tcl_banks = 48, > + .max_tx_ring = 4, > + > + .wmi_init = &ath12k_wifi7_wmi_init_qcn9274, > + > + .qmi_cnss_feature_bitmap = BIT(CNSS_QDSS_CFG_MISS_V01), > + > + .rfkill_pin = 0, > + .rfkill_cfg = 0, > + .rfkill_on_level = 0, > + > + .rddm_size = 0, > + > + .def_num_link = 0, > + .max_mlo_peer = 256, > + > + .otp_board_id_register = 0, > + > + .supports_sta_ps = false, > + > + .acpi_guid = NULL, > + .supports_dynamic_smps_6ghz = false, > + .iova_mask = 0, > + .supports_aspm = false, > + > + .ce_ie_addr = NULL, > + .ce_remap = NULL, > + .bdf_addr_offset = 0x940000, > + > + .dp_primary_link_only = true, > + }, > }; mhi_config and current_cc_support are missing, please explicitly set them. > > /* Note: called under rcu_read_lock() */ >