mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Krause <krause@cup.hp.com>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>,
	"David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, openib-general@openib.org,
	linux-kernel@vger.kernel.org, shemminger@osdl.org
Subject: Re: [openib-general] Dropping NETIF_F_SG since no checksum feature.
Date: Wed, 11 Oct 2006 11:21:43 -0700	[thread overview]
Message-ID: <6.2.0.14.2.20061011111146.03292b50@esmail.cup.hp.com> (raw)
In-Reply-To: <20061011094649.GD2701@mellanox.co.il>

At 02:46 AM 10/11/2006, Michael S. Tsirkin wrote:
>Quoting r. David Miller <davem@davemloft.net>:
> > Subject: Re: Dropping NETIF_F_SG since no checksum feature.
> >
> > From: "Michael S. Tsirkin" <mst@mellanox.co.il>
> > Date: Wed, 11 Oct 2006 11:05:04 +0200
> >
> > > So, it seems that if I set NETIF_F_SG but clear NETIF_F_ALL_CSUM,
> > > data will be copied over rather than sent directly.
> > > So why does dev.c have to force set NETIF_F_SG to off then?
> >
> > Because it's more efficient to copy into a linear destination
> > buffer of an SKB than page sub-chunks when doing checksum+copy.
> >
>
>Thanks for the explanation.
>Obviously its true as long as you can allocate the skb that big.
>I think you won't realistically be able to get 64K in a
>linear SKB on a busy system, though, is not that right?
>
>OTOH, having large MTU (e.g. 64K) helps performance a lot since it reduces 
>receive side processing overhead.

One thing to keep in mind is while it may help performance in a 
micro-benchmark, the system performance or the QoS impacts to other flows 
can be negatively impacted depending upon implementation.  For example, 
consider multiple messages interleaving (heaven help implementations that 
are not able to interleave multiple messages) on either the transmit or 
receive HCA / RNIC and how the time-to-completion of any message is 
extended out in time as a result of the interleave.  The effective 
throughput in terms of useful units of work can be lower as a result.   The 
same effect can be observed when there are a significant number connections 
in a device being simultaneously processed.

Also, if the copy-checksum is not performed on the processor where the 
application resides, then the performance can also be negatively impacted 
(want to have the right cache hot when initiated or concluded).  While the 
aggregate computational performance of systems may be increasing at a 
significant rate (set aside the per core vs. aggregate core debate), the 
memory performance gains are much less.  If you examine the longer term 
trends, there may be a flattening out of memory performance improvements by 
2009/10 without some major changes in the way controllers and subsystems 
are designed.

Mike 



      reply	other threads:[~2006-10-11 18:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-09 17:47 Michael S. Tsirkin
2006-10-09 16:50 ` Stephen Hemminger
2006-10-10 14:43   ` Michael S. Tsirkin
2006-10-10 17:43     ` Stephen Hemminger
2006-10-11  0:13       ` Michael S. Tsirkin
2006-10-11  0:15         ` Roland Dreier
2006-10-11  0:26           ` Michael S. Tsirkin
2006-10-11  3:33             ` Roland Dreier
2006-10-11  3:36               ` David Miller
2006-10-11  3:42                 ` Roland Dreier
2006-10-11  3:45                   ` David Miller
2006-10-11  3:49                     ` Roland Dreier
2006-10-11  3:50                       ` David Miller
2006-10-11  2:15         ` David Miller
2006-10-11  9:05           ` Michael S. Tsirkin
2006-10-11  9:09             ` Steven Whitehouse
2006-10-11 15:01               ` Michael S. Tsirkin
2006-10-11 20:11                 ` Steven Whitehouse
2006-10-11 20:52                   ` Michael S. Tsirkin
2006-10-11 20:57                   ` Stephen Hemminger
2006-10-11 21:23                     ` Michael S. Tsirkin
2006-10-11 21:29                       ` Stephen Hemminger
2006-10-11 21:42                         ` Michael S. Tsirkin
2006-10-11 21:41                       ` David Miller
2006-10-12 19:12                         ` Michael S. Tsirkin
2006-10-13  4:22                           ` David Miller
2006-10-13  6:17                             ` Michael S. Tsirkin
2006-10-11 20:52                 ` David Miller
2006-10-11 21:11                   ` Michael S. Tsirkin
2006-10-11  9:20             ` David Miller
2006-10-11  9:46               ` Michael S. Tsirkin
2006-10-11 18:21                 ` Michael Krause [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6.2.0.14.2.20061011111146.03292b50@esmail.cup.hp.com \
    --to=krause@cup.hp.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@mellanox.co.il \
    --cc=netdev@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®