From: Markus Elfring <Markus.Elfring@web.de>
To: Zhen Lei <thunder.leizhen@huawei.com>,
selinux@vger.kernel.org, Ondrej Mosnacek <omosnace@redhat.com>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jeff Vander Stoep <jeffv@google.com>,
Nick Kralevich <nnk@google.com>
Subject: Re: [PATCH] selinux: Fix potential counting error in avc_add_xperms_decision()
Date: Tue, 6 Aug 2024 18:30:47 +0200 [thread overview]
Message-ID: <600318b9-928c-4466-a8d1-334fab8c512f@web.de> (raw)
In-Reply-To: <20240806065113.1317-1-thunder.leizhen@huaweicloud.com>
> The count increases only when a node is successfully added to
> the linked list.
1. Please improve such a change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc2#n94
2. How do you think about to omit the word “potential” from the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2024-08-06 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 6:51 [PATCH 1/1] " thunder.leizhen
2024-08-06 13:25 ` Stephen Smalley
2024-08-06 21:55 ` Paul Moore
2024-08-07 6:27 ` Leizhen (ThunderTown)
2024-08-06 16:30 ` Markus Elfring [this message]
2024-08-07 9:16 ` [PATCH] " Leizhen (ThunderTown)
2024-08-07 11:21 ` Leizhen (ThunderTown)
2024-08-07 12:06 ` Markus Elfring
2024-08-07 13:20 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600318b9-928c-4466-a8d1-334fab8c512f@web.de \
--to=markus.elfring@web.de \
--cc=jeffv@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nnk@google.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®