From: Neil Armstrong <neil.armstrong@linaro.org>
To: Michael Walle <mwalle@kernel.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/panel-simple: add Evervision VGG644804 panel entry
Date: Tue, 5 Dec 2023 09:14:20 +0100 [thread overview]
Message-ID: <600382c8-9560-4228-b621-b41e28b2ace4@linaro.org> (raw)
In-Reply-To: <20231123102404.2022201-2-mwalle@kernel.org>
On 23/11/2023 11:24, Michael Walle wrote:
> Timings taken from the datasheet, although sometimes there are just
> typical values and it's not clear if they are no min and max values or
> if you must use the typical value exactly. To make things worse, there
> is no back porch but only a combined sync and back porch length.
>
> Unfortunately, there is not public datasheet. Therefore, here are the
> relevant timings:
> | min | typ | max |
> -----------------+-----+--------+-----+
> CLK frequency | - | 25.175 | - |
> HS period | - | 800 | - |
> HS pulse width | 5 | 30 | - |
> HS-DEN time | 112 | 144 | 175 |
> DEN pulse width | - | 640 | - |
> VS pulse width | 1 | 3 | 5 |
> VS-DEN time | - | 35 | - |
> VS period | - | 525 | - |
>
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 9367a4572dcf..26702a847b63 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1973,6 +1973,33 @@ static const struct panel_desc eink_vb3300_kca = {
> .connector_type = DRM_MODE_CONNECTOR_DPI,
> };
>
> +static const struct display_timing evervision_vgg644804_timing = {
> + .pixelclock = { 25175000, 25175000, 25175000 },
> + .hactive = { 640, 640, 640 },
> + .hfront_porch = { 16, 16, 16 },
> + .hback_porch = { 82, 114, 170 },
> + .hsync_len = { 5, 30, 30 },
> + .vactive = { 480, 480, 480 },
> + .vfront_porch = { 10, 10, 10 },
> + .vback_porch = { 30, 32, 34 },
> + .vsync_len = { 1, 3, 5 },
> + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
> + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
> + DISPLAY_FLAGS_SYNC_POSEDGE,
> +};
> +
> +static const struct panel_desc evervision_vgg644804 = {
> + .timings = &evervision_vgg644804_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 115,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> +};
> +
> static const struct display_timing evervision_vgg804821_timing = {
> .pixelclock = { 27600000, 33300000, 50000000 },
> .hactive = { 800, 800, 800 },
> @@ -4334,6 +4361,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "eink,vb3300-kca",
> .data = &eink_vb3300_kca,
> + }, {
> + .compatible = "evervision,vgg644804",
> + .data = &evervision_vgg644804,
> }, {
> .compatible = "evervision,vgg804821",
> .data = &evervision_vgg804821,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-12-05 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 10:24 [PATCH 1/2] dt-bindings: display: simple: add Evervision VGG644804 panel Michael Walle
2023-11-23 10:24 ` [PATCH 2/2] drm/panel-simple: add Evervision VGG644804 panel entry Michael Walle
2023-12-05 8:14 ` Neil Armstrong [this message]
2023-11-23 17:33 ` [PATCH 1/2] dt-bindings: display: simple: add Evervision VGG644804 panel Conor Dooley
2023-12-05 8:26 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600382c8-9560-4228-b621-b41e28b2ace4@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®