mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Evgeny Sagatov <evgeny.sagatov@gmail.com>
Cc: regressions@lists.linux.dev, linux-acpi@vger.kernel.org,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	LKML <linux-kernel@vger.kernel.org>,
	Wysocki Rafael J <rafael.j.wysocki@intel.com>
Subject: Re: Pressing the power button causes the device to freeze completely
Date: Mon, 27 Apr 2026 20:48:17 +0200	[thread overview]
Message-ID: <6005325.DvuYhMxLoT@rafael.j.wysocki> (raw)
In-Reply-To: <CAGAxtY3HF3iOV7ZKq9-LTjyA-p3jNVHKSi5CBM8AJ38LYUdXbw@mail.gmail.com>

On Sunday, April 26, 2026 10:45:03 PM CEST Evgeny Sagatov wrote:
> dmesg | grep "frequency s"
> [    8.622778] acpi_cpufreq: CPU0: Using I/O space for frequency scaling
> [    8.622806] cpufreq: CPU0: Fast frequency switching enabled
> [    8.622869] acpi_cpufreq: CPU1: Using I/O space for frequency scaling
> [    8.622888] cpufreq: CPU1: Fast frequency switching enabled
> [    8.622938] acpi_cpufreq: CPU2: Using I/O space for frequency scaling
> [    8.622955] cpufreq: CPU2: Fast frequency switching enabled
> [    8.623006] acpi_cpufreq: CPU3: Using I/O space for frequency scaling
> [    8.623026] cpufreq: CPU3: Fast frequency switching enabled
> 
> When I press the power button, a message is displayed:
> apr 26 23:40:36 srv kernel: ACPI power button event
> 
> The PC does not freeze.

Good.

> The single core performance benchmark shows good values.

That most likely is a coincidence.

The above means that the issue is related to HW accesses in the I/O space.

I don't actually think that the writes to the I/O space outright clash with
each other, but the timing between them may be somewhat overly aggressive.

Let's first check what I/O ports come into play though.

Please apply the patch below (which is a replacement for the previous one),
run

$ dmesg | grep "frequency scaling"

after a fresh boot of the new kernel and let me know the output of it.

Then, press the power button and send the messages printed after that.

---
 drivers/acpi/acpica/evevent.c  |   12 ++++++++++++
 drivers/cpufreq/acpi-cpufreq.c |    8 ++++++--
 drivers/cpufreq/cpufreq.c      |    1 +
 3 files changed, 19 insertions(+), 2 deletions(-)

--- a/drivers/acpi/acpica/evevent.c
+++ b/drivers/acpi/acpica/evevent.c
@@ -243,6 +243,18 @@ static u32 acpi_ev_fixed_event_dispatch(
 	(void)acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
 				      status_register_id, ACPI_CLEAR_STATUS);
 
+	if (event == ACPI_EVENT_POWER_BUTTON) {
+		pr_info("ACPI power button event\n");
+		if (acpi_gbl_fixed_event_info[event].status_register_id == 0)
+			pr_info("ACPI event status I/O port number: %llu\n",
+				acpi_gbl_xpm1a_status.address);
+		else
+			pr_info("ACPI event status register ID: %u\n",
+				acpi_gbl_fixed_event_info[event].status_register_id);
+
+		return (ACPI_INTERRUPT_HANDLED);
+	}
+
 	/*
 	 * Make sure that a handler exists. If not, report an error
 	 * and disable the event to prevent further interrupts.
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -479,8 +479,8 @@ static unsigned int acpi_cpufreq_fast_sw
 			return next_freq;
 	}
 
-	data->cpu_freq_write(&perf->control_register,
-			     perf->states[next_perf_state].control);
+	/*data->cpu_freq_write(&perf->control_register,
+			     perf->states[next_perf_state].control);*/
 	perf->state = next_perf_state;
 	return next_freq;
 }
@@ -887,9 +887,13 @@ static int acpi_cpufreq_cpu_init(struct
 		 * unknown and not detectable via IO ports.
 		 */
 		policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
+		pr_info("CPU%u: Using I/O space for frequency scaling\n", cpu);
+		pr_info("CPU%u: frequency scaling I/O port number: %llu\n", cpu,
+			perf->control_register.address);
 		break;
 	case ACPI_ADR_SPACE_FIXED_HARDWARE:
 		acpi_cpufreq_driver.get = get_cur_freq_on_cpu;
+		pr_info("CPU%u: Using FFH for frequency scaling\n", cpu);
 		break;
 	default:
 		break;
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -473,6 +473,7 @@ void cpufreq_enable_fast_switch(struct c
 	if (cpufreq_fast_switch_count >= 0) {
 		cpufreq_fast_switch_count++;
 		policy->fast_switch_enabled = true;
+		pr_info("CPU%u: Fast frequency switching enabled\n", policy->cpu);
 	} else {
 		pr_warn("CPU%u: Fast frequency switching not enabled\n",
 			policy->cpu);




  reply	other threads:[~2026-04-27 18:48 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <184091776095270@mail.yandex.ru>
2026-04-16  8:22 ` Thorsten Leemhuis
     [not found]   ` <186071776359023@mail.yandex.ru>
2026-04-16 17:35     ` Thorsten Leemhuis
     [not found]       ` <26521776666243@mail.yandex.ru>
2026-04-20  6:41         ` Sagatov, Evgeniy
2026-04-20  6:54           ` Thorsten Leemhuis
2026-04-20 19:34             ` Sagatov, Evgeniy
2026-04-20 22:20               ` Sagatov, Evgeniy
2026-04-21  5:01                 ` Thorsten Leemhuis
2026-04-21  9:28                   ` Sagatov, Evgeniy
2026-04-21 15:11 ` Wysocki, Rafael J
2026-04-21 20:41   ` Rafael J. Wysocki
     [not found]     ` <168591776860440@mail.yandex.ru>
2026-04-22 12:36       ` Evgeny Sagatov
2026-04-22 13:26         ` Rafael J. Wysocki
2026-04-22 13:34           ` Evgeny Sagatov
2026-04-22 14:04             ` Rafael J. Wysocki
2026-04-22 14:48               ` Evgeny Sagatov
2026-04-23 13:17                 ` Rafael J. Wysocki
2026-04-23 14:51                   ` Evgeny Sagatov
2026-04-23 18:21                     ` Rafael J. Wysocki
2026-04-23 20:07                       ` Evgeny Sagatov
2026-04-24 14:40                         ` Rafael J. Wysocki
2026-04-24 17:06                           ` Evgeny Sagatov
2026-04-24 19:45                             ` Rafael J. Wysocki
2026-04-24 21:18                               ` Evgeny Sagatov
2026-04-26 14:50                                 ` Rafael J. Wysocki
2026-04-26 14:54                                   ` Rafael J. Wysocki
2026-04-26 20:45                                     ` Evgeny Sagatov
2026-04-27 18:48                                       ` Rafael J. Wysocki [this message]
2026-04-27 20:12                                         ` Evgeny Sagatov
2026-04-27 20:31                                           ` Rafael J. Wysocki
2026-04-27 21:49                                             ` Evgeny Sagatov
2026-04-28 17:40                                               ` Rafael J. Wysocki
2026-04-28 19:11                                                 ` Evgeny Sagatov
2026-04-28 19:58                                                   ` Rafael J. Wysocki
2026-04-28 21:05                                                     ` Evgeny Sagatov
2026-04-29 18:24                                                       ` Pressing the power button causes the device to freeze completely (schedutil involved) Rafael J. Wysocki
2026-04-29 20:22                                                         ` Rafael J. Wysocki
2026-04-29 21:16                                                           ` Evgeny Sagatov
2026-04-30 10:40                                                             ` Rafael J. Wysocki
2026-04-30 10:53                                                               ` Rafael J. Wysocki
2026-04-30 11:41                                                                 ` Evgeny Sagatov
2026-04-30 11:57                                                                   ` Evgeny Sagatov
2026-04-30 14:10                                                                     ` Rafael J. Wysocki
2026-04-30 16:04                                                                       ` Evgeny Sagatov
2026-04-30 13:57                                                                   ` Rafael J. Wysocki
2026-04-30 14:42                                                                     ` Rafael J. Wysocki
2026-04-30 23:05                                                                       ` Evgeny Sagatov
2026-04-30 23:17                                                                       ` Evgeny Sagatov
2026-05-01 12:00                                                                         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6005325.DvuYhMxLoT@rafael.j.wysocki \
    --to=rafael@kernel.org \
    --cc=evgeny.sagatov@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®