Re: [PATCH v7 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc

[Jiebing Chen <jiebing.chen@amlogic.com>]

在 2026/10/28 22:48, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On Wed, Oct 21, 2026 at 03:08:28PM +0800, Jiebing Chen wrote:
>> The audio power domain has been found on S4 device.
>> It must be enabled prior to audio operations.
>>
>> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
>> ---
>>   .../bindings/clock/amlogic,axg-audio-clkc.yaml          | 17 ++++++++++++++++-
>>   1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> index fd7982dd4cea..69f5fef5f14a 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> @@ -20,6 +20,7 @@ properties:
>>       enum:
>>         - amlogic,axg-audio-clkc
>>         - amlogic,g12a-audio-clkc
>> +      - amlogic,s4-audio-clkc
>>         - amlogic,sm1-audio-clkc
>>
>>     '#clock-cells':
>> @@ -100,6 +101,8 @@ properties:
>>     resets:
>>       description: internal reset line
>>
>> +  power-domains:
>> +    maxItems: 1
> Missing blank line.
got it, thanks
>
>>   required:
>>     - compatible
>>     - '#clock-cells'
>> @@ -115,6 +118,7 @@ allOf:
>>             contains:
>>               enum:
>>                 - amlogic,g12a-audio-clkc
>> +              - amlogic,s4-audio-clkc
>>                 - amlogic,sm1-audio-clkc
>>       then:
>>         required:
>> @@ -122,7 +126,18 @@ allOf:
>>       else:
>>         properties:
>>           '#reset-cells': false
>> -
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - amlogic,s4-audio-clkc
>> +    then:
>> +      required:
>> +        - power-domains
>> +    else:
>> +      properties:
>> +        power-domains: false
> And here as well.
>
> Best regards,
> Krzysztof
>