From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132A5C433DB for ; Wed, 17 Mar 2021 22:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB83E64F30 for ; Wed, 17 Mar 2021 22:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbhCQWuY (ORCPT ); Wed, 17 Mar 2021 18:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhCQWtv (ORCPT ); Wed, 17 Mar 2021 18:49:51 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21AC9C06175F for ; Wed, 17 Mar 2021 15:49:51 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id t6so3098160ilp.11 for ; Wed, 17 Mar 2021 15:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A76Ll2cPy1caYrVV3BwNuFe9RGXU0Tlri1xHjMBctEo=; b=DoMVUsaB0b3+ZrpeqKQ7oBIrIRIqzmcSim6CbL4noy2UthcD1OxtEHyiGvP3c9IuLS 6nASGOLuYyRLsZvZMnHAZHG9/zdVbvpwyBEzLx8G0J+UcvZD8yctBt4AmggfU2i/zHVS S7AHJBEppg55gxejMxHiOTb+APl4+Pwv4Opo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A76Ll2cPy1caYrVV3BwNuFe9RGXU0Tlri1xHjMBctEo=; b=AafYtuZwRHRuKqcoUAy+S0WL7K9iCCuIgeuveasJEH22oZTW9hl3FASFjzUM7g6ocG r+U3V9ZZxNGnvpjwGl9D+MTOK1d8a0UYmfMdZI6hObMPb2CjJKT0tWlUmxDqqIdaz9JV muvwi4Ng+PR9fGH307jm8clv7JxdtO9j7BJOUoORu/hMlOPe3YGeZHiBXTA+G48bBimN dL3erTyJYe/5pl9Xl5PQF7cW7h/9jJx0pO3jHAnKdSC/7AS5k//RnoR35ZBgzDuQ+evH HydPp1fi7Ndm83/qq4l671iQzoho2/+z++vXguggldFyz4upbkTyw8VIFOxlCC/pUd1n xSAw== X-Gm-Message-State: AOAM530KbaR0YwDBySOk53kPn4esv5BjIYpeh1iMlYu62NOgrxC3EKDx 4XRh7H9T4inJutwEy6bzg0xNDzzIwULytA== X-Google-Smtp-Source: ABdhPJzYZibsyqKxbBpc2XiQZ6pO8hjBPmHN47BGQP81qejjd7X6baLkfpqzjIm8xey2f/FpKN3P7A== X-Received: by 2002:a05:6e02:174b:: with SMTP id y11mr9475632ill.152.1616021390375; Wed, 17 Mar 2021 15:49:50 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id v3sm181671ioh.25.2021.03.17.15.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 15:49:49 -0700 (PDT) Subject: Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32() To: Florian Fainelli , Alex Elder , davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210317222946.118125-1-elder@linaro.org> <20210317222946.118125-3-elder@linaro.org> <36b9977b-32b1-eb4a-0056-4f742e3fe4d6@gmail.com> From: Alex Elder Message-ID: <60106d7b-ad70-01fa-9f90-fe384cc428f8@ieee.org> Date: Wed, 17 Mar 2021 17:49:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <36b9977b-32b1-eb4a-0056-4f742e3fe4d6@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/21 5:47 PM, Florian Fainelli wrote: >> +/* Encapsulate extracting high-order 32 bits of DMA address */ >> +static u32 dma_addr_high32(dma_addr_t addr) >> +{ >> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT >> + return (u32)(addr >> 32); > You can probably use upper_32bits() here... Where is that defined? I'd be glad to use it. -Alex