From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3D5C433EF for ; Fri, 22 Apr 2022 09:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445919AbiDVJSq (ORCPT ); Fri, 22 Apr 2022 05:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445872AbiDVJMH (ORCPT ); Fri, 22 Apr 2022 05:12:07 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73A8851E6F for ; Fri, 22 Apr 2022 02:09:13 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id g13so15154725ejb.4 for ; Fri, 22 Apr 2022 02:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VlCaDBv0lI+bMbyzSUvp/QCQTyaZL5yq76P9L1bSzBQ=; b=yfbh/IVH9TL8f6D91rmaiLtVr9a+9hMrhh0G0Ce08L9K7Ir1dXIUPQ51SjLXHOpw1o ZKJSnXshJ1ypF5ZGGPvX816do88C79vYfxQMZg6DgJqELawooJjpeW2QK2uv+fdc5FCf yCL0oCldP18VaJcrPVGoZr1F8EDKJNgGYoqLbcKM5iMose5+wIrRercEBRQM39vRLMky aV2+I+HeSbmLhiTWdw/wQYu2BHqE0fA21yDnDw+fbfZJGebOxpOEKjYAFjOvy8ymgxma 7aWVrWOcPKUq9z6enLAO6rLWVz3/WVV/am3m8SBNn4wF++RtpxXXap4UdF8SsXF12NPB JhnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VlCaDBv0lI+bMbyzSUvp/QCQTyaZL5yq76P9L1bSzBQ=; b=S1KlYz/zYOdRPRwnVFpTElHBD1tLYjUKGQAGWOlyvLfqF+5jpEbDyXsBgBwf8RKEOA /O1n0oLvRBWGoegLRYV033d0iPL7xlKhgvgSMMch+p8NDT/bIl6aDEH2qX58lBRCBWEE R8IrIvz4RAlULdU9/eV2CHR4kL3LucA7SF5ITxKhp/PMrkP7VvLG6/UZZoW8YaPNzyXs Qvb2s9m6wdP3eBm+MXPzvAd75/+0mrt0jfNnNtNTokhSH/2s5l2P3ulC0r8RBMrSDQcs IsZy9X0S6pfHitJ52iHms7li10A7b11/Z8r4xMo1HhxB9FA7i9WVKzU1nLgW2s8rcoth 8REA== X-Gm-Message-State: AOAM531BGwY+5JhlXTsC3Dgv9LhbOqV/OcGjtfx/7UiGYrGLm4tcHqBy Go8oRhsDKPyMKsaHbnTMnBmyhw== X-Google-Smtp-Source: ABdhPJyJ1gxk2RK2g2BtIkquk3vuHYv5yKKdtM9KZTp5q96PgxAHQPNrOLJ2bGTM3i+6i+rH4s/W7A== X-Received: by 2002:a17:906:9458:b0:6e8:86e5:5b8c with SMTP id z24-20020a170906945800b006e886e55b8cmr3230369ejx.325.1650618552021; Fri, 22 Apr 2022 02:09:12 -0700 (PDT) Received: from [192.168.0.232] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id v22-20020a50a456000000b00422a4841c61sm660278edb.58.2022.04.22.02.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 02:09:11 -0700 (PDT) Message-ID: <601a1b5b-7189-cb9e-a945-6f2d49583633@linaro.org> Date: Fri, 22 Apr 2022 11:09:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/3] dt-bindings: Document ltrf216a light sensor bindings Content-Language: en-US To: Shreeya Patel , jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com, krisman@collabora.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, alvaro.soliverez@collabora.com References: <20220421140133.354498-1-shreeya.patel@collabora.com> <20220421140133.354498-3-shreeya.patel@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220421140133.354498-3-shreeya.patel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/2022 16:01, Shreeya Patel wrote: Thank you for your patch. There is something to discuss/improve. > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@53 { > + compatible = "liteon,ltrf216a"; You have here unusual indentation - looks like 8 spaces, while the rest of example is properly indented with 4 spaces. Please use 4 spaces for entire DTS example. All rest looks good, so with indentation fixes: Reviewed-by: Krzysztof Kozlowski > + reg = <0x53>; > + vdd-supply = <&vdd_regulator>; > + interrupt-parent = <&gpio0>; > + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; Best regards, Krzysztof