From: David Daney <ddaney@caviumnetworks.com>
To: "Maciej W. Rozycki" <macro@mips.com>,
Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: linux-mips@linux-mips.org,
Dragan Cecavac <dragan.cecavac@mips.com>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
Douglas Leung <douglas.leung@mips.com>,
Goran Ferenc <goran.ferenc@mips.com>,
James Hogan <james.hogan@mips.com>,
James Hogan <jhogan@kernel.org>,
linux-kernel@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Paul Burton <paul.burton@imgtec.com>,
Paul Burton <paul.burton@mips.com>,
Petar Jovanovic <petar.jovanovic@mips.com>,
Raghu Gandham <raghu.gandham@mips.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo
Date: Fri, 20 Oct 2017 16:56:51 -0700 [thread overview]
Message-ID: <601ab9f9-5092-7e44-acf1-ba5a9f0c1962@caviumnetworks.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1710202129250.3886@tp.orcam.me.uk>
On 10/20/2017 01:47 PM, Maciej W. Rozycki wrote:
> On Fri, 20 Oct 2017, Aleksandar Markovic wrote:
>
>> Remove unnecessary space from FPU info segment of /proc/cpuinfo.
>
> NAK. As I recall back in Nov 2001 I placed the extra space there to
> visually separate the CPU part from the FPU part, e.g.:
>
> cpu model : R3000A V3.0 FPU V4.0
> cpu model : SiByte SB1 V0.2 FPU V0.2
>
> etc. And the motivation behind it still stands. Please remember that
> /proc/cpuinfo is there for live humans to parse and grouping all these
> pieces together would make it harder. Which means your change adds no
> value I'm afraid.
I think it is even riskier than that. This is part of the
kernel-userspace ABI, many programs parse this file, any gratuitous
changes risk breaking something.
I don't really have an opinion about the various *printf functions being
used, but think the resultant change in what is visible to userspace
should not be done.
>
> NB regrettably back in those days much of the patch traffic happened off
> any mailing list, however I have quickly tracked down my archival copy of
> the original submission of the change introducing this piece of code and
> I'll be happy to share it with anyone upon request.
>
> Maciej
>
next prev parent reply other threads:[~2017-10-20 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 14:20 Aleksandar Markovic
2017-10-20 15:17 ` Joe Perches
2017-10-20 20:52 ` Maciej W. Rozycki
2017-10-20 21:08 ` Joe Perches
2017-10-20 21:46 ` Maciej W. Rozycki
2017-10-20 23:09 ` Joe Perches
2017-10-20 20:47 ` Maciej W. Rozycki
2017-10-20 23:56 ` David Daney [this message]
2017-10-23 7:54 ` Miodrag Dinic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601ab9f9-5092-7e44-acf1-ba5a9f0c1962@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aleksandar.markovic@mips.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=douglas.leung@mips.com \
--cc=dragan.cecavac@mips.com \
--cc=goran.ferenc@mips.com \
--cc=james.hogan@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
--cc=miodrag.dinic@mips.com \
--cc=paul.burton@imgtec.com \
--cc=paul.burton@mips.com \
--cc=petar.jovanovic@mips.com \
--cc=raghu.gandham@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®