From: Joe Perches <joe@perches.com>
To: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
Cc: dzickus@redhat.com, jtoppins@redhat.com
Subject: Re: [PATCH] get_maintainer.pl: Add optional .get_maintainer.MAINTAINERS override
Date: Tue, 26 Jun 2018 13:16:11 -0700 [thread overview]
Message-ID: <601f0e6bf3baa88b9f6145e635d728a435542292.camel@perches.com> (raw)
In-Reply-To: <20180626182505.4176-1-prarit@redhat.com>
On Tue, 2018-06-26 at 14:25 -0400, Prarit Bhargava wrote:
> OSes have additional maintainers that should be cc'd on patches or may
> want to circulate internal patches.
>
> Parse the .get_maintainer.MAINTAINERS file. Entries in the file
> can begin with a '+' to indicate the email and list entries should be
> added to the exiting MAINTAINERS output, or a '-' to indicate that the
> entries should override the existing MAINTAINERS file.
>
> Also add a help entry for the .get_maintainers.ignore file.
I see no reason for this patch to be applied.
Why should it?
Why shouldn't this be in your private repository?
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: dzickus@redhat.com
> Cc: jtoppins@redhat.com
> ---
> scripts/get_maintainer.pl | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index c87fa734e3e1..239f4d2ce972 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -384,6 +384,32 @@ sub find_ignore_git {
> read_all_maintainer_files();
>
> sub read_all_maintainer_files {
> + my $conf = which_conf(".get_maintainer.MAINTAINERS");
> + if ( -f $conf) {
> + my @conf_args;
> + my $add = 0;
> + open(my $conffile, '<', "$conf")
> + or warn "$P: Can't find a readable .get_maintainer.MAINTAINERS file $!\n";
> + while (<$conffile>) {
> + my $line = $_;
> + if ($line =~ m/^\+/ ) {
> + $add = 1;
> + }
> + next if ($line =~ m/^\s*#/);
> + $line =~ s/^\+//g;
> + $line =~ s/^\-//g;
> + $line =~ s/\s*\n?$//;
> + push(@mfiles, $line);
> + }
> + close($conffile);
> + if ($add eq 0) {
> + foreach my $file (@mfiles) {
> + read_maintainer_file("$file");
> + }
> + return;
> + }
> + }
> +
> if (-d "${lk_path}MAINTAINERS") {
> opendir(DIR, "${lk_path}MAINTAINERS") or die $!;
> my @files = readdir(DIR);
> @@ -1068,6 +1094,14 @@ Notes:
> Entries in this file can be any command line argument.
> This file is prepended to any additional command line arguments.
> Multiple lines and # comments are allowed.
> + File ".get_maintainer.ignore", if it exists in the linux kernel source root
> + directory, can contain a list of email addresses to ignore. Multiple
> + lines and # comments are allowed.
> + File ".get_maintainer.MAINTAINERS", if it exists in the linux kernel source
> + root directory, can change the location of the MAINTAINERS file.
> + Entries beginning with a '+' are added to the default list, and
> + entries beginning with a '-' override the existing MAINTAINERS list
> + lookup. Multiple lines and # comments are allowed.
> Most options have both positive and negative forms.
> The negative forms for --<foo> are --no<foo> and --no-<foo>.
>
next prev parent reply other threads:[~2018-06-26 20:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 18:25 Prarit Bhargava
2018-06-26 20:16 ` Joe Perches [this message]
2018-06-26 22:52 ` Prarit Bhargava
2018-06-26 23:04 ` Joe Perches
2018-06-26 23:29 ` Prarit Bhargava
2018-07-06 17:54 ` Don Zickus
2018-07-06 18:31 ` Joe Perches
2018-07-06 18:44 ` Don Zickus
2018-07-06 19:39 ` Prarit Bhargava
2018-07-06 21:36 ` Joe Perches
2018-07-06 21:58 ` Don Zickus
2018-07-06 22:09 ` Joe Perches
2018-07-06 22:12 ` Don Zickus
2018-07-06 22:14 ` Joe Perches
2018-07-06 22:30 ` Don Zickus
2018-07-06 22:32 ` Don Zickus
2018-07-13 18:51 ` Don Zickus
2018-07-14 0:11 ` Joe Perches
2018-07-16 21:20 ` Don Zickus
2018-07-30 18:48 ` Don Zickus
2018-07-06 19:47 ` Don Zickus
2018-08-04 1:11 ` [PATCH] get_maintainer.pl: Add -mpath=<path or file> for MAINTAINERS file location Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601f0e6bf3baa88b9f6145e635d728a435542292.camel@perches.com \
--to=joe@perches.com \
--cc=dzickus@redhat.com \
--cc=jtoppins@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®