From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B28878681 for ; Wed, 31 Jan 2024 12:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706704639; cv=none; b=VGRP9DeXr6QbirQJ4awu+5L5x8tim6G7AhEDFO9TUhQZu2oslGQa96t/+/ZKjXflfXMw2FS+EeJgLDzd08bjy8N87OpF0/vuQ7TDOr6DaKU8cIRXacfkD7WCI8ioddaLJ6k94CLBj/uZe7l+Kf4U4oHcM0aBodE2SDTOmKcC4Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706704639; c=relaxed/simple; bh=Ve4gakTdVS97IwqTqcMnjzvWFWX6F6kTDN1mDs18iWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gBqwjgXexSnn8JKxRqKDnNCREpUl5nlrtWQslGYYrnYUbP4kTZnFj74ebEH2rElIwIX2C7ET2jLUHtyWBINnECbgfYTGRYMI3Yg/85m2Jpij51RgfV2e59kjLpiyfQkP6kDDBsuOpA1FlUxuO7MW2Ez4/2587ZnJgTPxL98yuMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=41d6lcDs; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="41d6lcDs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706704635; bh=Ve4gakTdVS97IwqTqcMnjzvWFWX6F6kTDN1mDs18iWk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=41d6lcDsQ90ipamoTz3UtZcsw2iXlPy7t1JTzpmTLR9qEbkF37yICg6gufCEmP0xi WikrqZ5S9PupmXPsKWNrWuwr2aMpfDF4Y5cy5uQhRf0fBEAaBbetM4/ChJaJNQ4T+c 5LnyycU1ikRrIP4h9TjQXLse8mkj35nDJorXGj47AR//KMgBFNOVWJgkBqcG033AnQ 26XmZh/XWEklOHVyRvibqt4MB36P9DxGhsgfcdpXqn1x3UqKWKXDaWUuy/Oljwtcmi LvTmnmT2eqU2su1/k/KGbdmAaHNxHCsjOhhX5fh7AFIJUShIbrSH3R/UBn7xFO0oef l5gafT5LSpoxw== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 65D1D378203B; Wed, 31 Jan 2024 12:37:14 +0000 (UTC) Message-ID: <6020133f-53ee-4bbe-856f-7b7b0957081f@collabora.com> Date: Wed, 31 Jan 2024 13:37:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets Content-Language: en-US To: =?UTF-8?B?SmlheGluIFl1ICjkv57lrrbpkasp?= Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "wenst@chromium.org" , "ajye_huang@compal.corp-partner.google.com" , =?UTF-8?B?Q2h1bnh1IExpICjmnY7mmKXml60p?= , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsik=?= , "broonie@kernel.org" , "dri-devel@lists.freedesktop.org" , "kuninori.morimoto.gx@renesas.com" , "andrzej.hajda@intel.com" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "robert.foss@linaro.org" , "Laurent.pinchart@ideasonboard.com" , "neil.armstrong@linaro.org" , "alsa-devel@alsa-project.org" , "nfraprado@collabora.com" References: <20230730180803.22570-1-jiaxin.yu@mediatek.com> <20230730180803.22570-3-jiaxin.yu@mediatek.com> <25e6ab45-ecad-4bc3-bf4d-983243c939ad@sirena.org.uk> <089fe457-1c61-4b7b-ad37-a67e7f46cb56@sirena.org.uk> <6aa6947865795fc534b61f5b8a80b3c42fd5a0cd.camel@mediatek.com> <9c90185c-9cd4-4a08-9925-be5d460af54d@sirena.org.uk> <11f4cfd2-f6a2-45cb-923a-95760a1b9883@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 31/01/24 13:25, Jiaxin Yu (俞家鑫) ha scritto: > On Wed, 2024-01-31 at 12:42 +0100, AngeloGioacchino Del Regno wrote: >> Il 03/08/23 21:33, Mark Brown ha scritto: >>> On Thu, Aug 03, 2023 at 07:20:15AM +0000, Jiaxin Yu (俞家鑫) wrote: >>> >>>> I agree with you, in fact the speaker is indeed doing this way. >>>> But >>>> about the hdmi that on the board, I did not find a defination >>>> link >>>> snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to replace. The >>>> purpose >>>> is to control it link speaker. Or what do you suggest I should >>>> do? >>> >>> I think the sensible thing here is to define a DIGITAL_OUTPUT() >>> which >>> can be used for HDMI, S/PDIF and anything else that comes up and >>> isn't >>> clearly wrong like reusing one of the analog descriptions is. >> >> Hello Jiaxin, >> >> the MT8186 Corsola Chromebooks are broken upstream without this >> series. >> >> Are you still interested in upstreaming this one? >> >> Thanks, >> Angelo > > Hello Angelo, > > No, I'm still interesting in upstream this series. It's just that I > have less time recently. I'm considering revisiting this issue next > mouth. Do you have any suggestions for this? > Nothing on top of Mark's suggestions. Angelo