From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: David Miller <davem@davemloft.net>
Cc: jiri@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sched: cls_api: fix dead code in switch
Date: Thu, 26 Jul 2018 16:32:01 -0500 [thread overview]
Message-ID: <6021c3c3-dc4a-ec09-a0dc-23ff548fa9f1@embeddedor.com> (raw)
In-Reply-To: <20180726.141022.1379401977396818228.davem@davemloft.net>
On 07/26/2018 04:10 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Wed, 25 Jul 2018 09:07:24 -0500
>
>> Code at line 1850 is unreachable. Fix this by removing the break
>> statement above it, so the code for case RTM_GETCHAIN can be
>> properly executed.
>>
>> Addresses-Coverity-ID: 1472050 ("Structurally dead code")
>> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied, thanks.
>
> Please use "[PATCH net-next] ..." in your subject lines to indirect
> the tree that this change is relevant for and targetted to.
>
Got it. Will do next time.
Thanks
--
Gustavo
prev parent reply other threads:[~2018-07-26 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:07 Gustavo A. R. Silva
2018-07-25 14:31 ` Jiri Pirko
2018-07-26 21:10 ` David Miller
2018-07-26 21:32 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6021c3c3-dc4a-ec09-a0dc-23ff548fa9f1@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®