From: "Maíra Canal" <mcanal@igalia.com>
To: Dan Carpenter <dan@pereq.eu>, Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] drm/vc4: release firmware on error paths in vc4_hvs_bind()
Date: Wed, 11 Nov 2026 11:01:20 -0300 [thread overview]
Message-ID: <6028f8d4-5e57-4d83-81ae-2a679361a432@igalia.com> (raw)
In-Reply-To: <avRxlbgy9mtT1rR6@stanley.mountain>
Hi Dan,
On 11/11/26 10:45, Dan Carpenter wrote:
> On Wed, Nov 11, 2026 at 02:15:28PM +0100, Tomasz Unger wrote:
>> So without the patch every failed bind leaks one reference, and with the
>> patch the reference is dropped.
>>
>> Tested-by: Tomasz Unger <tomasz.unger@yahoo.pl>
>>
>> One note about the Fixes tag: 2fa4ef5fb943 only moved this code around.
>> As far as I can tell, the rpi_firmware_get() before devm_clk_get()
>> without a put on the error path was introduced by commit 2a001ca00ad5
>> ("drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code"), which went
>> into v6.2.
>
> Huh. Wow. Thanks. I'll resend the patch with the correct Fixes tag.
A patch addressing this issue is already queued for this week's drm PR
[1]. Sorry for letting your patch slip through the cracks.
[1]
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/af200e91c7b996177aa90981b2f0e794b085d43a
Best regards,
- Maíra
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2026-11-11 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 12:14 Dan Carpenter
2025-04-03 16:25 ` Dave Stevenson
2026-11-11 13:15 ` Tomasz Unger
2026-11-11 13:45 ` Dan Carpenter
2026-11-11 14:01 ` Maíra Canal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6028f8d4-5e57-4d83-81ae-2a679361a432@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dan@pereq.eu \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomasz.unger@yahoo.pl \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®