From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC72EC4332F for ; Sun, 18 Dec 2022 18:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbiLRS3e (ORCPT ); Sun, 18 Dec 2022 13:29:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbiLRS3I (ORCPT ); Sun, 18 Dec 2022 13:29:08 -0500 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D9052ADB; Sun, 18 Dec 2022 09:56:45 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7D0563200805; Sun, 18 Dec 2022 12:56:44 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Sun, 18 Dec 2022 12:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671386204; x=1671472604; bh=Lr3MWV45UB kC+Upx5XL3PAvGROvHCsXEucBbusCtnP0=; b=eJl4LtUIB9x18YUGZrQ4GBqrKA 9CzU5TZPAy7j+3eWm/GVppdUM4HAOIBMnvYbv16dUTug5nUsFzrmkJNWEzVCzr/A Tm4d6Tjh8hktklG13uv+veEEUySiw9F9kNPveUJqrEGUKi3yjlasAckU3kAzYvsb EXf6RevLcQrqBLLCa2orfRqOc43rl3rv5FXcXvadRwD1Kc5x0z7KOgy4nczXPd3j Lz9PB4YBV17Np68rBvOqZPZXrOJW50mKQ4qtQ2ejmrUy0osUvaIQU5G30Opr/qEF FO6wP5rql3XyGtY/dLHH6N+cHgVS0b8pMjvAS2KI1/ZBh/rlgj13uf1vkPlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671386204; x=1671472604; bh=Lr3MWV45UBkC+Upx5XL3PAvGROvH CsXEucBbusCtnP0=; b=Qh8aFDtTYLdyWF+Gnt6+zQ9YyI69LxH6w+GokqsfG5xk kqTwB18D3XM5n26ONAAZePkNCdV+h4CBD8YoyvtGejqg2hS0kZMUEWiwrjIOblA5 4TEzvj8ijL6PEUBEsNZw0q5tBuWR9H7jcu7Yk1IUVTrY6hjk5gC4a51M13V/74mj 3CBZ1J6XFMRuRbswn1SI2Hhd9lW+JDP5R9oGYPLIOtN6oAVymtouaFjl0La1jrnG I7hA6FO3VGylZO9pMVwyN6NIztJ28D4ydEo4+r5nxGWoYYSDaRwAHf0alW7bLHUl 94NGshuQ1eeZgG0w8Mx3prCKkXTHXhiPxquf4pVdGw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedugddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A00EDB60086; Sun, 18 Dec 2022 12:56:43 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <60290159-8d63-4358-9ff1-a65cc335e0c6@app.fastmail.com> In-Reply-To: <20221218142231.qhczawk2zhpgh6dl@mobilestation> References: <20221215165247.1723462-1-arnd@kernel.org> <20221218142231.qhczawk2zhpgh6dl@mobilestation> Date: Sun, 18 Dec 2022 18:56:24 +0100 From: "Arnd Bergmann" To: "Serge Semin" , "Arnd Bergmann" Cc: "Mark Brown" , "Serge Semin" , "Ramil Zaripov" , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: dw_bt1: fix MUX_MMIO dependencies Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 18, 2022, at 15:22, Serge Semin wrote: > Hi Arnd > > On Thu, Dec 15, 2022 at 05:52:34PM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Selecting a symbol with additional dependencies requires >> adding the same dependency here: >> >> WARNING: unmet direct dependencies detected for MUX_MMIO >> Depends on [n]: MULTIPLEXER [=y] && OF [=n] >> Selected by [y]: >> - SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y]) >> >> Alternatively, we could drop this 'select' and require users to manually >> put it into their .config as we do for other drivers. > > Thanks for the patch. Seeing the driver is only implicitly dependent > from the mux-mmio driver (via the device described in the device tree > blob) I'd suggest to either drop the MUX_MMIO config reverse > dependency or convert it to the weak one - 'imply' (if it will solve > the problem). Ok, I'll send a new patch. I don't want to use 'imply' though, that tends to cause other problems because almost nobody understands what it actually does. Arnd