From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029E63290BD for ; Fri, 12 Jun 2026 02:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781232731; cv=none; b=rXKvsn3rqH/s0UOtTDlkfpNo6FIwu49Sb+ozDry9xCAAY5TmExXJ3y6Aj2Xh8Dyyz58ZeTS6kJW/DB46zOW6eUVNfYINEB0/4fN4NkENrcXPRZBPjSCplMsZqMvKQFc5b3r7ye3oadipN3mIjvcWjW1vMe4A8oivz8IcxmBVymo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781232731; c=relaxed/simple; bh=AZBmiFwEYN8MILgwH+elWqScj1FxDbcgZ4kVT/EpJ/o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S867t46MTAgvQvWeCPzvGJpmLFO9CL0V3rv8rk//gCH0t/RiIEscmIlrJGzGoqqv+puaQ5eHM4lxX0/3JxTMwAjewxdMuUh6WaZZr/QaAOTwRPoazT3jW+y6EotRjahtBiB4eoOTaPE3lYqzImUcP/RaWZPHh3WzxSF3Ru7bBVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IjD2lmjN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OPTRAg2D; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IjD2lmjN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OPTRAg2D" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BMSgk8352048 for ; Fri, 12 Jun 2026 02:52:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fcNplGJ1Sabq2Y9bKw3Y1rXhSqvMVBj3TrS26bNA4I4=; b=IjD2lmjNZmmDXdv+ p4QquYHJ/ZNFRBtM0g9IbixMcmiJdhV00hJe66eVTyBhFhluUynHrHy8WfUIFMID KTIQK3k0Rw0ZhddiNBOPmLOAl/Paf9K4VXIr5sisYVhDcj039Yq5zUzf8Dgo3RAD ELdEHLfNrXETVaSs3kSzRpWAehVGzY9jpFKOphRyTbh5so8EZrqOZUdt/82CEeQt /dfQH2EkWJw4lu4vr8Ozk70I18S3Ggdf0XsQL5R6iqgLIpgaGG+AAlu6CQqeCNh0 lFBFNIv/z9JxT9G/AuexlRQtn/cMTXaQyS6D61N3IjsKvdCSDkPCvY3G+jcG3pLw vox9DA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er014jbsd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 02:52:09 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8423f24dcedso645764b3a.1 for ; Thu, 11 Jun 2026 19:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781232728; x=1781837528; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fcNplGJ1Sabq2Y9bKw3Y1rXhSqvMVBj3TrS26bNA4I4=; b=OPTRAg2DiioA+HJQ6SsyvnS+fUqjiM53F28cOC9PdwZ7ZclbB1ZYx4cAhFdo1DAkpr ZCicJ4SgaY+7CETiljJCC/iwg33RZmjJjfWNSTXfD9/mJQnqZ42qX3TPHDt76C4WCrj1 5IOKwXY54wzabGEfczw8YtQsvhTOBl2WRj4U6aq+n/Q3KwlKrR+CtWYSCgv2gpGF4bQv X/Qm3nUsK7Nul126OmB40y3tO7Gb0GPZiHXTYEcsfh19D1v5O4e3jtusqFlQdgZS7oxF bP6YoV9IkLdSz6Ae0rCtkLvqKndlOXT09Q2WwuUMwfsFaBmkL5dy2tJJQvF5PvM1VSCq NaCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781232728; x=1781837528; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fcNplGJ1Sabq2Y9bKw3Y1rXhSqvMVBj3TrS26bNA4I4=; b=s3uwednFhZaMBzKsH9771KHNvhgVBir0CQQwl7e0JPgA0bDkCr6DwFXnhQIRA2Uamz rZ7J7k6sFz13lCFPM0b6YZiPxwM4L+4iNhb/lxAqHld0TufX10ImPER3m5pbkWl2xCUu OLIt3ITOQae3NlHGb474X+neW8GE3CS+dxJTlFC3oIhNn1t0gXBrDhTb3fxJtxA2Jt9x Tqw8YQPUGZK3JdnDMDDxcbY53adkg+xNelHF+ORIPjr61QwH+9Egl109qfPl/QYqNNOg Y4LNoMx/j+vsqvQvQwwZ50+svDwlY9B1ASevN6zBEXbPPQOCpLG0Jf3W1vBodnUU5KjT Puxw== X-Forwarded-Encrypted: i=1; AFNElJ+1YizUZQLkMSxRL6zcd2sUtsQXNdD8rDyrSXoM/KtYdptIoq+3v+urtUwHq10YAJ8rwdy3JS8ezdLvsNE=@vger.kernel.org X-Gm-Message-State: AOJu0YwlOV0DWGaiaGDWHtjJaEocfT0fF4CAsCcAcszFsmTIMnN+ouVO O0CpQZ5n0xmCM72VaNWlqnuQXao/2Ia5HE/qVaNkOgQM7Aa0PNL5Zqwi1qlald3/M4NUsFXwbX2 j3ZmsTkkzPGKOXIFQK973/HG3r13CAQjIoBmspabyw/uKBbUZosEGI7LDPU9X+PyV8Uw= X-Gm-Gg: Acq92OGafsGAYHAT9f+MRJ9bnFsH01zHaNK+cR65bwh7cpiZVSHxqKfynXVy2W5sBVf 1klZtJiyOrw0qAggjzPBNgKWJihDUPMgwJdVIB3LmgfyqJwwbhxOwGVeq1BFboEJrCBVTzCTZb/ VwAnmbnNJfae8LkvQLfHUVdtnvHPD97SerwtOc/wkQw/1DZtjcG3z/9WRO/53YsSh2OdB0guPXt /FG8OgT9AWonK0sG2cy5LG0nkZ2jY71F5MwoZ0iwoSFEDTiRAHxeTorKqpNW84WxuYhm4m47Kg+ YnNWWmbI8zvse2Dk6nGmM6D44WBL6cMCTcZvmi64cjkGIX65S/+YqidTaO4IZ3nkNxIbAzDL3u6 l7K6Gt9pbJWGvGYFZ7cxtu73niDapqZLJ57mD9uIGZOvfJm84H5k1d/ZHqxjQwqA= X-Received: by 2002:a05:6a00:4c1b:b0:82f:3a1e:5618 with SMTP id d2e1a72fcca58-8434ce4377dmr875960b3a.22.1781232728603; Thu, 11 Jun 2026 19:52:08 -0700 (PDT) X-Received: by 2002:a05:6a00:4c1b:b0:82f:3a1e:5618 with SMTP id d2e1a72fcca58-8434ce4377dmr875916b3a.22.1781232728108; Thu, 11 Jun 2026 19:52:08 -0700 (PDT) Received: from [192.168.1.8] ([122.164.81.0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b0226acsm511841b3a.48.2026.06.11.19.52.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 19:52:07 -0700 (PDT) Message-ID: <602e893c-d346-486d-86b3-50d0f01990bf@oss.qualcomm.com> Date: Fri, 12 Jun 2026 08:22:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add IPQ9650 PCIe PHY support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260602-ipq9650_pcie_phy-v1-0-d8c32a36dbd9@oss.qualcomm.com> <20260602-ipq9650_pcie_phy-v1-2-d8c32a36dbd9@oss.qualcomm.com> <56zkq7bwrt5smmmum6jckzrekkkqrych2gntx3obnrmamwumtv@espahwe6pc3v> <7def2ccd-0319-4f85-8275-73fd254d887d@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 06WCZy-skFnu7U5Zw5SdQrHsOcBxd7PJ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDAyNCBTYWx0ZWRfX1v6yI1HKieIS rH67K28kO1231bt9RVa6ZdRvAb3+X0t9YriTR3cVoRzGwkiJc4VaMoDzq3snRmLuMmV8u+9b050 MrTzCCZX5Z4wvo++Lb/+HQSzZ/BAN7A= X-Authority-Analysis: v=2.4 cv=Qp9uG1yd c=1 sm=1 tr=0 ts=6a2b7459 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=DVNErGSwdtF8OHn2hLoakQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=DXo_hcG_KxK6dTS-Z9kA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDAyNCBTYWx0ZWRfX6oAmxg4mGWO0 pCRmwqVdUg0HQJxG4YUU/qYdnHNMkbQ8L6yxeCNLXYY4AjcjPAn1wmisAWHphE+siscRChq6t5i S44QtHp8eT+OPX8zaIFkyHmiDqNWI5I5e55rMhGRa8nfB7RkPBmoQZCchSEKXp/APcEtGtb4xIU IUa9Lbtdjr5mc2Jtpj3vyfrzXQ6FQEQly4CkXPgdsh363Ty6esO6EdKMgVH4lnrvUOLWAcfUlRp B37KAgetY1zczjbVCt8fwaScPUTecZJ94ONBgAE+qi7x5/ANezU5k1lf8U6PdGqXbTw0rKoVBwr cy1ZTqbUjJefuXgesAcZo790fDyyibbN6ru/QS970yivtHzSP/O7Gmg+0RfBCuVxMSHzUSeeIbQ //ipQ7sxX5kgVLbxRz+t+6bWIo+9ezvIUfRv0T84IqiFbFMtOtH45kqJ7U4qb5DjJm9rZwsKaeX OSL2dr69Aws0Xsllk8A== X-Proofpoint-ORIG-GUID: 06WCZy-skFnu7U5Zw5SdQrHsOcBxd7PJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_05,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120024 On 6/12/2026 1:52 AM, Dmitry Baryshkov wrote: > On Tue, Jun 09, 2026 at 03:46:56PM +0530, Kathiravan Thirumoorthy wrote: >> On 6/8/2026 12:26 PM, Dmitry Baryshkov wrote: >>> On Tue, Jun 02, 2026 at 02:40:18PM +0530, Kathiravan Thirumoorthy wrote: >>>> The IPQ9650 platform has three Gen3 2-lane PCIe controllers and two Gen3 >>>> 1-lane PCIe controllers. The PHY instances also require the on-chip refgen >>>> supply. >>>> >>>> Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations, including the >>>> refgen regulator supply. >>>> >>>> Signed-off-by: Kathiravan Thirumoorthy >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 220 +++++++++++++++++++++++++++++++ >>>> 1 file changed, 220 insertions(+) >>>> >>>> @@ -3378,6 +3524,10 @@ static const char * const qmp_phy_vreg_l[] = { >>>> "vdda-phy", "vdda-pll", >>>> }; >>>> +static const char * const ipq9650_qmp_phy_vreg_l[] = { >>>> + "refgen", >>>> +}; >>> Now vdda-phy / vdda-pll supplies? >> Cross checked with HW team again. Along with refgen, there is a on-chip LDO >> which supplies fixed voltage to the PHYs. It is enabled upon system power on >> and no SW intervention is required. > What is it being powered by? MX? CX? It is driven by CX. >> regulator-fixed doesn't take the resource 'reg'. May be should I create >> another regulator driver which accepts 'reg', something similar to the >> qcom-refgen-regulator? Please advise. > If it doesn't require control, there is no need for a separate driver or > separate supply. For example, the refgen is being references only by > those devices which require software votes. Thanks. Then let me respin this series on top of phy-next so that Vinod can pick it up. > >>>> + >>>> static const char * const sm8550_qmp_phy_vreg_l[] = { >>>> "vdda-phy", "vdda-pll", "vdda-qref", >>>> };