From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932774AbcLBIrw (ORCPT ); Fri, 2 Dec 2016 03:47:52 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:52151 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753396AbcLBIru (ORCPT ); Fri, 2 Dec 2016 03:47:50 -0500 Subject: Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks To: Johan Hovold , "David S. Miller" References: <1480516195-27696-1-git-send-email-johan@kernel.org> CC: Alexandre Torgue , Joachim Eastwood , Carlo Caione , Kevin Hilman , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai , , From: Giuseppe CAVALLARO Message-ID: <6036ada6-71f7-61f5-be52-629940a097cd@st.com> Date: Fri, 2 Dec 2016 09:46:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1480516195-27696-1-git-send-email-johan@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2016 3:29 PM, Johan Hovold wrote: > This series fixes a number of issues with the stmmac-driver probe error > handling, which for example left clocks enabled after probe failures. > > The final patch fixes a failure to deregister and free any fixed-link > PHYs that were registered during probe on probe errors and on driver > unbind. It also fixes a related of-node leak on late probe errors. > > This series depends on the of_phy_deregister_fixed_link() helper that > was just merged to net. > > As mentioned earlier, one staging driver also suffers from a similar > leak and can be fixed up once the above mentioned helper hits mainline. > > Note that these patches have only been compile tested. For common and STi part: Acked-by: Giuseppe Cavallaro thx peppe > > Johan > > > Johan Hovold (7): > net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe > errors > net: ethernet: stmmac: dwmac-sti: fix probe error path > net: ethernet: stmmac: dwmac-rk: fix probe error path > net: ethernet: stmmac: dwmac-generic: fix probe error path > net: ethernet: stmmac: dwmac-meson8b: fix probe error path > net: ethernet: stmmac: platform: fix outdated function header > net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks > > .../net/ethernet/stmicro/stmmac/dwmac-generic.c | 17 ++++++++-- > .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 25 ++++++++++---- > .../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 17 ++++++++-- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 23 ++++++++++--- > .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 32 +++++++++++++----- > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 21 +++++++++--- > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 39 ++++++++++++++-------- > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 23 ++++++++++--- > drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 19 ++++++++--- > drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 26 +++++++++++---- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 - > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 33 +++++++++++++++--- > .../net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 ++ > 13 files changed, 215 insertions(+), 63 deletions(-) >