From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BD0B36E49F for ; Mon, 30 Mar 2026 20:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903899; cv=none; b=PTUxtzhET/bPzH6wIwxyX3pjM7TfcBFApsrRQsIvPOZbFnnrbPZdiRuqMO66Pf7jZVA4iNYt57qkFG3MJBqdHV7ylSGKO4hgMNsoIVOiT40ipQXQgxfKbhlsw/8o9DzyN/Nm/6+agL/ttQh27wQTn0mk94MrOoOm0zYnMSxSR8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903899; c=relaxed/simple; bh=swKIgGm8KEVzBXix73OUwXQs2/RvHPlBow9bNaLhMzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OkHyEC5z5510XwDzIGNJ2GcUpv7uv1VoIFIN/Jl+yPK1sF0AJJVCHaFTIrVb/AKdSDM5gM2yJiTp2kiKeksab7P2gE/FpHuOMFpRHrhTvGPc0D+KKEWr/3kvYQpbASpCefNXd6N4wpP08p0DLKgzWcZqHrIBacpSgusVTVFaWlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H0YVxLlI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ytl8xXj7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H0YVxLlI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ytl8xXj7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UFtonX3173909 for ; Mon, 30 Mar 2026 20:51:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sfLWO/i4ybjt5OEVNLgyO1zG5HeDMlwhQfu+dIrpgQs=; b=H0YVxLlIZhalDLI7 +PVzCeglPvO08oei1dttOUwMVHZ/xsbwosto09vS5VFZTGsb0n7u7nYBvh3uWbWn cyGCGxLuHaPaq8L9a7koNh0bRvI+s2fwscx36UfXqVGQ8v6626ktcv8VIJAqWa68 JMlN6f/zNxeHZuUCb+bUTNAlVXZnyIdM/nl2gEEQY9Dh5cTZV7MISMAs8M6yVovP AiXbJzJnkuQj9WPi+mI8nm6ZHWB5HPanAKmGTGEHdb6qVpT0iNqm2d3smB62fNpg zb5wzlJhosFaeBPYJcK6mzV/3RjSTd64D+065sDtZZux0uveqPmKZjw0icLp38WQ O51nhQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7q9h2dbr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 20:51:36 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b24e9b4d82so22103525ad.1 for ; Mon, 30 Mar 2026 13:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774903895; x=1775508695; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sfLWO/i4ybjt5OEVNLgyO1zG5HeDMlwhQfu+dIrpgQs=; b=Ytl8xXj7os0JU2zIevSrfF4pkAZc4Q8M8B3y8sNbaybq2+tgmlFlXGLufTmhTms750 XIs0LDU4tfq0es9k7TQI+6AWDVkeXP1EBG8teVtqUQObYF+IYs2QWu4KAHSbs5r4znDV w7IInMNDOb1h4vPHFXgfubc8k3Yt7NzXtbHBvCUSnXAAKqkroLTgO8+RuZqQC3iXyR/Z X/x3DiVKtYcH7Ieasv7VtAa9yNXXFsh0heE8Y+pjQ+eHmikPaqv0i6K8tKbNMBOcz3Lr 2hOIelTS4ceLXnk9BTNwN4Po7eUb22UQqFivimerzE1vssy07mYDALhHG8KBR21Tr62l MN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774903895; x=1775508695; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sfLWO/i4ybjt5OEVNLgyO1zG5HeDMlwhQfu+dIrpgQs=; b=H+N/1Z9u4qTW9ayH/bTenh0rjJp9gbNGqzy1qeLM7TVjO4/EO+gtRaiImH3TB0EXTt rp0a3c/mkRvrObK3NAF3FgbZLQqO8rVfE7MeECOnZbhOfYcy3/IHVF2wbwsrWt4SIExl tyHIub0uakBeJH+Dcj+v16z81+T0DMm5MCtfc4MiLs/lNg7tCGe0qDgGgh/G3gRVfUw0 cEXJc5yK1Inb88Nb4S8zoHW9vypfIAGa2nuhml23qmoQ/SlEBQ+hHZBaoDsNUnhfn9Du eb4gQKLt8JpwwTbktflqXvV8UNmnE/VeuF+DEj2+KwIrdE9bFKouRkumz+OovYys0354 1QjA== X-Forwarded-Encrypted: i=1; AJvYcCVgQ312vfoJLYunuwFB2C4NKDKBJ+waEsb2o0nwpJtwX8d26VDzmGtLYRbKS57iDEHlyZEHA6wssX9ZpMU=@vger.kernel.org X-Gm-Message-State: AOJu0YxAAzenAASHUOe+S9WFyAjYdZOQhfVf5U0I3XFr+G0KZ5r9LwqM WlUrTwVXNz1x22c2u8KFPdUE9B9hmyDvEYs3whLAV8wT//EAwJ7fgXoGj1FHjsrnQop1ws+jgo6 JcspoiLb+V6q3Adpc8qR7biEzLduldHXZoJtpHA6hUnoSZNNUoatfdrA7LWhlfYYTXs4= X-Gm-Gg: ATEYQzxMZ2K7y4g4OcK22ZrtcS6rs7imE39jde0VmadM2Ls6ZVQViWmJs2tdsDN6rp5 4vgm9zFzAgDwhs8TncGuumLDJc9ATdDEm9s2ygCVymsHOLfBKzcdnUefSP6C9BH0xHwZFpDYvZI hVlzZ8SzWTWQI1c0zA9uTKxBK5Lv0aPqAEJCJJCpjJXp4JqnfEhHrZJSUu3aILhJq6PjSBbnKHl aHNZvzYLPOZAEWG1vNjGKVkXNJ0xgnx0r6owK2e/5WVCHmH8BAczekFZzgIkU27hMx68+HIMDgp M1l4zIY/H7SrcMGBFqaMC+LzeGQ9zCk/fvluZN8WNnb9Xh1UP63b9bSyJomqoYeoFNIfw+wSekc /6fiH3cKSoMq1/WIZwnYeep87p9mMxoo8SoeVrzuiTM8V X-Received: by 2002:a17:903:1a2e:b0:2b2:3eec:c75b with SMTP id d9443c01a7336-2b25ee90436mr7881135ad.2.1774903895454; Mon, 30 Mar 2026 13:51:35 -0700 (PDT) X-Received: by 2002:a17:903:1a2e:b0:2b2:3eec:c75b with SMTP id d9443c01a7336-2b25ee90436mr7880855ad.2.1774903894992; Mon, 30 Mar 2026 13:51:34 -0700 (PDT) Received: from [10.91.121.222] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24265a954sm92575545ad.18.2026.03.30.13.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 13:51:34 -0700 (PDT) Message-ID: <6037882e-3716-47f9-9303-b448ab8fed79@oss.qualcomm.com> Date: Tue, 31 Mar 2026 02:21:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/17] drm/msm/a6xx: Switch to preemption safe AO counter To: Konrad Dybcio , Rob Clark Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-3-2b53c38d2101@oss.qualcomm.com> <2ddea137-bff2-4576-94ed-4f3a48aed386@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <2ddea137-bff2-4576-94ed-4f3a48aed386@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDE3NiBTYWx0ZWRfXyDcMStSVCHf+ 07cDdvF7jSIWqWGwMD7FkCSbxD8LDVMMEHfTUh2Wj4c4T7gP4ofLzGm/8hCpxg+vnVJ9CjrkUvq 0hfq9yQapnNIony9RQSJDVirA8ufYaB6e/eCPq/Q5R894r7NupfchzeksWZR7mVNgfduJep+spF nnnEmhUkxC8l5m/7NpTPGlXlvmsAXIr5icPzbJlxT1S6o8Ji/8cYUEhSqeZr2lSADxDJHFa1N2O cxVD0YCveiSt//0bkj5hH0LQJFZa4csWvHpdx6UbhoY7Mk3EEWHTOUhpyvj1P1MxhxBYznTqoxv qc9fRj5zhS5sq/dR9j1DAFsWSeUInyxS7RYcM4GPehx+pxX+QDlqh2DZ3w3LbHRj7L+mvUBXTfP 8sKz5nLXfcyK0W7+yfQDw4cGxlQx2ZJg/jAIftmmfv0qUSoGtvFUdh4ZuEP1A2g6iDDAPLtkzfb osgAMuIWdNJOeKRHszA== X-Authority-Analysis: v=2.4 cv=AZS83nXG c=1 sm=1 tr=0 ts=69cae258 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Y7Gn0S8KdB2wQIMvTzwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: O6lHev2bUO1eoVomZjPdU9qRW4rb7Zje X-Proofpoint-ORIG-GUID: O6lHev2bUO1eoVomZjPdU9qRW4rb7Zje X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-30_01,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300176 On 3/27/2026 5:02 PM, Konrad Dybcio wrote: > On 3/27/26 1:13 AM, Akhil P Oommen wrote: >> CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't >> provide accurate data about the 'submit' when preemption is enabled. >> Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. >> >> Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") >> Signed-off-by: Akhil P Oommen >> --- > > (this is not a blocking comment) > > would the _COUNTER counter be useful to keep for any other purpose? That is actually a good question. I was fixated on the fdinfo aspect that I missed that this is used in the submit_retire trace too. In the trace, I think it is preferable to use the _COUNTER (or keep both) so that we can visualize the order in which GPU processed the submits. Rob, what do you think? If required we can drop this patch from this series. Or I can send a fix up as this affect only the ftrace. -Akhil. > > Konrad