From: Joe Perches <joe@perches.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "MPT-FusionLinux.pdl@broadcom.com"
<MPT-FusionLinux.pdl@broadcom.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding
Date: Tue, 12 Jan 2021 09:46:10 -0800 [thread overview]
Message-ID: <60398acb9f26e60e3c1d6ab9c2d8bab4a89f2a91.camel@perches.com> (raw)
In-Reply-To: <DM5PR0401MB3591D23001DAC0AFB4F11D589BAA0@DM5PR0401MB3591.namprd04.prod.outlook.com>
On Tue, 2021-01-12 at 17:40 +0000, Johannes Thumshirn wrote:
> On 12/01/2021 18:38, Joe Perches wrote:
> > static void
> > _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
> > {
> > + const char *b = NULL; /* brand */
> > + const char *v = NULL; /* vendor */
>
> Any reason you didn't spell out brand and vendor as the variable names?
80 column lines.
prev parent reply other threads:[~2021-01-12 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:36 Joe Perches
2021-01-12 17:40 ` Johannes Thumshirn
2021-01-12 17:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60398acb9f26e60e3c1d6ab9c2d8bab4a89f2a91.camel@perches.com \
--to=joe@perches.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®