mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <gaoxiang25@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chao Yu <yuchao0@huawei.com>, Ming Lei <ming.lei@redhat.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	<devel@driverdev.osuosl.org>, <linux-erofs@lists.ozlabs.org>,
	Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	<weidu.du@huawei.com>, Fang Wei <fangwei1@huawei.com>,
	Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH v2] staging: erofs: fix unexpected out-of-bound data access
Date: Fri, 12 Apr 2019 22:38:09 +0800	[thread overview]
Message-ID: <603ee7f3-aba4-de45-9bf3-8fe70fa2c638@huawei.com> (raw)
In-Reply-To: <20190412135145.GK6095@kadam>



On 2019/4/12 21:51, Dan Carpenter wrote:
> On Fri, Apr 12, 2019 at 05:53:14PM +0800, Gao Xiang wrote:
>> Unexpected out-of-bound data will be read in erofs_read_raw_page
>> after commit 07173c3ec276 ("block: enable multipage bvecs") since
>> one iovec could have multiple pages.
>>
>> Let's fix as what Ming's pointed out in the previous email [1].
>>
>> [1] https://lore.kernel.org/lkml/20190411080953.GE421@ming.t460p/
>>
> 
> Please also use the Fixes tag.
> 
> Fixes: 07173c3ec276 ("block: enable multipage bvecs")

Thanks for reminder. Maybe Greg could add this line...

Thanks,
Gao Xiang

> 
>> Suggested-by: Ming Lei <ming.lei@redhat.com>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> 
> regards,
> dan carpenter
> 

      reply	other threads:[~2019-04-12 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  9:53 Gao Xiang
2019-04-12 13:51 ` Dan Carpenter
2019-04-12 14:38   ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603ee7f3-aba4-de45-9bf3-8fe70fa2c638@huawei.com \
    --to=gaoxiang25@huawei.com \
    --cc=chao@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fangwei1@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=ming.lei@redhat.com \
    --cc=weidu.du@huawei.com \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®