From: Andrew Lunn <andrew@lunn.ch>
To: Luke Howard <lukeh@padl.com>
Cc: "Cedric Jehasse" <cedric.jehasse@gmail.com>,
cedric.jehasse@luminex.be, "Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: add support for credit based shaper
Date: Fri, 29 May 2026 15:28:56 +0200 [thread overview]
Message-ID: <6040cfca-0af7-41cf-b7d0-00bd8be837bb@lunn.ch> (raw)
In-Reply-To: <793226E0-82B1-464E-9A18-969F773B70D4@padl.com>
> > That's not the same logic.
> > If one of the two function pointer is NULL, the other can still be executed
> > (Maybe not that likely as that's probably a mistake in the driver)
>
> True, but agree also that it shouldn’t happen (would be a driver bug).
However, a kernel splat because you have jumped through a NULL pointer
makes a good bug report. It is much more obvious what is wrong than a
report that somebody tried to configure TC, but nothing appeared to
happen.
Andrew
next prev parent reply other threads:[~2026-05-29 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 16:09 [PATCH net-next v4 0/2] " Cedric Jehasse via B4 Relay
2026-05-28 16:09 ` [PATCH net-next v4 1/2] net: dsa: mv88e6xxx: use the hw tx queues Cedric Jehasse via B4 Relay
2026-05-28 16:09 ` [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-28 23:48 ` Luke Howard
2026-05-29 12:32 ` Cedric Jehasse
2026-05-29 12:45 ` Luke Howard
2026-05-29 13:28 ` Andrew Lunn [this message]
2026-05-29 14:32 ` Cedric Jehasse
2026-05-29 14:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6040cfca-0af7-41cf-b7d0-00bd8be837bb@lunn.ch \
--to=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukeh@padl.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®