From: Jocelyn Falempe <jfalempe@redhat.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Helge Deller <deller@gmx.de>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Javier Martinez Canillas <javierm@redhat.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/panic: Add drm_panic_is_enabled()
Date: Thu, 18 Jul 2024 11:30:05 +0200 [thread overview]
Message-ID: <60419d31-f467-4277-97da-23c9573af2bf@redhat.com> (raw)
In-Reply-To: <34305c58-38a6-4b5a-9777-69833aefa003@redhat.com>
On 18/07/2024 09:04, Jocelyn Falempe wrote:
>
>
> On 17/07/2024 17:08, Daniel Vetter wrote:
>> On Wed, Jul 17, 2024 at 10:48:39AM +0200, Jocelyn Falempe wrote:
>>> It allows to check if the drm device supports drm_panic.
>>> Prepare the work to have better integration with fbcon and vtconsole.
>>>
>>> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
>>> ---
>>> drivers/gpu/drm/drm_panic.c | 20 ++++++++++++++++++++
>>> include/drm/drm_panic.h | 2 ++
>>> 2 files changed, 22 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c
>>> index 948aed00595e..d9a25c2d0a65 100644
>>> --- a/drivers/gpu/drm/drm_panic.c
>>> +++ b/drivers/gpu/drm/drm_panic.c
>>> @@ -703,6 +703,26 @@ static void debugfs_register_plane(struct
>>> drm_plane *plane, int index)
>>> static void debugfs_register_plane(struct drm_plane *plane, int
>>> index) {}
>>> #endif /* CONFIG_DRM_PANIC_DEBUG */
>>> +/**
>>> + * drm_panic_is_enabled
>>> + * @dev: the drm device that may supports drm_panic
>>> + *
>>> + * returns true if the drm device supports drm_panic
>>> + */
>>> +bool drm_panic_is_enabled(struct drm_device *dev)
>>> +{
>>> + struct drm_plane *plane;
>>> +
>>> + if (!dev->mode_config.num_total_plane)
>>> + return false;
>>> +
>>> + drm_for_each_plane(plane, dev)
>>> + if (plane->helper_private &&
>>> plane->helper_private->get_scanout_buffer)
>>> + return true;
>>> + return false;
>>> +}
>>> +EXPORT_SYMBOL(drm_panic_is_enabled);
>>
>> This feels like overkill since you currently only have one user in the
>> fbdev emulation code, but maybe useful in some other places ...
>>
>>> +
>>> /**
>>> * drm_panic_register() - Initialize DRM panic for a device
>>> * @dev: the drm device on which the panic screen will be displayed.
>>> diff --git a/include/drm/drm_panic.h b/include/drm/drm_panic.h
>>> index 73bb3f3d9ed9..c3a358dc3e27 100644
>>> --- a/include/drm/drm_panic.h
>>> +++ b/include/drm/drm_panic.h
>>> @@ -148,11 +148,13 @@ struct drm_scanout_buffer {
>>> #ifdef CONFIG_DRM_PANIC
>>> +bool drm_panic_is_enabled(struct drm_device *dev);
>>
>> Since it's internal only, this should be in
>> drivers/gpu/drm/drm_crtc_internal.h and not int he include for drivers.
>
> Yes, that makes sense, drivers won't need that API.
>
>> With that:
>>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>>> void drm_panic_register(struct drm_device *dev);
>>> void drm_panic_unregister(struct drm_device *dev);
>>
>> These two are only used in drm.ko. Can you please move them to
>> drm_crtc_internal.h too and drop the EXPORT_SYMBOL in a follow-up patch?
>> We're trying to limit the exported interface and official headers to
>> really only the pieces drivers actually need.
>
> Sure, I'll add this to my next drm_panic series.
I think this also applies to drm_panic_init() and drm_panic_exit(), that
I introduce in my QR code series:
https://patchwork.freedesktop.org/patch/604890/?series=135944&rev=2
I will move them to drm_crtc_internal.h
>
>>
>> Thanks, Sima
>>
>>> #else
>>> +bool drm_panic_is_enabled(struct drm_device *dev) {return false; }
>>> static inline void drm_panic_register(struct drm_device *dev) {}
>>> static inline void drm_panic_unregister(struct drm_device *dev) {}
>>> --
>>> 2.45.2
>>>
>>
>
> Best regards,
>
next prev parent reply other threads:[~2024-07-18 9:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 8:48 [PATCH 0/3] drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE Jocelyn Falempe
2024-07-17 8:48 ` [PATCH 1/3] drm/panic: Add drm_panic_is_enabled() Jocelyn Falempe
2024-07-17 10:05 ` Javier Martinez Canillas
2024-07-17 15:08 ` Daniel Vetter
2024-07-18 7:04 ` Jocelyn Falempe
2024-07-18 9:30 ` Jocelyn Falempe [this message]
2024-07-22 14:12 ` Daniel Vetter
2024-07-19 10:18 ` Imre Deak
2024-07-17 8:48 ` [PATCH 2/3] fbcon: Add an option to disable fbcon in panic Jocelyn Falempe
2024-07-17 10:08 ` Javier Martinez Canillas
2024-07-17 15:04 ` Daniel Vetter
2024-07-18 7:06 ` Jocelyn Falempe
2024-07-17 8:48 ` [PATCH 3/3] drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE Jocelyn Falempe
2024-07-17 10:09 ` Javier Martinez Canillas
2024-07-17 15:09 ` Daniel Vetter
2024-07-19 9:48 ` [PATCH 0/3] " Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60419d31-f467-4277-97da-23c9573af2bf@redhat.com \
--to=jfalempe@redhat.com \
--cc=airlied@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®