From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754904AbcEXI7M (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 May 2016 04:59:12 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:57995 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753369AbcEXI7K (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 May 2016 04:59:10 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] hwrng: stm32 - fix build warning
Date: Tue, 24 May 2016 10:58:33 +0200
Message-ID: <6044541.yeLQbYg2Jv@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CALszF6BPPA=tezMLhmdC4YFwmH1tGhDxCNDZNwGp1cTDWP7Fmg@mail.gmail.com>
References: <1464007448-25395-1-git-send-email-sudipm.mukherjee@gmail.com> <12548318.auB4PSA3KC@wuerfel> <CALszF6BPPA=tezMLhmdC4YFwmH1tGhDxCNDZNwGp1cTDWP7Fmg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:mtNnwiA5Qn63NoW8OscjmzvU8Vif3lfIxK4a6xzT4lTWe0Lf4ZI
 D0YBphVS97U+RV/h3cKB/uwVM8ysqynHeTlwhL5uvI+g9lLYPqiGFKG7NMyPs9aYlwksr+U
 VdV1XrX36cXZOw/V6ty0ah4GqI4n719uHTMFZ/n8OLswmSKsur576yJ88mvxXmdu2wk0+Zq
 PYznM4nti6bbDwDHtcIjw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4hB7YHZHFSw=:np3Yea1PK4m+oXbBo98B7B
 DXIt5rbYq7bNR654vpPm/kZkdpcb6nY531bv7dwfN8p6gspRwyoHmNgZuht9fiX/cNsEMhfar
 24S2NZxLy/DkiC19e6ZWNbASaZqdO4R+SCGksy6ajn7IHux49Ceq2umNMCQvUtVsdZl5XLhWC
 dFp+VEjXKdQxbzTZD/cxA0hZRHOTBuuZDzTZ3Nky1Lo+KBl+o3QWx5Op3HUBf0kH7HTMQgN2B
 JXnYeAKC6bX8u+DgJkPUoZ7vQBUzsLRMBg9eF6+b0LLSC/2djbNb0kqduwAoA7sK9tWaJI/oc
 Z6deQjro1+AxtGgNkhMLGEExWjnrVR1o71UanPKGrkg892R31oxOlQJHeOHkQR+b7hxdXwLYc
 TuPqYG8LD7DNPhFj4m0ot69+6MbTzoF87XQ03rdymdsCXksCAwaQijKaxOSx5ZX88zwQQYyLo
 DE1Nk41lA6DGCk5q/FVrh+MVPC3HpQLbOn2OCD8Y1XL83L33fGVkVIepFZWcvaIBas57R6vM+
 e04VMbFfuQt+0dnTzUkzu+eCJkNPdOVKqGQtVlmUMXkjNml3RB26tiKkTQHC8fKAMQUjyvQ9e
 AQxsCxxMcIN0rF1u7UWtYmOyqsNSBYziemK1xTlh7JdqK3tzH2lZ/BushMUnEGKheXe6HMSwj
 b0J0OeCnWTY+fZEfNCGHvQl7hrO1Xrm9EuAYJs/+uAYZaZo1lb8lLpFug6/s2f9uqoiDjyovY
 qaZBjH41s0E8K1qO
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote:
> diff --git a/drivers/char/hw_random/stm32-rng.c
> b/drivers/char/hw_random/stm32-rng.c
> index 92a810648bd0..2a0fc90e4dc3 100644
> --- a/drivers/char/hw_random/stm32-rng.c
> +++ b/drivers/char/hw_random/stm32-rng.c
> @@ -68,6 +68,10 @@ static int stm32_rng_read(struct hwrng *rng, void
> *data, size_t max, bool wait)
>                         } while (!sr && --timeout);
>                 }
> 
> +               if (WARN_ONCE(sr & (RNG_SR_SEIS | RNG_SR_CEIS),
> +                               "bad RNG status - %x\n", sr))
> +                       writel_relaxed(0, priv->base + RNG_SR);
> +
>                 /* If error detected or data not ready... */
>                 if (sr != RNG_SR_DRDY)
>                         break;
> @@ -79,10 +83,6 @@ static int stm32_rng_read(struct hwrng *rng, void
> *data, size_t max, bool wait)
>                 max -= sizeof(u32);
>         }
> 
> -       if (WARN_ONCE(sr & (RNG_SR_SEIS | RNG_SR_CEIS),
> -                     "bad RNG status - %x\n", sr))
> -               writel_relaxed(0, priv->base + RNG_SR);
> -
>         pm_runtime_mark_last_busy((struct device *) priv->rng.priv);
>         pm_runtime_put_sync_autosuspend((struct device *) priv->rng.priv);
> 
> Thanks,
> 

Yes, that looks good to me.

	Arnd