From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752699AbbJNIUX (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 04:20:23 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:51426 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751421AbbJNIUR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 04:20:17 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Russell King <linux@arm.linux.org.uk>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Dinh Nguyen <dinguyen@opensource.altera.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, lftan.linux@gmail.com,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver
Date: Wed, 14 Oct 2015 10:20 +0200
Message-ID: <6044983.WR9BTgsOaA@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444790492-4051-4-git-send-email-lftan@altera.com>
References: <1444790492-4051-1-git-send-email-lftan@altera.com> <1444790492-4051-4-git-send-email-lftan@altera.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:PnWLEmVSOcfkf4nwK4alLgV0BsaNtOt6zBNoJTYi8OhMlqjsM9l
 ImN8Ab0U+SnREJcgd13r+dZ/5LeiXHmzb4HhKRsM+BN+UDkWTY3BcM7NPPICwpoN1PlfKsW
 92emxACI2cZlUjT6q279gl8nn2j/W9LHmuaI/BoJ9lNoXjVw1MptwaooS/pT0qcmTIi/mVp
 zu9OtaHoKCe1vR8HCNJ3A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:3BPFNj+FFmI=:8xJSjNIuq3dpvDg0+j/u0P
 VNfUv4ea3mQ/Dtsp/VE+5CFhkwETNj5Zd4LDRmmp1NGR2StAkB7u2fvd09NplwMjucDIvu2Cd
 Ug8zMcr6QPDQwtnthWp55qXFanH4d3eVqsENimd54hPaD/e5QhbcOVIfBj2kgJqKsfLqriXDb
 0J2udemSNgouaIMJOqsV4/Xlb8spG3cXboqosDfpcfaPjeSZelPZX+JCgqM8mnidQn7Tz8McP
 Yuf6edrRBGjm/fqU728jliy4QycL0B1DnXwZ8F3UCaby6CcL3DloTuq2xSt3ZgcQuCGNojGdM
 kqLZRV3Ey2b6K66kPP4Tkq9a8ltbHWTr8qtX0GzsZ+bGXxlXV1ZRLA8jnls6zm87wkrjAXP0Y
 Px8GI5tJlS6+fvLkEnJNdnzZucL7aFYMg6O7fAg4oR96eWCSOrxfZaRwz58GuuGw9BxvEyoVD
 cB1+KfC4UjGwi3wLGgjQdwMVYSEpR5bDJcPliy31QYRTGdSbbGhOWMap6D/sjsv2Vq2sg0wJP
 7/qI2V3f4epVky42Apk9RG0+P1A35F57XAw+0HBvgUCDBS/vlSrrQ0wInhZT+qiwotyM8+DJF
 N7brAqqypMiouxvitP7uOK311h/dxMJNln8Q5nID+ktYjVpfluN8mHh8sba3NCgtrbtdet0r/
 esSRqNJKEyP3xfHROpjy0IRCJoTaVLxJCeRnG2RIp5b6l0BodJM5aIKyrVx+tyZwNm+E49iLS
 T7ebqfK9zmJ7zEOA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote:
> +static int altera_pcie_remove(struct platform_device *pdev)
> +{
> +	struct altera_pcie *pcie = platform_get_drvdata(pdev);
> +
> +	altera_pcie_free_irq_domain(pcie);
> +	platform_set_drvdata(pdev, NULL);
> +	return 0;
> +}

I just noticed this. Does it actually work to unload the module
and tear down all the pci_dev structures in a safe way?

	Arnd