mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Alexandr Sapozhnikov <alsp705@gmail.com>,
	linux-rtc@vger.kernel.org, lvc-project@linuxtesting.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: fix error checking in wdt_disable()
Date: Fri, 3 Oct 2025 15:50:33 +0200	[thread overview]
Message-ID: <604731a2-c9d0-4326-8304-4a8c7f416bd4@web.de> (raw)
In-Reply-To: <20251002092456.11-1-alsp705@gmail.com>

> The i2c_transfer() function may return an error.
> Ignoring errors returned by functions is bad practice.

See also:
https://cwe.mitre.org/data/definitions/252.html


…
> If the second function call succeeds, data corruption will occur.

Should the function return values be checked for both passed messages?


* Would a corresponding imperative wording become helpful for an improved change description?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?


Regards,
Markus

      reply	other threads:[~2025-10-03 13:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  9:24 Alexandr Sapozhnkiov
2025-10-03 13:50 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=604731a2-c9d0-4326-8304-4a8c7f416bd4@web.de \
    --to=markus.elfring@web.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsp705@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®