From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F29DEB64DC for ; Sat, 1 Jul 2023 03:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbjGAD14 (ORCPT ); Fri, 30 Jun 2023 23:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjGAD10 (ORCPT ); Fri, 30 Jun 2023 23:27:26 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ABA2449F for ; Fri, 30 Jun 2023 19:57:43 -0700 (PDT) Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QtGxn4WbPztQTd; Sat, 1 Jul 2023 10:54:53 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 1 Jul 2023 10:57:40 +0800 Message-ID: <604775f0-fa72-0ec4-d911-5c113fef7de1@huawei.com> Date: Sat, 1 Jul 2023 10:57:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 0/2] mm: remove page_rmapping() Content-Language: en-US To: Matthew Wilcox CC: , , , , , References: <20230630121310.165700-1-zhangpeng362@huawei.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/1 5:39, Matthew Wilcox wrote: > On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote: >> From: ZhangPeng >> >> This minor patch series remove page_rmapping() and convert the last user >> fault_dirty_shared_page() to use a folio. > This patch series works better if you do it in the other order. > First convert the user, then remove the now-unused page_rmapping(). > > It's almost always a mistake to start with "I want to remove all the > users of API x". You should be thinking "Here is function y that still > uses pages; I shall convert it to use folios". Thanks for your feedback. I'll reverse the order of the two patches. Convert user first, then remove the now-unused page_rmapping(). Best Regards, Peng