From: Shuah Khan <skhan@linuxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
stable@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH] selftests: Fix: search kernel headers in $(KHDR_INCLUDES)
Date: Thu, 26 Jan 2023 15:54:27 -0700 [thread overview]
Message-ID: <604dc49a-fd03-4407-0e13-d16022ba81c4@linuxfoundation.org> (raw)
In-Reply-To: <20230117201724.11869-1-mathieu.desnoyers@efficios.com>
On 1/17/23 13:17, Mathieu Desnoyers wrote:
> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
> building against kernel headers from the build environment in scenarios
> where kernel headers are installed into a specific output directory
> (O=...).
>
The change looks good to me.
> [ Hopefully I did not break too many things with this selftests-wide
> change. Additional testing would be welcome before merging, especially
> given that whenever we get this wrong, it appears to fall-back on the
> build environment system headers, which hides issues. This applies on
> top of v6.2-rc3. ]
>
One concern with treewide change is the merge conflicts. Selftests
go through several trees as you may already know.
Would it be possible for you send patch series instead? Patch series
will help us avoid merge conflict issues.
I will run tests on this patch and let you know in the meatime.
thanks,
-- Shuah
prev parent reply other threads:[~2023-01-26 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 20:17 Mathieu Desnoyers
2023-01-26 22:54 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604dc49a-fd03-4407-0e13-d16022ba81c4@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®