From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6448A181334 for ; Fri, 13 Mar 2026 04:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773375760; cv=none; b=CGGUTuvmcCf8c4PV23amQWaDYT+5wFM9WKP/Dqw2XAzJ2BmdLuW3qfsg10ogl4J6OrCIVM5pOcb1uma0mQu13luok+aRaZVMW6a0WfaDcW7CrfXo+xnRHVLZ8/Vbia8e0vRD0qx0X6TjTVmoib6JAQcQNpPZbULkH0l3fc3wAUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773375760; c=relaxed/simple; bh=pcToh0Lxp0c4XZ7wUmRwEX+iA0WslvoNDojakt7w+Cc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hq+Enj3h2DflJwF4hxDz33ArprfyaJUaG9wrRGvCNTjG/QnoVqPH/xg1FRegRTOilBp4KRZ6z2Y/utgXJBldsS/agYPQMeTwFejDGHt4+Ez1aF2sebbAUn5MUWMcTz6Yhcu9OFJF/Ra9P6fxhpLnLXOzDwecMgFZLoC5KLWQ5VY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=CXR9aRj2; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CXR9aRj2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=wcqldhRqO3jBnLmkV6cEDn073YqeYg59rbLqYeyL5R4=; b=CXR9aRj2swOMQCwitK8Mfiq9xH 8Lu7vcfsXuH8r/yBzol6B/elg18Rqj657her3T3lhCvpcy+TulGvnrwH9hC24TBpc6kvkCMY1su/O bT1OU8rbV+EupsgcdF+/lDa2Lk4oyrqwvdEFey0T9PKen7ogQwdYl21Qh6btLVOGaCLXqrha2NLIE LRX7dO5/5LJ8JX8zIpkYFVsJM0xxCwGlJrtqLBdpkXLJqetAfvwAz7GAcrZ49zBtilbcaEjRIl5y7 zIZloPsbtz7XEtCsmcrMFIiFYIifctyscftqAjZDiAX+QmECW7JtkkAAVssOaHEPP/v3BrPwYtvpO mfJdkwew==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0u2i-0000000GUFM-2Bro; Fri, 13 Mar 2026 04:22:32 +0000 Message-ID: <604ed82b-afe7-467d-a6e2-98d15604ea9a@infradead.org> Date: Thu, 12 Mar 2026 21:22:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-tcp.h: correct kernel-doc comments To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org References: <20260312051431.684352-1-rdunlap@infradead.org> <20260312070354.GA27358@lst.de> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20260312070354.GA27358@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/12/26 12:03 AM, Christoph Hellwig wrote: > On Wed, Mar 11, 2026 at 10:14:31PM -0700, Randy Dunlap wrote: >> Mark reserved fields as "private:" so that kernel-doc comments are >> not required for them. > > I'm honestly not sure the kerneldoc makes any sense for an on-disk > structure that has an external specification. So insteada of these > hacks, what about just dropping the kerneldoc comment entirely? > Sure, I'll do that. Thanks. -- ~Randy