From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE76DC11D05 for ; Thu, 20 Feb 2020 12:43:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D01DB24670 for ; Thu, 20 Feb 2020 12:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgBTMnt (ORCPT ); Thu, 20 Feb 2020 07:43:49 -0500 Received: from mx2.cyber.ee ([193.40.6.72]:39981 "EHLO mx2.cyber.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727789AbgBTMnt (ORCPT ); Thu, 20 Feb 2020 07:43:49 -0500 Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c To: "Dr. David Alan Gilbert" Cc: linux-hwmon@vger.kernel.org, LKML , Chen Zhou References: <434212bb-4eb9-7366-3255-79826d0e65bc@linux.ee> <20200220121451.GA18071@gallifrey> From: Meelis Roos Message-ID: <6050ed14-f7a6-cb99-7268-072129226d48@linux.ee> Date: Thu, 20 Feb 2020 14:43:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200220121451.GA18071@gallifrey> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible > which has: > > if (attr == hwmon_temp_input || attr == hwmon_temp_label) > return 0444; > > to > if (attr == hwmon_temp_input) > return 0444; > if (attr == hwmon_temp_label) { > if (data->temp_label) > return 0444; > else > return 0; > } > > Does that work for you? Yes, it works - sensors are displayed as they should be, with nothing in dmesg. Thank you for so quick response! -- Meelis Roos