From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D492C2BB1D for ; Fri, 13 Mar 2020 16:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 377F5206BE for ; Fri, 13 Mar 2020 16:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XCp9VZGR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbgCMQi2 (ORCPT ); Fri, 13 Mar 2020 12:38:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53357 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726861AbgCMQi1 (ORCPT ); Fri, 13 Mar 2020 12:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584117506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LrJ9XowPy9aYY8HNGJzq1TnNm0SxtNZ6yvwC8KOmeCo=; b=XCp9VZGR2GqgavkGuEnWzhX4pZOrtkzW5L2Fh+BlkZVFNXoMIhjSBxz2qxHmFpSX/HRJ5a +kqHgBYXVc9Ke5r9ctfDoEQET4RANZibngRtRzGn4udrzIOKxK0P3Ngr6xiBwwSDeHHf8J 6MmUlI+BC+bWbPHYuesjmcNNw1VddIM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-NTSR0f0UPOuezzz409HNtg-1; Fri, 13 Mar 2020 12:38:21 -0400 X-MC-Unique: NTSR0f0UPOuezzz409HNtg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0228800D5A; Fri, 13 Mar 2020 16:38:19 +0000 (UTC) Received: from [10.10.121.252] (ovpn-121-252.rdu2.redhat.com [10.10.121.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7983660BEE; Fri, 13 Mar 2020 16:38:14 +0000 (UTC) Subject: Re: [Patch v2] KVM: x86: Initializing all kvm_lapic_irq fields in ioapic_write_indirect To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, pbonzini@redhat.com, peterx@redhat.com References: <1584105384-4864-1-git-send-email-nitesh@redhat.com> <871rpwpesg.fsf@vitty.brq.redhat.com> <29c41f43-a8c6-3d72-8647-d46782094524@redhat.com> <87v9n8mdn0.fsf@vitty.brq.redhat.com> <66c57868-52dd-94cc-e9ef-7bceb54a65e3@redhat.com> <87r1xwmct1.fsf@vitty.brq.redhat.com> From: Nitesh Narayan Lal Autocrypt: addr=nitesh@redhat.com; prefer-encrypt=mutual; keydata= mQINBFl4pQoBEADT/nXR2JOfsCjDgYmE2qonSGjkM1g8S6p9UWD+bf7YEAYYYzZsLtbilFTe z4nL4AV6VJmC7dBIlTi3Mj2eymD/2dkKP6UXlliWkq67feVg1KG+4UIp89lFW7v5Y8Muw3Fm uQbFvxyhN8n3tmhRe+ScWsndSBDxYOZgkbCSIfNPdZrHcnOLfA7xMJZeRCjqUpwhIjxQdFA7 n0s0KZ2cHIsemtBM8b2WXSQG9CjqAJHVkDhrBWKThDRF7k80oiJdEQlTEiVhaEDURXq+2XmG jpCnvRQDb28EJSsQlNEAzwzHMeplddfB0vCg9fRk/kOBMDBtGsTvNT9OYUZD+7jaf0gvBvBB lbKmmMMX7uJB+ejY7bnw6ePNrVPErWyfHzR5WYrIFUtgoR3LigKnw5apzc7UIV9G8uiIcZEn C+QJCK43jgnkPcSmwVPztcrkbC84g1K5v2Dxh9amXKLBA1/i+CAY8JWMTepsFohIFMXNLj+B RJoOcR4HGYXZ6CAJa3Glu3mCmYqHTOKwezJTAvmsCLd3W7WxOGF8BbBjVaPjcZfavOvkin0u DaFvhAmrzN6lL0msY17JCZo046z8oAqkyvEflFbC0S1R/POzehKrzQ1RFRD3/YzzlhmIowkM BpTqNBeHEzQAlIhQuyu1ugmQtfsYYq6FPmWMRfFPes/4JUU/PQARAQABtCVOaXRlc2ggTmFy YXlhbiBMYWwgPG5pbGFsQHJlZGhhdC5jb20+iQI9BBMBCAAnBQJZeKUKAhsjBQkJZgGABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEKOGQNwGMqM56lEP/A2KMs/pu0URcVk/kqVwcBhU SnvB8DP3lDWDnmVrAkFEOnPX7GTbactQ41wF/xwjwmEmTzLrMRZpkqz2y9mV0hWHjqoXbOCS 6RwK3ri5e2ThIPoGxFLt6TrMHgCRwm8YuOSJ97o+uohCTN8pmQ86KMUrDNwMqRkeTRW9wWIQ EdDqW44VwelnyPwcmWHBNNb1Kd8j3xKlHtnS45vc6WuoKxYRBTQOwI/5uFpDZtZ1a5kq9Ak/ MOPDDZpd84rqd+IvgMw5z4a5QlkvOTpScD21G3gjmtTEtyfahltyDK/5i8IaQC3YiXJCrqxE r7/4JMZeOYiKpE9iZMtS90t4wBgbVTqAGH1nE/ifZVAUcCtycD0f3egX9CHe45Ad4fsF3edQ ESa5tZAogiA4Hc/yQpnnf43a3aQ67XPOJXxS0Qptzu4vfF9h7kTKYWSrVesOU3QKYbjEAf95 NewF9FhAlYqYrwIwnuAZ8TdXVDYt7Z3z506//sf6zoRwYIDA8RDqFGRuPMXUsoUnf/KKPrtR ceLcSUP/JCNiYbf1/QtW8S6Ca/4qJFXQHp0knqJPGmwuFHsarSdpvZQ9qpxD3FnuPyo64S2N Dfq8TAeifNp2pAmPY2PAHQ3nOmKgMG8Gn5QiORvMUGzSz8Lo31LW58NdBKbh6bci5+t/HE0H pnyVf5xhNC/FuQINBFl4pQoBEACr+MgxWHUP76oNNYjRiNDhaIVtnPRqxiZ9v4H5FPxJy9UD Bqr54rifr1E+K+yYNPt/Po43vVL2cAyfyI/LVLlhiY4yH6T1n+Di/hSkkviCaf13gczuvgz4 KVYLwojU8+naJUsiCJw01MjO3pg9GQ+47HgsnRjCdNmmHiUQqksMIfd8k3reO9SUNlEmDDNB XuSzkHjE5y/R/6p8uXaVpiKPfHoULjNRWaFc3d2JGmxJpBdpYnajoz61m7XJlgwl/B5Ql/6B dHGaX3VHxOZsfRfugwYF9CkrPbyO5PK7yJ5vaiWre7aQ9bmCtXAomvF1q3/qRwZp77k6i9R3 tWfXjZDOQokw0u6d6DYJ0Vkfcwheg2i/Mf/epQl7Pf846G3PgSnyVK6cRwerBl5a68w7xqVU 4KgAh0DePjtDcbcXsKRT9D63cfyfrNE+ea4i0SVik6+N4nAj1HbzWHTk2KIxTsJXypibOKFX 2VykltxutR1sUfZBYMkfU4PogE7NjVEU7KtuCOSAkYzIWrZNEQrxYkxHLJsWruhSYNRsqVBy KvY6JAsq/i5yhVd5JKKU8wIOgSwC9P6mXYRgwPyfg15GZpnw+Fpey4bCDkT5fMOaCcS+vSU1 UaFmC4Ogzpe2BW2DOaPU5Ik99zUFNn6cRmOOXArrryjFlLT5oSOe4IposgWzdwARAQABiQIl BBgBCAAPBQJZeKUKAhsMBQkJZgGAAAoJEKOGQNwGMqM5ELoP/jj9d9gF1Al4+9bngUlYohYu 0sxyZo9IZ7Yb7cHuJzOMqfgoP4tydP4QCuyd9Q2OHHL5AL4VFNb8SvqAxxYSPuDJTI3JZwI7 d8JTPKwpulMSUaJE8ZH9n8A/+sdC3CAD4QafVBcCcbFe1jifHmQRdDrvHV9Es14QVAOTZhnJ vweENyHEIxkpLsyUUDuVypIo6y/Cws+EBCWt27BJi9GH/EOTB0wb+2ghCs/i3h8a+bi+bS7L FCCm/AxIqxRurh2UySn0P/2+2eZvneJ1/uTgfxnjeSlwQJ1BWzMAdAHQO1/lnbyZgEZEtUZJ x9d9ASekTtJjBMKJXAw7GbB2dAA/QmbA+Q+Xuamzm/1imigz6L6sOt2n/X/SSc33w8RJUyor SvAIoG/zU2Y76pKTgbpQqMDmkmNYFMLcAukpvC4ki3Sf086TdMgkjqtnpTkEElMSFJC8npXv 3QnGGOIfFug/qs8z03DLPBz9VYS26jiiN7QIJVpeeEdN/LKnaz5LO+h5kNAyj44qdF2T2AiF HxnZnxO5JNP5uISQH3FjxxGxJkdJ8jKzZV7aT37sC+Rp0o3KNc+GXTR+GSVq87Xfuhx0LRST NK9ZhT0+qkiN7npFLtNtbzwqaqceq3XhafmCiw8xrtzCnlB/C4SiBr/93Ip4kihXJ0EuHSLn VujM7c/b4pps Organization: Red Hat Inc, Message-ID: <6052eb34-3b70-35c1-2622-440bdfc43f16@redhat.com> Date: Fri, 13 Mar 2020 12:38:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87r1xwmct1.fsf@vitty.brq.redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fpb92n7WBK5nDiLAS3OKzwaHLlI0Mvg0u" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fpb92n7WBK5nDiLAS3OKzwaHLlI0Mvg0u Content-Type: multipart/mixed; boundary="oqbaniGLbbOr8DiXzb5gOEA3jk5TXgNn8" --oqbaniGLbbOr8DiXzb5gOEA3jk5TXgNn8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 3/13/20 12:36 PM, Vitaly Kuznetsov wrote: > Nitesh Narayan Lal writes: > >> On 3/13/20 12:18 PM, Vitaly Kuznetsov wrote: >>> Nitesh Narayan Lal writes: >>> >>>> On 3/13/20 9:38 AM, Nitesh Narayan Lal wrote: >>>>> On 3/13/20 9:25 AM, Vitaly Kuznetsov wrote: >>>>>> Nitesh Narayan Lal writes: >>>>>> >>>>>>> Previously all fields of structure kvm_lapic_irq were not initializ= ed >>>>>>> before it was passed to kvm_bitmap_or_dest_vcpus(). Which will caus= e >>>>>>> an issue when any of those fields are used for processing a request= . >>>>>>> For example not initializing the msi_redir_hint field before passin= g >>>>>>> to the kvm_bitmap_or_dest_vcpus(), may lead to a misbehavior of >>>>>>> kvm_apic_map_get_dest_lapic(). This will specifically happen when t= he >>>>>>> kvm_lowest_prio_delivery() returns TRUE due to a non-zero garbage >>>>>>> value of msi_redir_hint, which should not happen as the request bel= ongs >>>>>>> to APIC fixed delivery mode and we do not want to deliver the >>>>>>> interrupt only to the lowest priority candidate. >>>>>>> >>>>>>> This patch initializes all the fields of kvm_lapic_irq based on the >>>>>>> values of ioapic redirect_entry object before passing it on to >>>>>>> kvm_bitmap_or_dest_vcpus(). >>>>>>> >>>>>>> Fixes: 7ee30bc132c6("KVM: x86: deliver KVM IOAPIC scan request to t= arget vCPUs") >>>>>>> Signed-off-by: Nitesh Narayan Lal >>>>>>> --- >>>>>>> arch/x86/kvm/ioapic.c | 7 +++++-- >>>>>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/arch/x86/kvm/ioapic.c b/arch/x86/kvm/ioapic.c >>>>>>> index 7668fed..3a8467d 100644 >>>>>>> --- a/arch/x86/kvm/ioapic.c >>>>>>> +++ b/arch/x86/kvm/ioapic.c >>>>>>> @@ -378,12 +378,15 @@ static void ioapic_write_indirect(struct kvm_= ioapic *ioapic, u32 val) >>>>>>> =09=09if (e->fields.delivery_mode =3D=3D APIC_DM_FIXED) { >>>>>>> =09=09=09struct kvm_lapic_irq irq; >>>>>>> =20 >>>>>>> -=09=09=09irq.shorthand =3D APIC_DEST_NOSHORT; >>>>>>> =09=09=09irq.vector =3D e->fields.vector; >>>>>>> =09=09=09irq.delivery_mode =3D e->fields.delivery_mode << 8; >>>>>>> -=09=09=09irq.dest_id =3D e->fields.dest_id; >>>>>>> =09=09=09irq.dest_mode =3D >>>>>>> =09=09=09 kvm_lapic_irq_dest_mode(!!e->fields.dest_mode); >>>>>>> +=09=09=09irq.level =3D 1; >>>>>> 'level' is bool in struct kvm_lapic_irq but other than that, is ther= e a >>>>>> reason we set it to 'true' here? I understand that any particular >>>>>> setting is likely better than random >>>>> Yes, that is the only reason which I had in my mind while doing this = change. >>>>> I was not particularly sure about the value, so I copied what ioapic_= serivce() >>>>> is doing. >>>> Do you think I should skip setting this here? >>>> >>> Personally, i'd initialize it to 'false': usualy, if something is not >>> properly initialized it's either 0 or garbage) >> I think that's true, initializing it to 'false' might make more sense. >> Any other concerns or comments that I can improve? >> > Please add the missing space to the 'Fixes' tag: > > Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target= vCPUs") My bad. > > and with that and irq.level initialized to 'false' feel free to add > > Reviewed-by: Vitaly Kuznetsov > > tag. Thanks! Sure, thank you. > > >>>>>> and it should actually not be used >>>>>> without setting it first but still? >>>>>> >>>>>>> +=09=09=09irq.trig_mode =3D e->fields.trig_mode; >>>>>>> +=09=09=09irq.shorthand =3D APIC_DEST_NOSHORT; >>>>>>> +=09=09=09irq.dest_id =3D e->fields.dest_id; >>>>>>> +=09=09=09irq.msi_redir_hint =3D false; >>>>>>> =09=09=09bitmap_zero(&vcpu_bitmap, 16); >>>>>>> =09=09=09kvm_bitmap_or_dest_vcpus(ioapic->kvm, &irq, >>>>>>> =09=09=09=09=09=09 &vcpu_bitmap); --=20 Nitesh My --oqbaniGLbbOr8DiXzb5gOEA3jk5TXgNn8-- --fpb92n7WBK5nDiLAS3OKzwaHLlI0Mvg0u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkXcoRVGaqvbHPuAGo4ZA3AYyozkFAl5rtvUACgkQo4ZA3AYy ozmsjw//aq9VdHKr2TZf6324U8pmDb/5RZjpeD9szuIPo63V4POYln9mqcvOsitT gAM2NqwobsqFjpfo+YOef/d+P31ZEWC19qHTDUJQ03oRxnx1VK/aCGjj4S0lEkXp t84i1X9TZIY7kxde0OZzt5JKGDgs/5nbjhsKzJobgDcotBXkIT1353L7ouvfvqz7 p4yMvNAiAClYLKuqlBERvW2lfdNNFHbtekjjDrXIxTiCbZYQoHXnKNPkNZ2IRUnw bzQDh7wd8AOvc8P18i97dygW5vj0FGgNaWkg9YTgWrscs9xFLRpRXKpwcJ382YjS 0jay9s2f2z1++A9c742nvPOsWbLG5TlWC/agQLzQBbpomkIU0g/Wt0Y+3zwHkoaj PRkHfvCdMBMrOCy5pVvhrn37p1oxQo3XtO07CURY1HGRQZr/hjTD73stJ6v1/qfl NiTV1gCBq3xUqwn5j+FhpTtmCJBml8u3N458P1rGnksubl+MiUMPLsVGv/WlaEjD 4WFAZydsThpf3lGcWQ2FIcamUshzjDQuKoSMYc3ifahc6TGx9z9GHLw7DI2zuMDf IC+m8xKxvZsI2x3ACLsjdPK1iNxsvlpMO/0HLRh0JYTx+jq4RHMVEyFmnNi79ybk i1DMvoSUX6ha/wPbARtpPO3OuUQs2UffN2owUpnf/Wb6lB+pSU0= =s8Ok -----END PGP SIGNATURE----- --fpb92n7WBK5nDiLAS3OKzwaHLlI0Mvg0u--