From: hayeswang <hayeswang@realtek.com>
To: "'Bjørn Mork'" <bjorn@mork.no>
Cc: <oliver@neukum.org>, <netdev@vger.kernel.org>,
"'nic_swsd'" <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next v2 6/6] r8152: support RTL8153
Date: Fri, 3 Jan 2014 10:56:02 +0800 [thread overview]
Message-ID: <605671F106F540BA9665A195CACB78A0@realtek.com.tw> (raw)
In-Reply-To: <877gai8nqu.fsf@nemi.mork.no>
Bjørn Mork [mailto:bjorn@mork.no]
> Sent: Thursday, January 02, 2014 10:25 PM
> To: Hayeswang
> Cc: oliver@neukum.org; netdev@vger.kernel.org; nic_swsd;
> linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next v2 6/6] r8152: support RTL8153
>
[...]
> > +#if defined(CONFIG_USB_RTL8152) ||
> defined(CONFIG_USB_RTL8152_MODULE)
> > +/* Samsung USB Ethernet Adapters */
> > +{
> > + USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> 0xa101, USB_CLASS_COMM,
> > + USB_CDC_SUBCLASS_ETHERNET, USB_CDC_PROTO_NONE),
> > + .driver_info = 0,
> > +},
> > +#endif
>
>
> We don't play the if-other-driver-is-enabled for any other of the
> blacklisted devices, including other devices supported by the RTL8152
> driver. Why do we need it here?
The USB nic have two configurations. One is the config 2 which is the ECM
mode and uses the driver of cdc_ether. The other is the config 1 which use
the driver of r8152. When the dangle is plugged, I find the configuration
is 2 and the ECM driver would be loaded. By this way, you could select
which mode you want to run. Some people would select ECM mode for
performance, and the other would select r8152 for power saving.
Best Regards,
Hayes
next prev parent reply other threads:[~2014-01-03 2:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 2:34 [PATCH net-next 0/6] Support new chip Hayes Wang
2013-12-27 2:34 ` [PATCH net-next 1/6] r8152: move rtl8152_unload and ocp_reg_write Hayes Wang
2013-12-27 2:34 ` [PATCH net-next 2/6] r8152: modify the method of accessing PHY Hayes Wang
2013-12-27 2:34 ` [PATCH net-next 3/6] r8152: change some definitions Hayes Wang
2013-12-27 18:57 ` Francois Romieu
2013-12-27 2:34 ` [PATCH net-next 4/6] r8152: add rtl_ops Hayes Wang
2013-12-27 17:28 ` David Miller
2013-12-27 2:34 ` [PATCH net-next 5/6] r8152: split rtl8152_enable Hayes Wang
2013-12-27 2:37 ` [PATCH net-next 6/6] r8152: support RTL8153 Hayes Wang
2013-12-27 19:08 ` Francois Romieu
2014-01-02 3:22 ` [PATCH net-next v2 0/6] support new chip Hayes Wang
2014-01-02 3:22 ` [PATCH net-next v2 1/6] r8152: move rtl8152_unload and ocp_reg_write Hayes Wang
2014-01-02 3:22 ` [PATCH net-next v2 2/6] r8152: modify the method of accessing PHY Hayes Wang
2014-01-02 3:22 ` [PATCH net-next v2 3/6] r8152: change some definitions Hayes Wang
2014-01-02 3:22 ` [PATCH net-next v2 4/6] r8152: add rtl_ops Hayes Wang
2014-01-02 3:22 ` [PATCH net-next v2 5/6] r8152: split rtl8152_enable Hayes Wang
2014-01-02 3:25 ` [PATCH net-next v2 6/6] r8152: support RTL8153 Hayes Wang
2014-01-02 14:25 ` Bjørn Mork
2014-01-03 2:56 ` hayeswang [this message]
2014-01-03 7:49 ` Bjørn Mork
2014-01-06 3:20 ` hayeswang
2014-01-06 9:21 ` Bjørn Mork
2014-01-07 12:35 ` hayeswang
2014-01-08 18:24 ` Ben Hutchings
2014-01-02 3:55 ` [PATCH net-next v2 0/6] support new chip David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=605671F106F540BA9665A195CACB78A0@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®