From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C63634EF13; Tue, 11 Nov 2025 10:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762857716; cv=none; b=UNjeiy0wWVHvuC7iCsC9jga4/R+QhKm4w6nWY2HuCr5IUtJ5vZ8bBKu1IeL9G3QcxMV6WC+OQQ29r8Htjmme4cu4hl+61qh0FxuH+wcmf7i7bo02NEGnEcA3ZC+rUaSV064B95l5lqJeU3RbY20VC9RHy5xGiXRUBt3xfRS3Rpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762857716; c=relaxed/simple; bh=NPcaHYhKRGkQGSIVVfqEfkF80g8ZkR0Q3JqOUcG6v2I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=erv1TnkweJsqpiM/wNWrKVYch4+ZoiGGmg18SrCLLFo3KVo7ObhTH4STFidnxaxrunkzlJ7IwFCubHetuHlbvWfK3n8oI+0g0eiYFc9F0JRZev+OX9wM0+dylhPoTbh5lEANx/8gBwj1ciDL4lBNOai71GZPNcSRBN7zs0XsAPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fQR7HdcO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fQR7HdcO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0BEFC4CEF7; Tue, 11 Nov 2025 10:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762857716; bh=NPcaHYhKRGkQGSIVVfqEfkF80g8ZkR0Q3JqOUcG6v2I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fQR7HdcOgKgx/ZXyCXMEK5sFWCT6/ddD8ZiLyMk+Ph8las/yLL505FnVA6r7isH+s sQWTnyLcGIKdh1S8+HuZcMwtiT7fwP8ExWuOoalYDSkD8j+3Qwg29Rjbn9qGORsgWG Yr756m51/mU4TDGhQgSW6/VKTEyw8QYCpkff7AqKzPzoi2xLMZEdRXbUvvSCDWgebr gBAW03FUcLsT8LAnjO248vnUZ9lFxOAgg+PZOQ7ZB5qIbu8AgIIhjwxqHX4+RbSb52 BhT9DSr1rsOqlURuGw5gOJu8HtmBk7GNYi69iMmGzJWocoi2nXX6tFxt+aSiw3T0Vb b7rUalMPOPPbw== Message-ID: <60583236-692f-4605-9f56-f7dadb46558d@kernel.org> Date: Tue, 11 Nov 2025 11:41:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] firmware: qcom: scm: Register gunyah watchdog device To: Dmitry Baryshkov , Pavan Kondeti Cc: hrishabh.rajput@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong References: <20251107-gunyah_watchdog-v5-0-4c6e3fb6eb17@oss.qualcomm.com> <20251107-gunyah_watchdog-v5-1-4c6e3fb6eb17@oss.qualcomm.com> <263d1390-eff5-4846-b2c2-31f96fc3248e@quicinc.com> <3794bb0e-5e2c-4d5e-8d81-d302fa36677c@quicinc.com> <56aqammkwte3tcdzni2unufjp4t4yaqazzdkigrwqsxp3ghcqe@ppe2pjwg3hrl> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <56aqammkwte3tcdzni2unufjp4t4yaqazzdkigrwqsxp3ghcqe@ppe2pjwg3hrl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/11/2025 11:34, Dmitry Baryshkov wrote: > On Tue, Nov 11, 2025 at 10:51:43AM +0530, Pavan Kondeti wrote: >> On Mon, Nov 10, 2025 at 09:43:53AM +0530, Pavan Kondeti wrote: >>> On Sat, Nov 08, 2025 at 07:26:46PM +0200, Dmitry Baryshkov wrote: >>>>> +static void qcom_scm_gunyah_wdt_free(void *data) >>>>> +{ >>>>> + struct platform_device *gunyah_wdt_dev = data; >>>>> + >>>>> + platform_device_unregister(gunyah_wdt_dev); >>>>> +} >>>>> + >>>>> +static void qcom_scm_gunyah_wdt_init(struct qcom_scm *scm) >>>>> +{ >>>>> + struct platform_device *gunyah_wdt_dev; >>>>> + struct device_node *np; >>>>> + bool of_wdt_available; >>>>> + int i; >>>>> + uuid_t gunyah_uuid = UUID_INIT(0xc1d58fcd, 0xa453, 0x5fdb, 0x92, 0x65, >>>> >>>> static const? >>>> >>>>> + 0xce, 0x36, 0x67, 0x3d, 0x5f, 0x14); >>>>> + static const char * const of_wdt_compatible[] = { >>>>> + "qcom,kpss-wdt", >>>>> + "arm,sbsa-gwdt", >>>>> + }; >>>>> + >>>>> + /* Bail out if we are not running under Gunyah */ >>>>> + if (!arm_smccc_hypervisor_has_uuid(&gunyah_uuid)) >>>>> + return; >>>> >>>> This rquires 'select HAVE_ARM_SMCCC_DISCOVERY' >>>> >>> >>> Probably `depends on HAVE_ARM_SMCCC_DISCOVERY` is correct here. >>> >> >> Dmitry / Bjorn, >> >> We are debating on this internally on how to resolve this dependency >> >> - QCOM_SCM depends on HAVE_ARM_SMCCC_DISCOVERY which means restricting >> QCOM_SCM compilation than what it is today. >> >> - Adding #ifdefry around arm_smccc_hypervisor_has_uuid usage in qcom scm driver >> >> - Adding stub for `arm_smccc_hypervisor_has_uuid()` which is not done >> for any of the functions defined in drivers/firmware/smccc/smccc.c >> >> We are trending towards the first option above. Please let us know if >> you think otherwise. > > The same as before: 'select HAVE_ARM_SMCCC_DISCOVERY'. HAVE_ARM_SMCCC_DISCOVERY has a dependency which is not always selected (e.g. ARM32), thus selecting it might lead to warnings of unmet dependencies. Whichever they choose here, they need to be sure to actually compile test it, because existing patch lacks that and reports are proving lack of building. Best regards, Krzysztof