From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 694831DF271 for ; Fri, 27 Jun 2025 18:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751048303; cv=none; b=lBFtRqg4YjNdxUBc1rUF0x9QZw93a1FTsSOokUC5xtZDntgUi1u8fLV25SMSu7favYZDsZR1JwQm/yZeX01DTysQz4pVUW+LvxxvUET1+o4yI04pLFFlZPumhzdKhGWmxNRu0EgCWAD4irVwqlTqZowpr78omjjvDtlTtU4y19I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751048303; c=relaxed/simple; bh=KnagyrEME31deL6Qm0/gI5QVFeXMRzRv0VC11XZU6DM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rdt6QWW//uEqCeHWw6p9pdOoInL4yqMDU/ADpJOHBzresC7BFpONozhHGm2cHEhG55LWHu5i//x0BEBlgYFG25sHw6E/mVnoje1bkJ8MIa/l6XEaADBpV94vKGb+zT9u0QXIerY/6qXWdNtaO4k08QlLwQe/MIxCcghd29Ikh5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yZqv1Fwg; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yZqv1Fwg" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-739f2508ffaso112291a34.2 for ; Fri, 27 Jun 2025 11:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751048300; x=1751653100; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RFQ6dvglvO57dmQMqJ9TjNqvSIg15aNiE+cHR4uuLHU=; b=yZqv1FwgSeK1w99BzolgPb+vZJkZydwvmvnymtRkbTT9AvbZrH154lHQ9yuWO1IdP8 SZT7NWvSQPc049qFD3uTRp8KwbjMNXbM3bSCh3YXEHOVOGjA+R3jqeZv19pGsmFr8R7m QLjOqCepY0EizJ/2RWtVfPx3marJyGjLalZ2eEosQCuCzZaFg4SF6hjjTnKgoWafUY82 j2surN/9PvgxFfjveOgnDgTjKQ/G30chNiaRk7BDxLT4zHs9NVygPmLnR/1r1OrSrosX 4Tzs3GODdnxFCMUxcUHNNaqjCasaGSeRNNCsQdH92NMNfESRNdpyoLzl4HJZrYdmAWdo 0ZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751048300; x=1751653100; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RFQ6dvglvO57dmQMqJ9TjNqvSIg15aNiE+cHR4uuLHU=; b=A7ufzO62QML5Bqd8vTt8W4mCyA5KmamQ918WLFHXNNPPPrV2VHZEg3ju3+AuF9YX1Q AInzpbXwJ9F1VRAr462pbe4pggThWSoSP3EyThjnPpUI92JfrxTZdHuoL5OYY9IKT5US UCQpeGp4AWu8Ou1DWzqXFpJqz1FvFGVPB6fobs48u7Qx6jQh57pS6AkFguUzAb/gV4gv lVzKfJ6IH62g8/lcLPsBCYtAjgKtCgeqLYuGBRhxClcA8733be7xAAo50gFj6ArXMmaA ojYrzyzaJ+SDH3Q3M3MkMQd3gU0mRxNeciGjB1lwK+sgl6xhQ7Q1tWoqsIyYvwjBiHSM fr7w== X-Forwarded-Encrypted: i=1; AJvYcCW3+91pqpg9uQLBeI1Gu01mUSMRwfMesRvpIXtoVHXseB5hYqwr6o4KjiMOQ4LJhqRbhbLljcXLnSoOOGo=@vger.kernel.org X-Gm-Message-State: AOJu0YyNmdrRLb3h2fRLeVUUofHlnOlobOMnqQV9IO0Da3Wp9ArfasDl AA5QAjgkNAVLQtd/yXrlFysWBVvx7MFF5XJKNWsmpJF/gOdMo7d6Lp0wP0+ljYRWscg= X-Gm-Gg: ASbGnctRDdmgtbtsoOuazVIh5A9cYSMQuJ2c6QGnkedgF7upy5aBDNtIEX5wzLE1jDC 2Q3LR9XTUs5j9yX9XQ2tP/t9e61UJxuVR2bg6TcJ53bMNJ7Vs0MW64146poA60lEvRpEiX1AudX vINOA2AsFRCqJCxVkdbx2dOiSH/qCNhcG2EIRK9Hr/x5pZP+fR2SyoNJ2FcV33x5yKSObm/wkjV Kb64Y5Br1nQGPzsClUTj9B4zUsaBaQu0hGGeYqylt/F1HmV6vxUS0qhdYlo1DnHhpTSZuNl5SbO lVzQ7Itrgz0MpRRqc2opY1BJpRX4PJP7mE0QWktfOhJ65auwAPmj9qZZ68FB6WpPEz946g== X-Google-Smtp-Source: AGHT+IGNlF1zWRk96uWanb6ceMhDRXk8o9BVkP04SNj4Cv73ZVCCKgq/Ftq8mRKK3WE38/WIleI/+Q== X-Received: by 2002:a05:6808:1887:b0:406:72ad:bb6b with SMTP id 5614622812f47-40b33e7da1bmr3836758b6e.37.1751048300543; Fri, 27 Jun 2025 11:18:20 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:f3a4:7b11:3bf4:5d7b]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40b322b5900sm456205b6e.18.2025.06.27.11.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 11:18:20 -0700 (PDT) Date: Fri, 27 Jun 2025 21:18:18 +0300 From: Dan Carpenter To: Manish Kumar Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: make g_fbmode[] a read-only pointer array Message-ID: <6059b2f6-4408-41db-8abc-a8a0f38db28e@suswa.mountain> References: <20250627173120.7639-1-manish1588@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jun 27, 2025 at 11:16:06PM +0530, Manish Kumar wrote: > Hi Dan, > > Thank you for the review and pointing out the issue. You're right — > changing the array to `const` makes it unmodifiable, which breaks the > assignment logic in the driver. > > I've reverted the change and will look for another checkpatch warning to > address for the next version of the patch. > Awesome. Thanks. regards, dan carpenter