From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E6FC4332F for ; Mon, 18 Apr 2022 15:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346092AbiDRQAP (ORCPT ); Mon, 18 Apr 2022 12:00:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345920AbiDRQAD (ORCPT ); Mon, 18 Apr 2022 12:00:03 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBF10CF9 for ; Mon, 18 Apr 2022 08:57:04 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id v4so17908066edl.7 for ; Mon, 18 Apr 2022 08:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FjnArbiHeKmHxIQGkXFyLcDATsoCoWvdzs6hnVzyW6g=; b=EaxvZM4sPR/maCfoqX/GP+glDd5U/u7Yf8Vqg32ThP1rPQmS6FMeleFG4TqkU2F3p2 otvkn17tJ6H7Wtl9xR2NdEGg3yPRgmHAY1jS2PIOMMAucDh8ZDBsyDYSZhJ6t5xHEsNY 6B1Asd78N4dE0oC2XPc/PGtGqUjJH/iNDhDZKlfHnduhngAiKEXdvCvNyYXUxhBP/1DF IDxIzLS3vHW1irS5b69DNB/uCQBL1MbGe5l9ke/xKZmcd+Z6xleU5swAtLnNR7y8l3F2 IOfJLDRw5GK7rMzdycYDkMwtwun3yhWApXofTrKF9C9rRoN2CjCB40SXRGxOcpcDi54K YRMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FjnArbiHeKmHxIQGkXFyLcDATsoCoWvdzs6hnVzyW6g=; b=hjN31QV/kDLjWzOv/Dcle0KLI9ELz/cyK5M74Wz1myMePBX35gQL95qZ2lxeQJoeyL Em4PrzHRauIv6K3gaZZKh2vcYgAeJLhZcGaVGwBYrmJpecCJ9JIhyKoCzLernKBSTCV6 uSryvA+QJnmeESSv56vNZsZiyOW+eiibCYfoyQ9DWUg8J5hMRap1vgfUqOifGmstCYuR xbPGKfeBOM1VkudQu99lksgIh7tHEcTE1NuZgsiK/TwSQKpzaTUDVGG1oIa/ipeItf6i tutmY71RAKqAraIlH9fbZZdzbJwwkzDrYT1Aa2fhXo1gBQ4ceI3draB+bYntQ3+xOsaJ lLUQ== X-Gm-Message-State: AOAM532AIgFhMZnua+UYaeFtAyLpBdZqZpVBmkqAfxV/4k0KdBJpRlXC uoCrLTcqiG7hgV1QTkdqlFqq3A== X-Google-Smtp-Source: ABdhPJz5Nk0LJAe1slK1roTE+oxG1zDFX+FnoXU6Ow5CzumX7mijMS7IuiMHrwNK7ouJ9w2wLzkUnA== X-Received: by 2002:a05:6402:4253:b0:423:e4e0:fdd8 with SMTP id g19-20020a056402425300b00423e4e0fdd8mr6255768edb.193.1650297423228; Mon, 18 Apr 2022 08:57:03 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id l3-20020aa7cac3000000b00422c961c8c9sm5068097edt.78.2022.04.18.08.57.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 08:57:02 -0700 (PDT) Message-ID: <605aa014-19ac-2679-799f-c2410b3fcc3a@linaro.org> Date: Mon, 18 Apr 2022 17:57:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT 3/6] phy: rockchip: Support pcie v3 Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20220416135458.104048-1-linux@fw-web.de> <20220416135458.104048-4-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220416135458.104048-4-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2022 15:54, Frank Wunderlich wrote: > From: Frank Wunderlich > > RK3568 supports PCIe v3 using not Combphy like PCIe v2 on rk3566. > It use a dedicated pcie-phy. Add support for this. > > Signed-off-by: Frank Wunderlich > --- > driver was taken from linux 5.10 based on in > https://github.com/JeffyCN/mirrors > which now has disappeared > --- > drivers/phy/rockchip/Kconfig | 9 + > drivers/phy/rockchip/Makefile | 1 + > .../phy/rockchip/phy-rockchip-snps-pcie3.c | 278 ++++++++++++++++++ > include/dt-bindings/phy/phy-snps-pcie3.h | 21 ++ This goes to separate patch or to the bindings one. File naming is also not correct. Who is the vendor here? "rockchip," or "snps,"? The values look specific to this Rockchip implementation, so the file should be also mentioned in the bindings (e.g. in property using it). Best regards, Krzysztof