From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC191C00528 for ; Tue, 25 Jul 2023 17:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbjGYRPc convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2023 13:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjGYRP3 (ORCPT ); Tue, 25 Jul 2023 13:15:29 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07B9611F; Tue, 25 Jul 2023 10:15:19 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qOLcw-001mdv-ED; Tue, 25 Jul 2023 19:15:14 +0200 Received: from p5086d382.dip0.t-ipconnect.de ([80.134.211.130] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1qOLcw-001NaV-6S; Tue, 25 Jul 2023 19:15:14 +0200 Message-ID: <605d12e8a4fdcb238efc9b18fbd2637474de0049.camel@physik.fu-berlin.de> Subject: Re: [PATCH v2] sparc: Use shared font data From: John Paul Adrian Glaubitz To: "Dr. David Alan Gilbert" , Sam Ravnborg Cc: davem@davemloft.net, benh@kernel.crashing.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 25 Jul 2023 19:15:08 +0200 In-Reply-To: References: <20230724235851.165871-1-linux@treblig.org> <20230725161040.GA832394@ravnborg.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 80.134.211.130 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave! On Tue, 2023-07-25 at 16:53 +0000, Dr. David Alan Gilbert wrote: > * Sam Ravnborg (sam@ravnborg.org) wrote: > > On Tue, Jul 25, 2023 at 12:58:51AM +0100, linux@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > sparc has a 'btext' font used for the console which is almost identical > > > to the shared font_sun8x16, so use it rather than duplicating the data. > > > > > > They were actually identical until about a decade ago when > > > commit bcfbeecea11c ("drivers: console: font_: Change a glyph from > > > "broken bar" to "vertical line"") > > > > > > which changed the | in the shared font to be a solid > > > bar rather than a broken bar. That's the only difference. > > > > > > This was originally spotted by PMD which noticed that PPC does > > > the same thing with the same data, and they also share a bunch > > > of functions to manipulate the data. The PPC code and the functions > > > I'll look at another time if this patch is OK. > > > > > > Tested very lightly with a boot without FS in qemu. > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > > Looks good, thanks for the fixes. > > Reviewed-by: Sam Ravnborg > > Thanks > > > Let's hope someone picks it up... > > I was hoping Dave would, but I realise Sparc doesn't get much > these days. > Of course if anyone feels guilty about their own patches adding code > they can take this patch to make ~340 lines of penance. You can ask Andrew Morton to pick it up through his tree. He usually does that when no one else is willing to pick a patch up. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913