From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20096C433EF for ; Fri, 4 Mar 2022 09:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239360AbiCDJrL (ORCPT ); Fri, 4 Mar 2022 04:47:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232875AbiCDJrJ (ORCPT ); Fri, 4 Mar 2022 04:47:09 -0500 Received: from smtp-bc0f.mail.infomaniak.ch (smtp-bc0f.mail.infomaniak.ch [45.157.188.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F16D31A41E9 for ; Fri, 4 Mar 2022 01:46:18 -0800 (PST) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4K92zr0nkKzMr6ZF; Fri, 4 Mar 2022 10:46:16 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4K92zq2Pb6zljTg6; Fri, 4 Mar 2022 10:46:15 +0100 (CET) Message-ID: <605d7e16-d5ee-9d6e-36c4-02bf1d071e99@digikod.net> Date: Fri, 4 Mar 2022 10:46:21 +0100 MIME-Version: 1.0 User-Agent: Content-Language: en-US To: Muhammad Usama Anjum , Shuah Khan , Shuah Khan Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Andrew Morton References: <20220303110629.2072927-1-usama.anjum@collabora.com> <660ad768-2437-92bb-d5ef-0ca8561499d4@collabora.com> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Subject: Re: [PATCH] selftests/interpreter: fix separate directory build In-Reply-To: <660ad768-2437-92bb-d5ef-0ca8561499d4@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2022 08:34, Muhammad Usama Anjum wrote: > On 3/4/22 2:39 AM, Shuah Khan wrote: >> On 3/3/22 4:06 AM, Muhammad Usama Anjum wrote: >>> Separate directory build fails of this test as headers include path isn't >>> set correctly in that case. Fix it by including KHDR_INCLUDES. >>> >>> make -C tools/testing/selftests O=build1 >>> gcc -Wall -O2 -I../../../../usr/include    trust_policy_test.c -lcap >>> -o /linux_mainline/build1/kselftest/interpreter/trust_policy_test >>> trust_policy_test.c:14:10: fatal error: linux/trusted-for.h: No such >>> file or directory >>>     14 | #include >>>        |          ^~~~~~~~~~~~~~~~~~~~~ >>> compilation terminated. >>> >>> Signed-off-by: Muhammad Usama Anjum Reviewed-by: Mickaël Salaün >>> --- >>>   tools/testing/selftests/interpreter/Makefile | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/interpreter/Makefile >>> b/tools/testing/selftests/interpreter/Makefile >>> index 7402fdb6533f..51dde8e01e32 100644 >>> --- a/tools/testing/selftests/interpreter/Makefile >>> +++ b/tools/testing/selftests/interpreter/Makefile >>> @@ -1,6 +1,6 @@ >>>   # SPDX-License-Identifier: GPL-2.0 >>>   -CFLAGS += -Wall -O2 -I$(khdr_dir) >>> +CFLAGS += -Wall -O2 -I$(khdr_dir) $(KHDR_INCLUDES) >>>   LDLIBS += -lcap >>> >> >> Change looks fine to me. >> >>>   src_test := $(wildcard *_test.c) >>> >> >> I am not seeing this test in linux-kselftest next for sure. Which tree is >> this patch based on? Please  add the repo info to the patch subject line >> in the future. >> > This patch is in linux-next and its build is failing from quite some time: > https://storage.staging.kernelci.org/kernelci/staging-next/staging-next-20220301.0/x86_64/x86_64_defconfig+x86-chromebook+kselftest/gcc-10/logs/kselftest.log > > I'm not sure in which tree selftests/interpreter is present. It was sent > here: > https://lore.kernel.org/lkml/20220104155024.48023-5-mic@digikod.net/ > > How can I find the tree from which this patch is coming? As explained in the cover letter, it is now in my tree. To get the list of people to contact (and Cc) you should use ./script/get_maintainer.pl The KHDR_INCLUDES series [1] was merged after the selftests/interpreter commits, hence the confusion with these two forks. Because make doesn't care about unknown variables, and to get a consistent series, I'll apply this patch just after the selftests/interpreter one. Thanks! [1] https://lore.kernel.org/all/20220119101531.2850400-1-usama.anjum@collabora.com/ > >> Either way I don't have the patch that added in liunx-kselftest repo: >> >> Reviewed-by: Shuah Khan >> >> thanks, >> -- Shuah > > I forgot to add the tag: > Reported-by: "kernelci.org bot" > > -- > Muhammad Usama Anjum