From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Haibo Chen <haibo.chen@nxp.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v3 2/5] mtd: spi-nor: micron-st: move set_octal_dtr to late_init()
Date: Wed, 12 Nov 2025 11:01:53 +0200 [thread overview]
Message-ID: <60625b83-aef6-442b-8b38-558c3751c4a6@linaro.org> (raw)
In-Reply-To: <20251112-nor-v3-2-20aaff727c7d@nxp.com>
On 11/12/25 8:48 AM, Haibo Chen wrote:
> Move params->set_octal_dtr from flash_info->fixups->default_init()
> to spi_nor_manufacturer-> fixups-> late_init(), this can cover
> all Micorn and ST chips without repeat in each chip's flash_info.
>
> With this, we can also remove flash_info->size if chip has SFDP.
you could remove flash_info->size when chip has SFDP even before
your patch, as params->size is first initialized with
flash_info->size and then overwritten with the flash size read
from SFDP.
So this comment is misleading and has to be dropped. With that:
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
next prev parent reply other threads:[~2025-11-12 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 6:48 [PATCH v3 0/5] mtd: spi-nor: micron-st: few clean up for micron spi nor chip Haibo Chen
2025-11-12 6:48 ` [PATCH v3 1/5] mtd: spi-nor: micron-st: rename the die_late_init functions Haibo Chen
2025-11-12 6:48 ` [PATCH v3 2/5] mtd: spi-nor: micron-st: move set_octal_dtr to late_init() Haibo Chen
2025-11-12 9:01 ` Tudor Ambarus [this message]
2025-11-12 6:48 ` [PATCH v3 3/5] mtd: spi-nor: micron-st: use SFDP of mt35xu512aba Haibo Chen
2025-11-12 9:05 ` Tudor Ambarus
2025-11-12 6:48 ` [PATCH v3 4/5] mtd: spi-nor: micron-st: add mt35xu01gbba support Haibo Chen
2025-11-12 9:07 ` Tudor Ambarus
2025-11-12 6:48 ` [PATCH v3 5/5] mtd: spi-nor: micron-st: add comment for mt35xu02gcba Haibo Chen
2025-11-12 9:21 ` Tudor Ambarus
2025-11-12 9:22 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60625b83-aef6-442b-8b38-558c3751c4a6@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®