From: Stephan Mueller <smueller@chronox.de>
To: Eric Biggers <ebiggers@kernel.org>,
Frederick Lawler <fred@cloudflare.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net, hch@lst.de,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
kernel-team@cloudflare.com, Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [RFC PATCH 1/1] crypto: af_alg - Support symmetric encryption via keyring keys
Date: Wed, 12 Oct 2022 17:21:21 +0200 [thread overview]
Message-ID: <6063928.z1iD19Vvxs@tauon.chronox.de> (raw)
In-Reply-To: <cc5c3efe-7dc3-65d6-d7d9-761bfc2c9711@cloudflare.com>
Am Mittwoch, 12. Oktober 2022, 16:49:56 CEST schrieb Frederick Lawler:
Hi Frederick,
> I believe I've addressed most of the feedback. Starting with we agree
> preferring key_serial_t. I changed to to use IS_REACHABLE(), and set
> ALG_SET_KEY_BY_KEY_SERIAL to 10 leaving a comment about libkcapi
> reserving values 7-9.
This reservation should not be observed. I provided patches for adding AF_ALG
interfaces for KPP and AKCIPHER some time ago which were rejected. Libkcapi
still contains the interface implementations but are not compiled by default.
As the patches are rejected, their values should not be considered as
relevant. Thus, I think your patch should not keep holes in the numbers.
Ciao
Stephan
prev parent reply other threads:[~2022-10-12 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 21:29 Frederick Lawler
2022-10-11 23:07 ` Eric Biggers
2022-10-12 14:49 ` Frederick Lawler
2022-10-12 15:21 ` Stephan Mueller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6063928.z1iD19Vvxs@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=fred@cloudflare.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@cloudflare.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®